vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

Avoid returning nil, nil when fetching a manifest by tag by introducing a new

Browse source 
error ErrManifestNotModified which can be checked by clients.

Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
This commit is contained in:
Richard Scothern 2015-09-18 11:00:44 -07:00
parent 5a8fabfee3
commit b8a1ec4155
3 changed files with 5 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docs/proxy/proxymanifeststore.go
View file

@ -102,11 +102,11 @@ func (pms proxyManifestStore) GetByTag(tag string, options ...distribution.Manif
fromremote:
var sm *schema1.SignedManifest
sm, err = pms.remoteManifests.GetByTag(tag, client.AddEtagToTag(tag, localDigest.String()))
if err != nil {
if err != nil && err != distribution.ErrManifestNotModified {
return nil, err
}
if sm == nil {
if err == distribution.ErrManifestNotModified {
context.GetLogger(pms.ctx).Debugf("Local manifest for %q is latest, dgst=%s", tag, localDigest.String())
return localManifest, nil
}