vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

S3 Driver: added comment for missing KeyCount workaround

Browse source 
Signed-off-by: Thomas Berger <loki@lokis-chaos.de>
Signed-off-by: wang yan <wangyan@vmware.com>
This commit is contained in:
Thomas Berger 2019-03-15 21:05:21 +01:00 committed by wang yan
parent 0a1e4a57e2
commit e2f006ac2b
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
registry/storage/driver/s3-aws/s3.go
View file

@ -971,6 +971,9 @@ func (d *driver) doWalk(parentCtx context.Context, objectCount *int64, path, pre
listObjectErr := d.S3.ListObjectsV2PagesWithContext(ctx, listObjectsInput, func(objects *s3.ListObjectsV2Output, lastPage bool) bool { listObjectErr := d.S3.ListObjectsV2PagesWithContext(ctx, listObjectsInput, func(objects *s3.ListObjectsV2Output, lastPage bool) bool {
var count int64 var count int64
// KeyCount was introduced with version 2 of the GET Bucket operation in S3.
// Some S3 implementations don't support V2 now, so we fall back to manual
// calculation of the key count if required
if objects.KeyCount != nil { if objects.KeyCount != nil {
count = *objects.KeyCount count = *objects.KeyCount
*objectCount += *objects.KeyCount *objectCount += *objects.KeyCount