vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

use http consts for request methods

Browse source 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2022-11-02 23:31:23 +01:00
parent 7f9f86c411
commit f9ccd2c6ea
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
33 changed files with 211 additions and 211 deletions
Download patch file Download diff file Expand all files Collapse all files

4
health/api/api.go
View file

@ -13,7 +13,7 @@ var (
// DownHandler registers a manual_http_status that always returns an Error
func DownHandler(w http.ResponseWriter, r *http.Request) {
if r.Method == "POST" {
if r.Method == http.MethodPost {
updater.Update(errors.New("manual Check"))
} else {
w.WriteHeader(http.StatusNotFound)
@ -22,7 +22,7 @@ func DownHandler(w http.ResponseWriter, r *http.Request) {
// UpHandler registers a manual_http_status that always returns nil
func UpHandler(w http.ResponseWriter, r *http.Request) {
if r.Method == "POST" {
if r.Method == http.MethodPost {
updater.Update(nil)
} else {
w.WriteHeader(http.StatusNotFound)

8
health/api/api_test.go
View file

@ -13,7 +13,7 @@ import (
func TestGETDownHandlerDoesNotChangeStatus(t *testing.T) {
recorder := httptest.NewRecorder()
req, err := http.NewRequest("GET", "https://fakeurl.com/debug/health/down", nil)
req, err := http.NewRequest(http.MethodGet, "https://fakeurl.com/debug/health/down", nil)
if err != nil {
t.Errorf("Failed to create request.")
}
@ -30,7 +30,7 @@ func TestGETDownHandlerDoesNotChangeStatus(t *testing.T) {
func TestGETUpHandlerDoesNotChangeStatus(t *testing.T) {
recorder := httptest.NewRecorder()
req, err := http.NewRequest("GET", "https://fakeurl.com/debug/health/up", nil)
req, err := http.NewRequest(http.MethodGet, "https://fakeurl.com/debug/health/up", nil)
if err != nil {
t.Errorf("Failed to create request.")
}
@ -48,7 +48,7 @@ func TestGETUpHandlerDoesNotChangeStatus(t *testing.T) {
func TestPOSTDownHandlerChangeStatus(t *testing.T) {
recorder := httptest.NewRecorder()
req, err := http.NewRequest("POST", "https://fakeurl.com/debug/health/down", nil)
req, err := http.NewRequest(http.MethodPost, "https://fakeurl.com/debug/health/down", nil)
if err != nil {
t.Errorf("Failed to create request.")
}
@ -69,7 +69,7 @@ func TestPOSTDownHandlerChangeStatus(t *testing.T) {
func TestPOSTUpHandlerChangeStatus(t *testing.T) {
recorder := httptest.NewRecorder()
req, err := http.NewRequest("POST", "https://fakeurl.com/debug/health/up", nil)
req, err := http.NewRequest(http.MethodPost, "https://fakeurl.com/debug/health/up", nil)
if err != nil {
t.Errorf("Failed to create request.")
}