vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

StorageDriver: Test suite: improve cleanup

Browse source 
Verify that the file(s) have been deleted after calling Delete,
and retry if this is not the case. Furthermore, report the error
if a Delete operation fails.

Signed-off-by: Arthur Baars <arthur@semmle.com>
This commit is contained in:
Arthur Baars 2016-01-19 14:09:32 +00:00
parent e4b654f2ce
commit ffc9527782
3 changed files with 57 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

8
docs/storage/driver/gcs/gcs_test.go
View file

@ -155,8 +155,12 @@ func TestEmptyRootList(t *testing.T) {
if err != nil {
t.Fatalf("unexpected error creating content: %v", err)
}
defer rootedDriver.Delete(ctx, filename)
defer func() {
err := rootedDriver.Delete(ctx, filename)
if err != nil {
t.Fatalf("failed to remove %v due to %v\n", filename, err)
}
}()
keys, err := emptyRootDriver.List(ctx, "/")
for _, path := range keys {
if !storagedriver.PathRegexp.MatchString(path) {