vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
763 commits 18 branches 0 tags 22 MiB
Commit graph

195 commits

Author SHA1 Message Date
Stefan Weil
d16f3046c6 Fix some typos in comments and strings 
All of them were found and fixed by codespell.

Signed-off-by: Stefan Weil <sw@weilnetz.de>
 2016-02-23 22:33:38 +01:00
Anton Tiurin
2e8244822c Fix description of StorageDriver.WriteStream 
Offset can be more than CurrentSize as long as this case is checked
by DriverSuite.testContinueStreamAppend.

Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
 2016-02-17 13:57:20 +03:00
Brian Bland
c6871737bc [driver/s3aws] Fix TestStorageClass 
Fixes bug in TestStorageClass for s3aws driver where the "standard" file
was checked for reduced-redundnancy storage.

Signed-off-by: Brian Bland <brian.bland@docker.com>
 2016-02-16 17:50:55 -08:00
Brian Bland
881ef1096f Merge pull request #1385 from BrianBland/s3UseAWSLibrary 
[driver/s3] Use aws/aws-sdk-go instead of goamz for s3 driver and cloudfront
 2016-02-16 11:19:15 -08:00
liuchang0812
7ca24a7f5a fix gofmt 
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
 2016-02-16 11:42:09 +08:00
liuchang0812
ad6a0735d2 closes #1461, enhance log message of oss driver 
Signed-off-by: liuchang0812 <liuchang0812@gmail.com>
 2016-02-16 11:17:09 +08:00
Brian Bland
d5a38e4c5f Adds new s3 driver using aws-sdk-go instead of goamz 
Keeps old s3 driver, renames to s3goamz, registers new s3 driver as both
"s3" and "s3aws"

Changes cloudfront middleware to use aws-sdk-go

Signed-off-by: Brian Bland <brian.bland@docker.com>
 2016-02-12 15:59:26 -08:00
Aaron Lehmann
f77c82ebb3 Typo fixes in comments 
Correct spelling of words in source code comments.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
 2016-02-10 16:26:29 -08:00
Brian Bland
4bb5f80885 Improves flexibility of configuration handling for S3 driver 
Treats nil parameters the same as unprovided parameters (fixes issues
where certain parameters are printed to "<nil>").
Accepts "true" and "false" string values for boolean parameters.

Signed-off-by: Brian Bland <brian.bland@docker.com>
 2016-02-09 17:27:16 -08:00
Richard Scothern
def3e430bb Merge pull request #1401 from BrianBland/s3StorageClass 
Adds "storageclass" configuration parameter for S3 driver.
 2016-02-04 16:44:13 -08:00
yuzou
95b9c7281b read the actual number of bytes according to the initial size. 
Signed-off-by: yuzou <zouyu7@huawei.com>
 2016-02-04 16:14:35 +08:00
Brian Bland
a2ade36ecf Adds test for S3 storage class configuration option 
Signed-off-by: Brian Bland <brian.bland@docker.com>
 2016-02-01 16:01:55 -08:00
Brian Bland
8e7910826e Adds "storageclass" configuration parameter for S3 driver. 
Defaults to STANDARD, also supports REDUCED_REDUNDANCY.

Signed-off-by: Brian Bland <brian.bland@docker.com>
 2016-02-01 16:01:19 -08:00
Aaron Lehmann
6417c05a27 Merge pull request #1381 from BrianBland/s3CustomUAString 
Adds custom registry User-Agent header to s3 HTTP requests
 2016-02-01 15:40:36 -08:00
Brian Bland
f41a408e34 Adds custom registry User-Agent header to s3 HTTP requests 
Uses docker/goamz instead of AdRoll/goamz

Adds a registry UA string param to the storage parameters when
constructing the storage driver for the registry App.
This could be used by other storage drivers as well

Signed-off-by: Brian Bland <brian.bland@docker.com>
 2016-02-01 13:43:46 -08:00
Arthur Baars
59a9607783 StorageDriver: GCS: retry all api calls 
Signed-off-by: Arthur Baars <arthur@semmle.com>
 2016-01-20 13:24:09 +00:00
Arthur Baars
ffc9527782 StorageDriver: Test suite: improve cleanup 
Verify that the file(s) have been deleted after calling Delete,
and retry if this is not the case. Furthermore, report the error
if a Delete operation fails.

Signed-off-by: Arthur Baars <arthur@semmle.com>
 2016-01-20 13:24:09 +00:00
Richard Scothern
b2876674f3 Merge pull request #1355 from hopkings2008/master 
In testsuites.go, enlarge the size of randomBytes to 128M to fix the …
 2016-01-18 12:38:26 -08:00
Arthur Baars
985c0d602f StorageDriver GCS: try google.DefaultTokenSource first 
Signed-off-by: Arthur Baars <arthur@semmle.com>
 2016-01-15 11:47:47 +00:00
yuzou
d3d9282a30 In testsuites.go, enlarge the size of randomBytes to 128M to fix the crash of running TestConcurrentStreamReads 
Signed-off-by: yuzou <zouyu7@huawei.com>
 2016-01-15 17:22:43 +08:00
Richard Scothern
5d35fa34c1 Change the parameters to the GCS drivers to allow CircleCI testing. 
Remove the requirement of file system access to run GCS unit tests.  Deconstruct
the input parameters to take the private key and email which can be specified on
the build system via environment variables.

Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
 2016-01-13 18:00:59 -08:00
Richard Scothern
e5e0e2cc2a Merge pull request #1276 from denverdino/oss-test 
Support large layer for OSS driver
 2016-01-08 13:26:09 -08:00
Richard Scothern
6a248e115b Merge pull request #1321 from aibaars/gcs-fix-retry 
GCS storage driver: fix retry function
 2016-01-06 12:00:12 -08:00
Arthur Baars
5c6fdc710f GCS Storagedriver: fix test failure caused by #1187 
Signed-off-by: Arthur Baars <arthur@semmle.com>
 2016-01-06 18:36:28 +00:00
Arthur Baars
bf1e41a9f2 GCS driver: fix retry function 
Signed-off-by: Arthur Baars <arthur@semmle.com>
 2016-01-06 17:57:22 +00:00
weiyuan.yl
5dc714b347 Replace 404 to http.StatusNotFound 
Change-Id: Ia100975cb93c0a6d94ea5542b1c9ce386bc87649
Signed-off-by: weiyuan.yl <weiyuan.yl@alibaba-inc.com>
 2015-12-29 12:09:04 +08:00
Brian Bland
165507a622 Relaxes filesystem driver permissions to 0777 (dirs) and 0666 (files) 
Leaves any further permissions restrictions to the process umask

Signed-off-by: Brian Bland <brian.bland@docker.com>
 2015-12-28 15:22:28 -08:00
weiyuan.yl
dc6944d91d In HEAD request for missing resource, only 404 NOT FOUND is returned 
Change-Id: I73caf67b59519e6f4f82f7d78f5d4fd4ad9affcd
Signed-off-by: weiyuan.yl <weiyuan.yl@alibaba-inc.com>
 2015-12-28 11:28:42 +08:00
Li Yi
cfd2f03920 Support large layer for OSS driver 
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-12-11 10:56:50 +08:00
Richard Scothern
e6363e8a20 Merge pull request #1187 from stevvooe/check-storage-drivers-list-path-not-found 
[WIP] registry/storage/driver: checking that non-existent path returns PathNotFoundError
 2015-12-08 16:32:02 -08:00
Stephen J Day
d68acc869e storage/driver/s3: adjust s3 driver to return unmunged path 
This fixes both the s3 driver and the oss driver to return the unmunged path
when returning errors.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
 2015-12-08 15:48:55 -08:00
Stephen Day
3032cd2aa9 Merge pull request #1246 from stevvooe/decrease-driver-testsuite-allocations 
storage/driver: decrease memory allocation done during testsuite
 2015-12-08 14:52:59 -08:00
Li Yi
533c912d3e Fix the issue for listing root directory 
Change-Id: I1c6181fa4e5666bd2e6ec69cb608c4778ae0fe48
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-12-08 12:04:04 -08:00
Li Yi
3a5c6446d8 Fix for stevvooe:check-storage-drivers-list-path-not-found in OSS driver 
Change-Id: I5e96fe761d3833c962084fd2d597f47e8a72e7c2
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-12-08 12:04:04 -08:00
davidli
aa08ced9d7 driver/swift: treat empty object list as a PathNotFoundError 
Swift returns an empty object list when trying to read a non-existing object path, treat it as a
PathNotFoundError when trying to list a non existing virtual directory.

Signed-off-by: David li <wenquan.li@hpe.com>
 2015-12-08 12:04:04 -08:00
Vincent Giersch
c39158d48c driver/rados: treat OMAP EIO as a PathNotFoundError 
RADOS returns a -EIO when trying to read a non-existing OMAP, treat it as a
PathNotFoundError when trying to list a non existing virtual directory.

Signed-off-by: Vincent Giersch <vincent@giersch.fr>
 2015-12-08 12:04:04 -08:00
Stephen J Day
10f7b7bf95 storage/driver/s3: correct response on list of missing directory 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
 2015-12-08 12:04:03 -08:00
Stephen J Day
dc5b71afb0 storage/driver/base: use correct error format style 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
 2015-12-08 12:04:03 -08:00
Stephen J Day
c46d32bfbb driver/filesystem: address filesystem driver on behavior of List 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
 2015-12-08 12:04:03 -08:00
Stephen J Day
4829e9685e registry/storage/driver: checking that non-existent path returns PathNotFoundError 
Issue #1186 describes a condition where a null tags response is returned when
using the s3 driver. The issue seems to be related to a missing
PathNotFoundError in s3. This change adds a test for that to get an idea of the
lack of compliance across storage drivers. If the failures are manageable,
we'll add this test condition and fix the s3 driver.

Signed-off-by: Stephen J Day <stephen.day@docker.com>
 2015-12-08 12:04:03 -08:00
Stephen Day
51c5b868b1 Merge pull request #1238 from noxiouz/fix_comment 
Fix comment for PathRegexp
 2015-12-08 10:41:16 -08:00
Stephen J Day
be2985a35d storage/driver: decrease memory allocation done during testsuite 
Signed-off-by: Stephen J Day <stephen.day@docker.com>
 2015-12-07 19:05:13 -08:00
Anton Tiurin
d6cc32965e Fix comment for PathRegexp 
Signed-off-by: Anton Tiurin <noxiouz@yandex.ru>
 2015-12-04 22:14:21 +03:00
Sylvain Baubeau
b596464d38 Use bulk delete to remove segments in Swift driver 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-12-04 12:16:49 +01:00
Richard Scothern
aaf448b2de Merge pull request #1141 from lebauce/swift-no-missing-segment 
Ensure read after write for segments
 2015-11-10 10:39:43 -08:00
Aaron Lehmann
accfa46f9b Fix empty delete requests with Swift fs driver 
The Delete method lists objects under the given path and tries to delete
all of them with a bulk delete request. If the path has no objects
underneath it, the body of this request will be empty, which causes
HTTP-level issues. Specifically, Go's HTTP client senses the empty
request buffer and doesn't include a Content-Length, which causes the
Swift server to fail the request.

This commit fixes the problem by avoiding sending empty bulk delete
requests. This is the correct thing to do anyway, since there's no
reason to request deletion of zero objects.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
 2015-11-09 15:33:05 -08:00
Richard Scothern
e79324edd8 Add a generic error type to capture non-typed errors 
Signed-off-by: Richard Scothern <richard.scothern@gmail.com>
 2015-11-03 11:19:44 -08:00
amitshukla
7840a5bc8f Fix for issue 664: https://github.com/docker/distribution/issues/664 
Errors thrown by storage drivers don't have the name of the driver, causing user
confusion about whether the error is coming from Docker or from a storage driver.
This change adds the storage driver name to each error message.

This required changing ErrUnsupportedDriver to a type, leading to code changes
whenever ErrUnsupportedDriver is used.  The tests check whether the driver name
appears in the error message.

Signed-off-by: Amit Shukla <amit.shukla@docker.com>
 2015-11-03 11:19:17 -08:00
Sylvain Baubeau
34c1d0ed50 Ensure read after write for segments 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-11-03 17:09:52 +01:00
Sylvain Baubeau
11546b5309 Add support for temporary URL for Swift driver 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-11-03 09:59:50 +01:00
Arthur Baars
98ad17f757 Storage driver for: Google Cloud Storage (gcs) 
Signed-off-by: Arthur Baars <arthur@semmle.com>
 2015-10-28 20:21:56 +00:00
Richard Scothern
1039e2dc26 Merge pull request #950 from jackpgriffin/master 
Skip creating swift container if already exists
 2015-10-01 10:15:54 -07:00
Nuutti Kotivuori
84e7c07c42 Remove initial access check from S3 driver 
In the S3 storage driver there is currently an initial access permission check by listing the bucket. If this check fails, registry will panic and exit.

However, this check is broken in two ways. First of all it strips the final slash from the root directory path, meaning that any access permissions which limit access to a single directory will fail, because S3 treats the path as strict prefix match. Secondly it fails to strip any leading slash that might be present, unlike the other access places, which means that the path used is different as a leading slash is allowed and significant in a filename in S3.

Since there is also a periodic health check which correctly checks access permissions and shows the error more cleanly, the best solution seems to be to just remove this initial access check.

Signed-off-by: Nuutti Kotivuori <nuutti.kotivuori@poplatek.fi>
 2015-09-19 12:47:12 +03:00
Jack Griffin
8ceca304b0 Skip creating swift container if already exists 
Signed-off-by: Jack Griffin <jackpg14@gmail.com>
 2015-09-04 18:53:17 +00:00
Hua Wang
8f5f6a4e59 Add TrustId parameter to swift driver 
github/ncw/swift has added support for trust, so let's add it.

Signed-off-by: Hua Wang <wanghua.humble@gmail.com>
 2015-09-02 15:05:29 +08:00
Vincent Giersch
9bf231e0fa fix(rados): Create OMAP for root directory 
When using the RADOS driver, the hierarchy of the files is stored
in OMAPs, but the root OMAP was not created and a call to List("/")
was returning an error instead of returned the first level files
stored. This patches creates an OMAP for "/" and excludes the listed
directory from the list of files returned.

Signed-off-by: Vincent Giersch <vincent@giersch.fr>
 2015-08-10 23:46:33 +02:00
tgic
f01a0694c1 remove unused code and fix todo format 
Signed-off-by: tgic <farmer1992@gmail.com>
 2015-07-31 13:22:56 +08:00
tgic
90595c7ed9 fix goimports 
Signed-off-by: tgic <farmer1992@gmail.com>
 2015-07-31 13:22:56 +08:00
tgic
235ccc0590 add include_oss build tag 
Signed-off-by: tgic <farmer1992@gmail.com>
 2015-07-31 13:22:56 +08:00
Li Yi
9c27080c7a Update the comment for the consistency model 
Change-Id: Iee49afeda1c11d6af8c0f26c96d8ccc328c22757
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-07-31 13:22:55 +08:00
Li Yi
5d34d31739 Update the comments for consistence model 
Change-Id: I161522ee51f247fb17e42844b3699bd9031e34e8
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-07-31 13:22:55 +08:00
tgic
faee422420 fix testcase TestReadStreamWithOffset incompatible with oss 
Signed-off-by: tgic <farmer1992@gmail.com>
 2015-07-31 13:22:55 +08:00
tgic
a9c3f86ce0 fix oss: got 403 in TestContinueStreamAppendLarge 
Signed-off-by: tgic <farmer1992@gmail.com>
 2015-07-31 13:22:55 +08:00
Li Yi
440664a109 Update the OSS test case for latest code change 
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-07-31 13:22:55 +08:00
tgic
fc20dd72d6 check access key and secret before run 2015-07-31 13:22:55 +08:00
tgic
d28a3fa28a add endpoint support 2015-07-31 13:22:54 +08:00
Li Yi
46148721e1 Add the secure access with HTTPS 
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-07-31 13:22:54 +08:00
Li Yi
bffce5722e Fix the warning of golint 
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-07-31 13:22:54 +08:00
Li Yi
d79179884a Support OSS driver 
Signed-off-by: Li Yi <denverdino@gmail.com>
 2015-07-31 13:22:54 +08:00
Stephen Day
96efb19952 Merge pull request #493 from nevermosby/storage-support-openstack-swift 
Storage support openstack swift
 2015-07-22 23:53:36 -07:00
davidli
b2935158b2 Remove IPC support from test file 
Signed-off-by: Li Wenquan <wenquan.li@hp.com>
 2015-07-21 23:55:10 +02:00
Sylvain Baubeau
81765f8cbb Catch either missing containers or objects 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:10 +02:00
Sylvain Baubeau
52d28ec81a Do not use Swift server side copy for manifests to handle >5G files 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:10 +02:00
Sylvain Baubeau
000dec3c6f Inline Swift errors handling 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:10 +02:00
Sylvain Baubeau
661f197f68 Retrieve all the objects using pagination 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
704e082254 Do not create objects for directories 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
f190aa4a7c Refactor segment path concatenation code 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
0807282859 Use http.StatusRequestedRangeNotSatisfiable instead of error code 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
7a5aa32a64 Use file instead of filepath as it may cause troubles on Windows 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
91d74a3ee2 Protect against deletion of objects with the same prefix 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
01686e2c07 Show distribution version in User-Agent 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
913fe195fd Do not use suite style testing for Swift specific tests 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
1b28eea232 Rename environment variables to run Swift testsuite 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
2524f300dc Check file has been opened before closing it 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
fbc74a6457 Rename DriverParameters structure to Parameters 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
80bfcb68a8 Change folder mime type to application/vnc.swift.directory 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
7b0276dce5 Add code documentation 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
5cce023aa9 Do not read segment if no padding is necessary 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
d91c4cb694 Improve 404 errors handling 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
9ab55eae39 Use only one Swift container for both files and manifests 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
a1ae7f7122 Increase default chunk size to 20M 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
davidli
062d6266cf Add support for Openstack Identity v3 API 
Signed-off-by: Li Wenquan <wenquan.li@hp.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
3f9e7ed169 Use 'prefix' parameter instead of 'path' when listing files 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
1d46bb2bcc Create full folder hierarchy instead of just the top level folder 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
4e619bc9b1 Remove one level of indentation in swift path handling code 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
75ce67c469 Use mitchellh/mapstructure library to parse Swift parameters 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
ea81e208a4 Move Dynamic Large Object handling to dedicated methods 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
8a22c0f4e1 Simplify code that handles non existing manifests 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
Sylvain Baubeau
16a49ade16 Handle error during copy of original content 
Signed-off-by: Sylvain Baubeau <sbaubeau@redhat.com>
 2015-07-21 23:55:09 +02:00
nevermosby
9f7f23e373 Update the import path for swift driver test 
Signed-off-by: Li Wenquan <wenquan.li@hp.com>
 2015-07-21 23:55:09 +02:00