vbatts/shadowsocks
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

fix a mem leak

Browse source
This commit is contained in:
破娃酱 2017-06-03 23:06:12 +08:00
parent 8826f515b6
commit 47c6e16833
3 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
shadowsocks/common.py
View file

@ -352,7 +352,7 @@ class UDPAsyncDNSHandler(object):
def resolve(self, dns_resolver, remote_addr, call_back): def resolve(self, dns_resolver, remote_addr, call_back):
if remote_addr in UDPAsyncDNSHandler.dns_cache: if remote_addr in UDPAsyncDNSHandler.dns_cache:
if call_back: if call_back:
call_back(remote_addr, UDPAsyncDNSHandler.dns_cache[remote_addr], self.params) call_back("", remote_addr, UDPAsyncDNSHandler.dns_cache[remote_addr], self.params)
else: else:
self.call_back = call_back self.call_back = call_back
self.remote_addr = remote_addr self.remote_addr = remote_addr
@ -362,14 +362,13 @@ class UDPAsyncDNSHandler(object):
def _handle_dns_resolved(self, result, error): def _handle_dns_resolved(self, result, error):
if error: if error:
logging.error("%s when resolve DNS" % (error,)) #drop logging.error("%s when resolve DNS" % (error,)) #drop
return return self.call_back(error, self.remote_addr, None, self.params)
if result: if result:
ip = result[1] ip = result[1]
if ip: if ip:
if self.call_back: return self.call_back("", self.remote_addr, ip, self.params)
self.call_back(self.remote_addr, ip, self.params)
return
logging.warning("can't resolve %s" % (self.remote_addr,)) logging.warning("can't resolve %s" % (self.remote_addr,))
return self.call_back("fail to resolve", self.remote_addr, None, self.params)
def test_inet_conv(): def test_inet_conv():
ipv4 = b'8.8.4.4' ipv4 = b'8.8.4.4'

9
shadowsocks/tcprelay.py
View file

@ -347,9 +347,9 @@ class TCPRelayHandler(object):
handler = common.UDPAsyncDNSHandler(data[header_length:]) handler = common.UDPAsyncDNSHandler(data[header_length:])
handler.resolve(self._dns_resolver, (dest_addr, dest_port), self._handle_server_dns_resolved) handler.resolve(self._dns_resolver, (dest_addr, dest_port), self._handle_server_dns_resolved)
else: else:
return self._handle_server_dns_resolved((dest_addr, dest_port), dest_addr, data[header_length:]) return self._handle_server_dns_resolved("", (dest_addr, dest_port), dest_addr, data[header_length:])
else: else:
return self._handle_server_dns_resolved((dest_addr, dest_port), dest_addr, data[header_length:]) return self._handle_server_dns_resolved("", (dest_addr, dest_port), dest_addr, data[header_length:])
except Exception as e: except Exception as e:
#trace = traceback.format_exc() #trace = traceback.format_exc()
@ -412,7 +412,10 @@ class TCPRelayHandler(object):
logging.error('write_all_to_sock:unknown socket from %s:%d' % (self._client_address[0], self._client_address[1])) logging.error('write_all_to_sock:unknown socket from %s:%d' % (self._client_address[0], self._client_address[1]))
return True return True
def _handle_server_dns_resolved(self, remote_addr, server_addr, data): def _handle_server_dns_resolved(self, error, remote_addr, server_addr, data):
if error:
self.destroy()
return
try: try:
addrs = socket.getaddrinfo(server_addr, remote_addr[1], 0, socket.SOCK_DGRAM, socket.SOL_UDP) addrs = socket.getaddrinfo(server_addr, remote_addr[1], 0, socket.SOCK_DGRAM, socket.SOL_UDP)
if not addrs: # drop if not addrs: # drop

8
shadowsocks/udprelay.py
View file

@ -388,11 +388,13 @@ class UDPRelay(object):
handler = common.UDPAsyncDNSHandler((data, r_addr, uid, header_length)) handler = common.UDPAsyncDNSHandler((data, r_addr, uid, header_length))
handler.resolve(self._dns_resolver, (server_addr, server_port), self._handle_server_dns_resolved) handler.resolve(self._dns_resolver, (server_addr, server_port), self._handle_server_dns_resolved)
else: else:
self._handle_server_dns_resolved((server_addr, server_port), server_addr, (data, r_addr, uid, header_length)) self._handle_server_dns_resolved("", (server_addr, server_port), server_addr, (data, r_addr, uid, header_length))
else: else:
self._handle_server_dns_resolved((server_addr, server_port), server_addr, (data, r_addr, uid, header_length)) self._handle_server_dns_resolved("", (server_addr, server_port), server_addr, (data, r_addr, uid, header_length))
def _handle_server_dns_resolved(self, remote_addr, server_addr, params): def _handle_server_dns_resolved(self, error, remote_addr, server_addr, params):
if error:
return
data, r_addr, uid, header_length = params data, r_addr, uid, header_length = params
user_id = self._listen_port user_id = self._listen_port
try: try: