From 6814b938af1f01e2edff63a549ae94e077a87187 Mon Sep 17 00:00:00 2001 From: Vincent Batts Date: Wed, 25 Feb 2015 16:26:47 -0500 Subject: [PATCH] tar/asm: adding thoughts on concerns --- tar/asm/README.md | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/tar/asm/README.md b/tar/asm/README.md index f475e8f..60f1cb0 100644 --- a/tar/asm/README.md +++ b/tar/asm/README.md @@ -24,10 +24,19 @@ path would be identical. Thoughts -------- -While the initial implementation is based on a relative path, I'm thinking the -next step is to have something like a FileGetter interface, of which a path -based getter is just one type. +Have a look-aside directory or storage. This way when a clobbering record is +encountered from the tar stream, then the payload of the prior/existing file is +stored to the CAS. This way the clobbering record's file payload can be +extracted, but we'll have preserved the payload needed to reassemble a precise +tar archive. -Then you could pass a path based Getter and an Unpacker, and receive a -io.Reader that is your tar stream. +clobbered/path/to/file.[0-N] + +*alternatively* + +We could just _not_ support tar streams that have clobbering file paths. +Appending records to the archive is not incredibly common, and doesn't happen +by default for most implementations. Not supporting them wouldn't be a +security concern either, as if it did occur, we would reassemble an archive +that doesn't validate signature/checksum, so it shouldn't be trusted anyway.