mirrors/cosmopolitan
1
0
Fork 0
mirror of https://github.com/jart/cosmopolitan.git synced 2025-07-16 15:40:31 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix sys_mmap_metal() for non-MAP_FIXED case (#651)

Browse source 
- correctly check that virtual region we want to use is
  unmapped, rather than accidentally clobbering existing pages
- avoid placing mmap'd memory at null virtual address
This commit is contained in:
tkchia 2022-10-07 07:27:52 +08:00 • committed by GitHub
parent 7bc24888fe
commit bc353f454b
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
libc/intrin/directmap-metal.c
View file

@ -39,8 +39,10 @@ noasan struct DirectMap sys_mmap_metal(void *paddr, size_t size, int prot,
size = ROUNDUP(size, 4096); size = ROUNDUP(size, 4096);
addr = (uint64_t)paddr; addr = (uint64_t)paddr;
if (!(flags & MAP_FIXED)) { if (!(flags & MAP_FIXED)) {
if (!addr)
addr = 4096;
for (i = 0; i < size; i += 4096) { for (i = 0; i < size; i += 4096) {
pte = __get_virtual(mm, pml4t, addr, false); pte = __get_virtual(mm, pml4t, addr + i, false);
if (pte && (*pte & PAGE_V)) { if (pte && (*pte & PAGE_V)) {
addr = MAX(addr, sys_mmap_metal_break) + i + 4096; addr = MAX(addr, sys_mmap_metal_break) + i + 4096;
i = 0; i = 0;