License cleanup: add SPDX GPL-2.0 license identifier to files with no license
Many source files in the tree are missing licensing information, which
makes it harder for compliance tools to determine the correct license.
By default all files without license information are under the default
license of the kernel, which is GPL version 2.
Update the files which contain no license information with the 'GPL-2.0'
SPDX license identifier. The SPDX identifier is a legally binding
shorthand, which can be used instead of the full boiler plate text.
This patch is based on work done by Thomas Gleixner and Kate Stewart and
Philippe Ombredanne.
How this work was done:
Patches were generated and checked against linux-4.14-rc6 for a subset of
the use cases:
- file had no licensing information it it.
- file was a */uapi/* one with no licensing information in it,
- file was a */uapi/* one with existing licensing information,
Further patches will be generated in subsequent months to fix up cases
where non-standard license headers were used, and references to license
had to be inferred by heuristics based on keywords.
The analysis to determine which SPDX License Identifier to be applied to
a file was done in a spreadsheet of side by side results from of the
output of two independent scanners (ScanCode & Windriver) producing SPDX
tag:value files created by Philippe Ombredanne. Philippe prepared the
base worksheet, and did an initial spot review of a few 1000 files.
The 4.13 kernel was the starting point of the analysis with 60,537 files
assessed. Kate Stewart did a file by file comparison of the scanner
results in the spreadsheet to determine which SPDX license identifier(s)
to be applied to the file. She confirmed any determination that was not
immediately clear with lawyers working with the Linux Foundation.
Criteria used to select files for SPDX license identifier tagging was:
- Files considered eligible had to be source code files.
- Make and config files were included as candidates if they contained >5
lines of source
- File already had some variant of a license header in it (even if <5
lines).
All documentation files were explicitly excluded.
The following heuristics were used to determine which SPDX license
identifiers to apply.
- when both scanners couldn't find any license traces, file was
considered to have no license information in it, and the top level
COPYING file license applied.
For non */uapi/* files that summary was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 11139
and resulted in the first patch in this series.
If that file was a */uapi/* path one, it was "GPL-2.0 WITH
Linux-syscall-note" otherwise it was "GPL-2.0". Results of that was:
SPDX license identifier # files
---------------------------------------------------|-------
GPL-2.0 WITH Linux-syscall-note 930
and resulted in the second patch in this series.
- if a file had some form of licensing information in it, and was one
of the */uapi/* ones, it was denoted with the Linux-syscall-note if
any GPL family license was found in the file or had no licensing in
it (per prior point). Results summary:
SPDX license identifier # files
---------------------------------------------------|------
GPL-2.0 WITH Linux-syscall-note 270
GPL-2.0+ WITH Linux-syscall-note 169
((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) 21
((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) 17
LGPL-2.1+ WITH Linux-syscall-note 15
GPL-1.0+ WITH Linux-syscall-note 14
((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) 5
LGPL-2.0+ WITH Linux-syscall-note 4
LGPL-2.1 WITH Linux-syscall-note 3
((GPL-2.0 WITH Linux-syscall-note) OR MIT) 3
((GPL-2.0 WITH Linux-syscall-note) AND MIT) 1
and that resulted in the third patch in this series.
- when the two scanners agreed on the detected license(s), that became
the concluded license(s).
- when there was disagreement between the two scanners (one detected a
license but the other didn't, or they both detected different
licenses) a manual inspection of the file occurred.
- In most cases a manual inspection of the information in the file
resulted in a clear resolution of the license that should apply (and
which scanner probably needed to revisit its heuristics).
- When it was not immediately clear, the license identifier was
confirmed with lawyers working with the Linux Foundation.
- If there was any question as to the appropriate license identifier,
the file was flagged for further research and to be revisited later
in time.
In total, over 70 hours of logged manual review was done on the
spreadsheet to determine the SPDX license identifiers to apply to the
source files by Kate, Philippe, Thomas and, in some cases, confirmation
by lawyers working with the Linux Foundation.
Kate also obtained a third independent scan of the 4.13 code base from
FOSSology, and compared selected files where the other two scanners
disagreed against that SPDX file, to see if there was new insights. The
Windriver scanner is based on an older version of FOSSology in part, so
they are related.
Thomas did random spot checks in about 500 files from the spreadsheets
for the uapi headers and agreed with SPDX license identifier in the
files he inspected. For the non-uapi files Thomas did random spot checks
in about 15000 files.
In initial set of patches against 4.14-rc6, 3 files were found to have
copy/paste license identifier errors, and have been fixed to reflect the
correct identifier.
Additionally Philippe spent 10 hours this week doing a detailed manual
inspection and review of the 12,461 patched files from the initial patch
version early this week with:
- a full scancode scan run, collecting the matched texts, detected
license ids and scores
- reviewing anything where there was a license detected (about 500+
files) to ensure that the applied SPDX license was correct
- reviewing anything where there was no detection but the patch license
was not GPL-2.0 WITH Linux-syscall-note to ensure that the applied
SPDX license was correct
This produced a worksheet with 20 files needing minor correction. This
worksheet was then exported into 3 different .csv files for the
different types of files to be modified.
These .csv files were then reviewed by Greg. Thomas wrote a script to
parse the csv files and add the proper SPDX tag to the file, in the
format that the file expected. This script was further refined by Greg
based on the output to detect more types of files automatically and to
distinguish between header and source .c files (which need different
comment types.) Finally Greg ran the script using the .csv files to
generate the patches.
Reviewed-by: Kate Stewart <kstewart@linuxfoundation.org>
Reviewed-by: Philippe Ombredanne <pombredanne@nexb.com>
Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2017-11-01 14:07:57 +00:00
|
|
|
/* SPDX-License-Identifier: GPL-2.0 */
|
2007-09-07 07:15:31 +00:00
|
|
|
/*
|
2008-06-10 16:20:58 +00:00
|
|
|
* zfcp device driver
|
2005-04-16 22:20:36 +00:00
|
|
|
*
|
2008-06-10 16:20:58 +00:00
|
|
|
* External function declarations.
|
2007-09-07 07:15:31 +00:00
|
|
|
*
|
2023-02-21 17:56:00 +00:00
|
|
|
* Copyright IBM Corp. 2002, 2023
|
2005-04-16 22:20:36 +00:00
|
|
|
*/
|
|
|
|
|
|
|
|
|
|
#ifndef ZFCP_EXT_H
|
|
|
|
|
#define ZFCP_EXT_H
|
|
|
|
|
|
2009-11-24 15:54:09 +00:00
|
|
|
#include <linux/types.h>
|
2021-04-14 17:08:02 +00:00
|
|
|
#include <linux/sysfs.h>
|
2009-11-24 15:54:09 +00:00
|
|
|
#include <scsi/fc/fc_els.h>
|
2005-04-16 22:20:36 +00:00
|
|
|
#include "zfcp_def.h"
|
2009-11-24 15:54:13 +00:00
|
|
|
#include "zfcp_fc.h"
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:41 +00:00
|
|
|
/* zfcp_aux.c */
|
2008-10-01 10:42:18 +00:00
|
|
|
extern struct zfcp_port *zfcp_get_port_by_wwpn(struct zfcp_adapter *, u64);
|
2009-11-24 15:54:00 +00:00
|
|
|
extern struct zfcp_adapter *zfcp_adapter_enqueue(struct ccw_device *);
|
2008-10-01 10:42:18 +00:00
|
|
|
extern struct zfcp_port *zfcp_port_enqueue(struct zfcp_adapter *, u64, u32,
|
2008-07-02 08:56:41 +00:00
|
|
|
u32);
|
2009-11-24 15:53:59 +00:00
|
|
|
extern void zfcp_adapter_release(struct kref *);
|
2009-11-24 15:54:00 +00:00
|
|
|
extern void zfcp_adapter_unregister(struct zfcp_adapter *);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:41 +00:00
|
|
|
/* zfcp_ccw.c */
|
2009-09-24 08:23:22 +00:00
|
|
|
extern struct ccw_driver zfcp_ccw_driver;
|
2009-11-24 15:54:00 +00:00
|
|
|
extern struct zfcp_adapter *zfcp_ccw_adapter_by_cdev(struct ccw_device *);
|
|
|
|
|
extern void zfcp_ccw_adapter_put(struct zfcp_adapter *);
|
2008-06-10 16:20:54 +00:00
|
|
|
|
2008-07-02 08:56:41 +00:00
|
|
|
/* zfcp_dbf.c */
|
2009-08-18 13:43:21 +00:00
|
|
|
extern int zfcp_dbf_adapter_register(struct zfcp_adapter *);
|
2010-12-02 14:16:16 +00:00
|
|
|
extern void zfcp_dbf_adapter_unregister(struct zfcp_adapter *);
|
2010-12-02 14:16:12 +00:00
|
|
|
extern void zfcp_dbf_rec_trig(char *, struct zfcp_adapter *,
|
|
|
|
|
struct zfcp_port *, struct scsi_device *, u8, u8);
|
2018-05-03 11:52:47 +00:00
|
|
|
extern void zfcp_dbf_rec_trig_lock(char *tag, struct zfcp_adapter *adapter,
|
|
|
|
|
struct zfcp_port *port,
|
|
|
|
|
struct scsi_device *sdev, u8 want, u8 need);
|
2010-12-02 14:16:12 +00:00
|
|
|
extern void zfcp_dbf_rec_run(char *, struct zfcp_erp_action *);
|
scsi: zfcp: fix rport unblock race with LUN recovery
It is unavoidable that zfcp_scsi_queuecommand() has to finish requests
with DID_IMM_RETRY (like fc_remote_port_chkready()) during the time
window when zfcp detected an unavailable rport but
fc_remote_port_delete(), which is asynchronous via
zfcp_scsi_schedule_rport_block(), has not yet blocked the rport.
However, for the case when the rport becomes available again, we should
prevent unblocking the rport too early. In contrast to other FCP LLDDs,
zfcp has to open each LUN with the FCP channel hardware before it can
send I/O to a LUN. So if a port already has LUNs attached and we
unblock the rport just after port recovery, recoveries of LUNs behind
this port can still be pending which in turn force
zfcp_scsi_queuecommand() to unnecessarily finish requests with
DID_IMM_RETRY.
This also opens a time window with unblocked rport (until the followup
LUN reopen recovery has finished). If a scsi_cmnd timeout occurs during
this time window fc_timed_out() cannot work as desired and such command
would indeed time out and trigger scsi_eh. This prevents a clean and
timely path failover. This should not happen if the path issue can be
recovered on FC transport layer such as path issues involving RSCNs.
Fix this by only calling zfcp_scsi_schedule_rport_register(), to
asynchronously trigger fc_remote_port_add(), after all LUN recoveries as
children of the rport have finished and no new recoveries of equal or
higher order were triggered meanwhile. Finished intentionally includes
any recovery result no matter if successful or failed (still unblock
rport so other successful LUNs work). For simplicity, we check after
each finished LUN recovery if there is another LUN recovery pending on
the same port and then do nothing. We handle the special case of a
successful recovery of a port without LUN children the same way without
changing this case's semantics.
For debugging we introduce 2 new trace records written if the rport
unblock attempt was aborted due to still unfinished or freshly triggered
recovery. The records are only written above the default trace level.
Benjamin noticed the important special case of new recovery that can be
triggered between having given up the erp_lock and before calling
zfcp_erp_action_cleanup() within zfcp_erp_strategy(). We must avoid the
following sequence:
ERP thread rport_work other context
------------------------- -------------- --------------------------------
port is unblocked, rport still blocked,
due to pending/running ERP action,
so ((port->status & ...UNBLOCK) != 0)
and (port->rport == NULL)
unlock ERP
zfcp_erp_action_cleanup()
case ZFCP_ERP_ACTION_REOPEN_LUN:
zfcp_erp_try_rport_unblock()
((status & ...UNBLOCK) != 0) [OLD!]
zfcp_erp_port_reopen()
lock ERP
zfcp_erp_port_block()
port->status clear ...UNBLOCK
unlock ERP
zfcp_scsi_schedule_rport_block()
port->rport_task = RPORT_DEL
queue_work(rport_work)
zfcp_scsi_rport_work()
(port->rport_task != RPORT_ADD)
port->rport_task = RPORT_NONE
zfcp_scsi_rport_block()
if (!port->rport) return
zfcp_scsi_schedule_rport_register()
port->rport_task = RPORT_ADD
queue_work(rport_work)
zfcp_scsi_rport_work()
(port->rport_task == RPORT_ADD)
port->rport_task = RPORT_NONE
zfcp_scsi_rport_register()
(port->rport == NULL)
rport = fc_remote_port_add()
port->rport = rport;
Now the rport was erroneously unblocked while the zfcp_port is blocked.
This is another situation we want to avoid due to scsi_eh
potential. This state would at least remain until the new recovery from
the other context finished successfully, or potentially forever if it
failed. In order to close this race, we take the erp_lock inside
zfcp_erp_try_rport_unblock() when checking the status of zfcp_port or
LUN. With that, the possible corresponding rport state sequences would
be: (unblock[ERP thread],block[other context]) if the ERP thread gets
erp_lock first and still sees ((port->status & ...UNBLOCK) != 0),
(block[other context],NOP[ERP thread]) if the ERP thread gets erp_lock
after the other context has already cleard ...UNBLOCK from port->status.
Since checking fields of struct erp_action is unsafe because they could
have been overwritten (re-used for new recovery) meanwhile, we only
check status of zfcp_port and LUN since these are only changed under
erp_lock elsewhere. Regarding the check of the proper status flags (port
or port_forced are similar to the shown adapter recovery):
[zfcp_erp_adapter_shutdown()]
zfcp_erp_adapter_reopen()
zfcp_erp_adapter_block()
* clear UNBLOCK ---------------------------------------+
zfcp_scsi_schedule_rports_block() |
write_lock_irqsave(&adapter->erp_lock, flags);-------+ |
zfcp_erp_action_enqueue() | |
zfcp_erp_setup_act() | |
* set ERP_INUSE -----------------------------------|--|--+
write_unlock_irqrestore(&adapter->erp_lock, flags);--+ | |
.context-switch. | |
zfcp_erp_thread() | |
zfcp_erp_strategy() | |
write_lock_irqsave(&adapter->erp_lock, flags);------+ | |
... | | |
zfcp_erp_strategy_check_target() | | |
zfcp_erp_strategy_check_adapter() | | |
zfcp_erp_adapter_unblock() | | |
* set UNBLOCK -----------------------------------|--+ |
zfcp_erp_action_dequeue() | |
* clear ERP_INUSE ---------------------------------|-----+
... |
write_unlock_irqrestore(&adapter->erp_lock, flags);-+
Hence, we should check for both UNBLOCK and ERP_INUSE because they are
interleaved. Also we need to explicitly check ERP_FAILED for the link
down case which currently does not clear the UNBLOCK flag in
zfcp_fsf_link_down_info_eval().
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Fixes: 8830271c4819 ("[SCSI] zfcp: Dont fail SCSI commands when transitioning to blocked fc_rport")
Fixes: a2fa0aede07c ("[SCSI] zfcp: Block FC transport rports early on errors")
Fixes: 5f852be9e11d ("[SCSI] zfcp: Fix deadlock between zfcp ERP and SCSI")
Fixes: 338151e06608 ("[SCSI] zfcp: make use of fc_remote_port_delete when target port is unavailable")
Fixes: 3859f6a248cb ("[PATCH] zfcp: add rports to enable scsi_add_device to work again")
Cc: <stable@vger.kernel.org> #2.6.32+
Reviewed-by: Benjamin Block <bblock@linux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2016-12-09 16:16:33 +00:00
|
|
|
extern void zfcp_dbf_rec_run_lvl(int level, char *tag,
|
|
|
|
|
struct zfcp_erp_action *erp);
|
2016-08-10 16:30:49 +00:00
|
|
|
extern void zfcp_dbf_rec_run_wka(char *, struct zfcp_fc_wka_port *, u64);
|
2010-12-02 14:16:14 +00:00
|
|
|
extern void zfcp_dbf_hba_fsf_uss(char *, struct zfcp_fsf_req *);
|
2016-08-10 16:30:47 +00:00
|
|
|
extern void zfcp_dbf_hba_fsf_res(char *, int, struct zfcp_fsf_req *);
|
2020-03-12 17:45:03 +00:00
|
|
|
extern void zfcp_dbf_hba_fsf_fces(char *tag, const struct zfcp_fsf_req *req,
|
|
|
|
|
u64 wwpn, u32 fc_security_old,
|
|
|
|
|
u32 fc_security_new);
|
2023-02-21 17:56:00 +00:00
|
|
|
extern void zfcp_dbf_hba_fsf_reqid(const char *const tag, const int level,
|
|
|
|
|
struct zfcp_adapter *const adapter,
|
|
|
|
|
const u64 req_id);
|
2010-12-02 14:16:14 +00:00
|
|
|
extern void zfcp_dbf_hba_bit_err(char *, struct zfcp_fsf_req *);
|
2011-08-15 12:40:32 +00:00
|
|
|
extern void zfcp_dbf_hba_def_err(struct zfcp_adapter *, u64, u16, void **);
|
2010-12-02 14:16:13 +00:00
|
|
|
extern void zfcp_dbf_san_req(char *, struct zfcp_fsf_req *, u32);
|
|
|
|
|
extern void zfcp_dbf_san_res(char *, struct zfcp_fsf_req *);
|
|
|
|
|
extern void zfcp_dbf_san_in_els(char *, struct zfcp_fsf_req *);
|
2018-05-17 17:14:50 +00:00
|
|
|
extern void zfcp_dbf_scsi_common(char *tag, int level, struct scsi_device *sdev,
|
|
|
|
|
struct scsi_cmnd *sc,
|
|
|
|
|
struct zfcp_fsf_req *fsf);
|
2018-05-17 17:14:43 +00:00
|
|
|
extern void zfcp_dbf_scsi_eh(char *tag, struct zfcp_adapter *adapter,
|
|
|
|
|
unsigned int scsi_id, int ret);
|
2005-04-16 22:20:36 +00:00
|
|
|
|
2008-07-02 08:56:41 +00:00
|
|
|
/* zfcp_erp.c */
|
2010-09-08 12:40:01 +00:00
|
|
|
extern void zfcp_erp_set_adapter_status(struct zfcp_adapter *, u32);
|
|
|
|
|
extern void zfcp_erp_clear_adapter_status(struct zfcp_adapter *, u32);
|
2018-11-08 14:44:49 +00:00
|
|
|
extern void zfcp_erp_port_forced_no_port_dbf(char *dbftag,
|
2018-05-17 17:14:46 +00:00
|
|
|
struct zfcp_adapter *adapter,
|
|
|
|
|
u64 port_name, u32 port_id);
|
2010-12-02 14:16:16 +00:00
|
|
|
extern void zfcp_erp_adapter_reopen(struct zfcp_adapter *, int, char *);
|
|
|
|
|
extern void zfcp_erp_adapter_shutdown(struct zfcp_adapter *, int, char *);
|
2010-09-08 12:40:01 +00:00
|
|
|
extern void zfcp_erp_set_port_status(struct zfcp_port *, u32);
|
|
|
|
|
extern void zfcp_erp_clear_port_status(struct zfcp_port *, u32);
|
2018-11-08 14:44:49 +00:00
|
|
|
extern void zfcp_erp_port_reopen(struct zfcp_port *port, int clear,
|
|
|
|
|
char *dbftag);
|
2010-12-02 14:16:16 +00:00
|
|
|
extern void zfcp_erp_port_shutdown(struct zfcp_port *, int, char *);
|
|
|
|
|
extern void zfcp_erp_port_forced_reopen(struct zfcp_port *, int, char *);
|
2019-03-26 13:36:59 +00:00
|
|
|
extern void zfcp_erp_port_forced_reopen_all(struct zfcp_adapter *adapter,
|
|
|
|
|
int clear, char *dbftag);
|
2010-09-08 12:40:01 +00:00
|
|
|
extern void zfcp_erp_set_lun_status(struct scsi_device *, u32);
|
|
|
|
|
extern void zfcp_erp_clear_lun_status(struct scsi_device *, u32);
|
2010-12-02 14:16:16 +00:00
|
|
|
extern void zfcp_erp_lun_reopen(struct scsi_device *, int, char *);
|
|
|
|
|
extern void zfcp_erp_lun_shutdown(struct scsi_device *, int, char *);
|
2010-09-08 12:39:55 +00:00
|
|
|
extern void zfcp_erp_lun_shutdown_wait(struct scsi_device *, char *);
|
2005-04-16 22:20:36 +00:00
|
|
|
extern int zfcp_erp_thread_setup(struct zfcp_adapter *);
|
2008-07-02 08:56:40 +00:00
|
|
|
extern void zfcp_erp_thread_kill(struct zfcp_adapter *);
|
|
|
|
|
extern void zfcp_erp_wait(struct zfcp_adapter *);
|
|
|
|
|
extern void zfcp_erp_notify(struct zfcp_erp_action *, unsigned long);
|
2017-10-17 16:40:51 +00:00
|
|
|
extern void zfcp_erp_timeout_handler(struct timer_list *t);
|
2018-11-08 14:44:49 +00:00
|
|
|
extern void zfcp_erp_adapter_reset_sync(struct zfcp_adapter *adapter,
|
|
|
|
|
char *dbftag);
|
2005-09-13 19:50:38 +00:00
|
|
|
|
2008-07-02 08:56:41 +00:00
|
|
|
/* zfcp_fc.c */
|
2011-02-22 18:54:41 +00:00
|
|
|
extern struct kmem_cache *zfcp_fc_req_cache;
|
2010-07-16 13:37:39 +00:00
|
|
|
extern void zfcp_fc_enqueue_event(struct zfcp_adapter *,
|
|
|
|
|
enum fc_host_event_code event_code, u32);
|
|
|
|
|
extern void zfcp_fc_post_event(struct work_struct *);
|
2009-11-24 15:54:06 +00:00
|
|
|
extern void zfcp_fc_scan_ports(struct work_struct *);
|
2008-07-02 08:56:41 +00:00
|
|
|
extern void zfcp_fc_incoming_els(struct zfcp_fsf_req *);
|
2009-08-18 13:43:20 +00:00
|
|
|
extern void zfcp_fc_port_did_lookup(struct work_struct *);
|
2009-10-14 09:00:43 +00:00
|
|
|
extern void zfcp_fc_trigger_did_lookup(struct zfcp_port *);
|
2009-11-24 15:54:09 +00:00
|
|
|
extern void zfcp_fc_plogi_evaluate(struct zfcp_port *, struct fc_els_flogi *);
|
2009-08-18 13:43:23 +00:00
|
|
|
extern void zfcp_fc_test_link(struct zfcp_port *);
|
2009-03-02 12:09:01 +00:00
|
|
|
extern void zfcp_fc_link_test_work(struct work_struct *);
|
2009-11-24 15:54:11 +00:00
|
|
|
extern void zfcp_fc_wka_ports_force_offline(struct zfcp_fc_wka_ports *);
|
2009-08-18 13:43:22 +00:00
|
|
|
extern int zfcp_fc_gs_setup(struct zfcp_adapter *);
|
|
|
|
|
extern void zfcp_fc_gs_destroy(struct zfcp_adapter *);
|
2016-11-17 09:31:19 +00:00
|
|
|
extern int zfcp_fc_exec_bsg_job(struct bsg_job *);
|
|
|
|
|
extern int zfcp_fc_timeout_bsg_job(struct bsg_job *);
|
2011-02-22 18:54:48 +00:00
|
|
|
extern void zfcp_fc_sym_name_update(struct work_struct *);
|
zfcp: auto port scan resiliency
This patch improves the Fibre Channel port scan behaviour of the zfcp lldd.
Without it the zfcp device driver may churn up the storage area network by
excessive scanning and scan bursts, particularly in big virtual server
environments, potentially resulting in interference of virtual servers and
reduced availability of storage connectivity.
The two main issues as to the zfcp device drivers automatic port scan in
virtual server environments are frequency and simultaneity.
On the one hand, there is no point in allowing lots of ports scans
in a row. It makes sense, though, to make sure that a scan is conducted
eventually if there has been any indication for potential SAN changes.
On the other hand, lots of virtual servers receiving the same indication
for a SAN change had better not attempt to conduct a scan instantly,
that is, at the same time.
Hence this patch has a two-fold approach for better port scanning:
the introduction of a rate limit to amend frequency issues, and the
introduction of a short random backoff to amend simultaneity issues.
Both approaches boil down to deferred port scans, with delays
comprising parts for both approaches.
The new port scan behaviour is summarised best by:
NEW: NEW:
no_auto_port_rescan random rate flush
backoff limit =wait
adapter resume/thaw yes yes no yes*
adapter online (user) no yes no yes*
port rescan (user) no no no yes
adapter recovery (user) yes yes yes no
adapter recovery (other) yes yes yes no
incoming ELS yes yes yes no
incoming ELS lost yes yes yes no
Implementation is straight-forward by converting an existing worker to
a delayed worker. But care is needed whenever that worker is going to be
flushed (in order to make sure work has been completed), since a flush
operation cancels the timer set up for deferred execution (see * above).
There is a small race window whenever a port scan work starts
running up to the point in time of storing the time stamp for that port
scan. The impact is negligible. Closing that gap isn't trivial, though, and
would the destroy the beauty of a simple work-to-delayed-work conversion.
Signed-off-by: Martin Peschke <mpeschke@linux.vnet.ibm.com>
Signed-off-by: Steffen Maier <maier@linux.vnet.ibm.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Christoph Hellwig <hch@lst.de>
2014-11-13 13:59:48 +00:00
|
|
|
extern unsigned int zfcp_fc_port_scan_backoff(void);
|
2012-09-04 13:23:35 +00:00
|
|
|
extern void zfcp_fc_conditional_port_scan(struct zfcp_adapter *);
|
|
|
|
|
extern void zfcp_fc_inverse_conditional_port_scan(struct zfcp_adapter *);
|
2008-07-02 08:56:41 +00:00
|
|
|
|
|
|
|
|
/* zfcp_fsf.c */
|
2011-02-22 18:54:44 +00:00
|
|
|
extern struct kmem_cache *zfcp_fsf_qtcb_cache;
|
2008-07-02 08:56:41 +00:00
|
|
|
extern int zfcp_fsf_open_port(struct zfcp_erp_action *);
|
2009-11-24 15:54:11 +00:00
|
|
|
extern int zfcp_fsf_open_wka_port(struct zfcp_fc_wka_port *);
|
|
|
|
|
extern int zfcp_fsf_close_wka_port(struct zfcp_fc_wka_port *);
|
2008-07-02 08:56:41 +00:00
|
|
|
extern int zfcp_fsf_close_port(struct zfcp_erp_action *);
|
|
|
|
|
extern int zfcp_fsf_close_physical_port(struct zfcp_erp_action *);
|
2010-09-08 12:39:55 +00:00
|
|
|
extern int zfcp_fsf_open_lun(struct zfcp_erp_action *);
|
|
|
|
|
extern int zfcp_fsf_close_lun(struct zfcp_erp_action *);
|
2008-07-02 08:56:41 +00:00
|
|
|
extern int zfcp_fsf_exchange_config_data(struct zfcp_erp_action *);
|
2009-08-18 13:43:19 +00:00
|
|
|
extern int zfcp_fsf_exchange_config_data_sync(struct zfcp_qdio *,
|
2008-07-02 08:56:41 +00:00
|
|
|
struct fsf_qtcb_bottom_config *);
|
|
|
|
|
extern int zfcp_fsf_exchange_port_data(struct zfcp_erp_action *);
|
2009-08-18 13:43:19 +00:00
|
|
|
extern int zfcp_fsf_exchange_port_data_sync(struct zfcp_qdio *,
|
2008-07-02 08:56:41 +00:00
|
|
|
struct fsf_qtcb_bottom_port *);
|
2020-05-08 17:23:29 +00:00
|
|
|
extern u32 zfcp_fsf_convert_portspeed(u32 fsf_speed);
|
2008-07-02 08:56:41 +00:00
|
|
|
extern void zfcp_fsf_req_dismiss_all(struct zfcp_adapter *);
|
2009-08-18 13:43:19 +00:00
|
|
|
extern int zfcp_fsf_status_read(struct zfcp_qdio *);
|
2008-07-02 08:56:41 +00:00
|
|
|
extern int zfcp_status_read_refill(struct zfcp_adapter *adapter);
|
2009-11-24 15:54:13 +00:00
|
|
|
extern int zfcp_fsf_send_ct(struct zfcp_fc_wka_port *, struct zfcp_fsf_ct_els *,
|
2010-01-14 16:19:02 +00:00
|
|
|
mempool_t *, unsigned int);
|
2009-11-24 15:54:13 +00:00
|
|
|
extern int zfcp_fsf_send_els(struct zfcp_adapter *, u32,
|
2010-01-14 16:19:02 +00:00
|
|
|
struct zfcp_fsf_ct_els *, unsigned int);
|
2010-09-08 12:39:55 +00:00
|
|
|
extern int zfcp_fsf_fcp_cmnd(struct scsi_cmnd *);
|
2008-07-02 08:56:41 +00:00
|
|
|
extern void zfcp_fsf_req_free(struct zfcp_fsf_req *);
|
scsi: zfcp: Move allocation of the shost object to after xconf- and xport-data
At the moment we allocate and register the Scsi_Host object corresponding
to a zfcp adapter (FCP device) very early in the life cycle of the adapter
- even before we fully discover and initialize the underlying
firmware/hardware. This had the advantage that we could already use the
Scsi_Host object, and fill in all its information during said discover and
initialize.
Due to commit 737eb78e82d5 ("block: Delay default elevator initialization")
(first released in v5.4), we noticed a regression that would prevent us
from using any storage volume if zfcp is configured with support for DIF or
DIX (zfcp.dif=1 || zfcp.dix=1). Doing so would result in an illegal memory
access as soon as the first request is sent with such an configuration. As
example for a crash resulting from this:
scsi host0: scsi_eh_0: sleeping
scsi host0: zfcp
qdio: 0.0.1900 ZFCP on SC 4bd using AI:1 QEBSM:0 PRI:1 TDD:1 SIGA: W AP
scsi 0:0:0:0: scsi scan: INQUIRY pass 1 length 36
Unable to handle kernel pointer dereference in virtual kernel address space
Failing address: 0000000000000000 TEID: 0000000000000483
Fault in home space mode while using kernel ASCE.
AS:0000000035c7c007 R3:00000001effcc007 S:00000001effd1000 P:000000000000003d
Oops: 0004 ilc:3 [#1] PREEMPT SMP DEBUG_PAGEALLOC
Modules linked in: ...
CPU: 1 PID: 783 Comm: kworker/u760:5 Kdump: loaded Not tainted 5.6.0-rc2-bb-next+ #1
Hardware name: ...
Workqueue: scsi_wq_0 fc_scsi_scan_rport [scsi_transport_fc]
Krnl PSW : 0704e00180000000 000003ff801fcdae (scsi_queue_rq+0x436/0x740 [scsi_mod])
R:0 T:1 IO:1 EX:1 Key:0 M:1 W:0 P:0 AS:3 CC:2 PM:0 RI:0 EA:3
Krnl GPRS: 0fffffffffffffff 0000000000000000 0000000187150120 0000000000000000
000003ff80223d20 000000000000018e 000000018adc6400 0000000187711000
000003e0062337e8 00000001ae719000 0000000187711000 0000000187150000
00000001ab808100 0000000187150120 000003ff801fcd74 000003e0062336a0
Krnl Code: 000003ff801fcd9e: e310a35c0012 lt %r1,860(%r10)
000003ff801fcda4: a7840010 brc 8,000003ff801fcdc4
#000003ff801fcda8: e310b2900004 lg %r1,656(%r11)
>000003ff801fcdae: d71710001000 xc 0(24,%r1),0(%r1)
000003ff801fcdb4: e310b2900004 lg %r1,656(%r11)
000003ff801fcdba: 41201018 la %r2,24(%r1)
000003ff801fcdbe: e32010000024 stg %r2,0(%r1)
000003ff801fcdc4: b904002b lgr %r2,%r11
Call Trace:
[<000003ff801fcdae>] scsi_queue_rq+0x436/0x740 [scsi_mod]
([<000003ff801fcd74>] scsi_queue_rq+0x3fc/0x740 [scsi_mod])
[<00000000349c9970>] blk_mq_dispatch_rq_list+0x390/0x680
[<00000000349d1596>] blk_mq_sched_dispatch_requests+0x196/0x1a8
[<00000000349c7a04>] __blk_mq_run_hw_queue+0x144/0x160
[<00000000349c7ab6>] __blk_mq_delay_run_hw_queue+0x96/0x228
[<00000000349c7d5a>] blk_mq_run_hw_queue+0xd2/0xe0
[<00000000349d194a>] blk_mq_sched_insert_request+0x192/0x1d8
[<00000000349c17b8>] blk_execute_rq_nowait+0x80/0x90
[<00000000349c1856>] blk_execute_rq+0x6e/0xb0
[<000003ff801f8ac2>] __scsi_execute+0xe2/0x1f0 [scsi_mod]
[<000003ff801fef98>] scsi_probe_and_add_lun+0x358/0x840 [scsi_mod]
[<000003ff8020001c>] __scsi_scan_target+0xc4/0x228 [scsi_mod]
[<000003ff80200254>] scsi_scan_target+0xd4/0x100 [scsi_mod]
[<000003ff802d8b96>] fc_scsi_scan_rport+0x96/0xc0 [scsi_transport_fc]
[<0000000034245ce8>] process_one_work+0x458/0x7d0
[<00000000342462a2>] worker_thread+0x242/0x448
[<0000000034250994>] kthread+0x15c/0x170
[<0000000034e1979c>] ret_from_fork+0x30/0x38
INFO: lockdep is turned off.
Last Breaking-Event-Address:
[<000003ff801fbc36>] scsi_add_cmd_to_list+0x9e/0xa8 [scsi_mod]
Kernel panic - not syncing: Fatal exception: panic_on_oops
While this issue is exposed by the commit named above, this is only by
accident. The real issue exists for longer already - basically since it's
possible to use blk-mq via scsi-mq, and blk-mq pre-allocates all requests
for a tag-set during initialization of the same. For a given Scsi_Host
object this is done when adding the object to the midlayer
(`scsi_add_host()` and such). In `scsi_mq_setup_tags()` the midlayer
calculates how much memory is required for a single scsi_cmnd, and its
additional data, which also might include space for additional protection
data - depending on whether the Scsi_Host has any form of protection
capabilities (`scsi_host_get_prot()`).
The problem is now thus, because zfcp does this step before we actually
know whether the firmware/hardware has these capabilities, we don't set any
protection capabilities in the Scsi_Host object. And so, no space is
allocated for additional protection data for requests in the Scsi_Host
tag-set.
Once we go through discover and initialize the FCP device firmware/hardware
fully (this is done via the firmware commands "Exchange Config Data" and
"Exchange Port Data") we find out whether it actually supports DIF and DIX,
and we set the corresponding capabilities in the Scsi_Host object (in
`zfcp_scsi_set_prot()`). Now the Scsi_Host potentially has protection
capabilities, but the already allocated requests in the tag-set don't have
any space allocated for that.
When we then trigger target scanning or add scsi_devices manually, the
midlayer will use requests from that tag-set, and before sending most
requests, it will also call `scsi_mq_prep_fn()`. To prepare the scsi_cmnd
this function will check again whether the used Scsi_Host has any
protection capabilities - and now it potentially has - and if so, it will
try to initialize the assumed to be preallocated structures and thus it
causes the crash, like shown above.
Before delaying the default elevator initialization with the commit named
above, we always would also allocate an elevator for any scsi_device before
ever sending any requests - in contrast to now, where we do it after
device-probing. That elevator in turn would have its own tag-set, and that
is initialized after we went through discovery and initialization of the
underlying firmware/hardware. So requests from that tag-set can be
allocated properly, and if used - unless the user changes/disabled the
default elevator - this would hide the underlying issue.
To fix this for any configuration - with or without an elevator - we move
the allocation and registration of the Scsi_Host object for a given FCP
device to after the first complete discovery and initialization of the
underlying firmware/hardware. By doing that we can make all basic
properties of the Scsi_Host known to the midlayer by the time we call
`scsi_add_host()`, including whether we have any protection capabilities.
To do that we have to delay all the accesses that we would have done in the
past during discovery and initialization, and do them instead once we are
finished with it. The previous patches ramp up to this by fencing and
factoring out all these accesses, and make it possible to re-do them later
on. In addition we make also use of the diagnostic buffers we recently
added with
commit 92953c6e0aa7 ("scsi: zfcp: signal incomplete or error for sync exchange config/port data")
commit 7e418833e689 ("scsi: zfcp: diagnostics buffer caching and use for exchange port data")
commit 088210233e6f ("scsi: zfcp: add diagnostics buffer for exchange config data")
(first released in v5.5), because these already cache all the information
we need for that "re-do operation" - the information cached are always
updated during xconf or xport data, so it won't be stale.
In addition to the move and re-do, this patch also updates the
function-documentation of `zfcp_scsi_adapter_register()` and changes how it
reports if a Scsi_Host object already exists. In that case future
recovery-operations can skip this step completely and behave much like they
would do in the past - zfcp does not release a once allocated Scsi_Host
object unless the corresponding FCP device is deconstructed completely.
Link: https://lore.kernel.org/r/030dd6da318bbb529f0b5268ec65cebcd20fc0a3.1588956679.git.bblock@linux.ibm.com
Reviewed-by: Steffen Maier <maier@linux.ibm.com>
Signed-off-by: Benjamin Block <bblock@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2020-05-08 17:23:35 +00:00
|
|
|
extern void zfcp_fsf_fc_host_link_down(struct zfcp_adapter *adapter);
|
2018-05-17 17:14:54 +00:00
|
|
|
extern struct zfcp_fsf_req *zfcp_fsf_fcp_task_mgmt(struct scsi_device *sdev,
|
|
|
|
|
u8 tm_flags);
|
2010-09-08 12:39:55 +00:00
|
|
|
extern struct zfcp_fsf_req *zfcp_fsf_abort_fcp_cmnd(struct scsi_cmnd *);
|
2009-08-18 13:43:19 +00:00
|
|
|
extern void zfcp_fsf_reqid_check(struct zfcp_qdio *, int);
|
2020-03-12 17:45:01 +00:00
|
|
|
enum zfcp_fsf_print_fmt {
|
|
|
|
|
ZFCP_FSF_PRINT_FMT_LIST,
|
|
|
|
|
ZFCP_FSF_PRINT_FMT_SINGLEITEM,
|
|
|
|
|
};
|
|
|
|
|
extern ssize_t zfcp_fsf_scnprint_fc_security(char *buf, size_t size,
|
|
|
|
|
u32 fc_security,
|
|
|
|
|
enum zfcp_fsf_print_fmt fmt);
|
2005-09-13 19:50:38 +00:00
|
|
|
|
2008-07-02 08:56:41 +00:00
|
|
|
/* zfcp_qdio.c */
|
2009-08-18 13:43:22 +00:00
|
|
|
extern int zfcp_qdio_setup(struct zfcp_adapter *);
|
|
|
|
|
extern void zfcp_qdio_destroy(struct zfcp_qdio *);
|
2010-04-30 16:09:35 +00:00
|
|
|
extern int zfcp_qdio_sbal_get(struct zfcp_qdio *);
|
2010-02-17 10:18:59 +00:00
|
|
|
extern int zfcp_qdio_send(struct zfcp_qdio *, struct zfcp_qdio_req *);
|
2010-04-30 16:09:34 +00:00
|
|
|
extern int zfcp_qdio_sbals_from_sg(struct zfcp_qdio *, struct zfcp_qdio_req *,
|
2010-07-16 13:37:37 +00:00
|
|
|
struct scatterlist *);
|
2020-05-08 17:23:28 +00:00
|
|
|
extern void zfcp_qdio_shost_update(struct zfcp_adapter *const adapter,
|
|
|
|
|
const struct zfcp_qdio *const qdio);
|
2009-08-18 13:43:19 +00:00
|
|
|
extern int zfcp_qdio_open(struct zfcp_qdio *);
|
|
|
|
|
extern void zfcp_qdio_close(struct zfcp_qdio *);
|
2010-07-16 13:37:43 +00:00
|
|
|
extern void zfcp_qdio_siosl(struct zfcp_adapter *);
|
2008-07-02 08:56:41 +00:00
|
|
|
|
|
|
|
|
/* zfcp_scsi.c */
|
scsi: zfcp: make DIX experimental, disabled, and independent of DIF
Introduce separate zfcp module parameters to individually select support
for: DIF which should work (zfcp.dif, which used to be DIF+DIX, disabled)
or DIX+DIF which can cause trouble (zfcp.dix, new, disabled).
If DIX is enabled, we warn on zfcp driver initialization. As before, this
also reduces the maximum I/O request size to half, to support the worst
case of merged single sector requests with one protection data scatter
gather element per sector. This can impact the maximum throughput.
In DIF-only mode (zfcp.dif=1 zfcp.dix=0), we can use the full maximum I/O
request size as there is no protection data for zfcp.
Signed-off-by: Steffen Maier <maier@linux.ibm.com>
Signed-off-by: Fedor Loshakov <loshakov@linux.ibm.com>
Reviewed-by: Jens Remus <jremus@linux.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2018-11-29 12:09:56 +00:00
|
|
|
extern bool zfcp_experimental_dix;
|
2011-02-22 18:54:46 +00:00
|
|
|
extern struct scsi_transport_template *zfcp_scsi_transport_template;
|
|
|
|
|
extern int zfcp_scsi_adapter_register(struct zfcp_adapter *);
|
|
|
|
|
extern void zfcp_scsi_adapter_unregister(struct zfcp_adapter *);
|
2008-07-02 08:56:41 +00:00
|
|
|
extern struct fc_function_template zfcp_transport_functions;
|
2009-03-02 12:09:08 +00:00
|
|
|
extern void zfcp_scsi_rport_work(struct work_struct *);
|
|
|
|
|
extern void zfcp_scsi_schedule_rport_register(struct zfcp_port *);
|
|
|
|
|
extern void zfcp_scsi_schedule_rport_block(struct zfcp_port *);
|
|
|
|
|
extern void zfcp_scsi_schedule_rports_block(struct zfcp_adapter *);
|
2010-07-16 13:37:42 +00:00
|
|
|
extern void zfcp_scsi_set_prot(struct zfcp_adapter *);
|
|
|
|
|
extern void zfcp_scsi_dif_sense_error(struct scsi_cmnd *, int);
|
2020-05-08 17:23:29 +00:00
|
|
|
extern void zfcp_scsi_shost_update_config_data(
|
|
|
|
|
struct zfcp_adapter *const adapter,
|
|
|
|
|
const struct fsf_qtcb_bottom_config *const bottom,
|
|
|
|
|
const bool bottom_incomplete);
|
2020-05-08 17:23:30 +00:00
|
|
|
extern void zfcp_scsi_shost_update_port_data(
|
|
|
|
|
struct zfcp_adapter *const adapter,
|
|
|
|
|
const struct fsf_qtcb_bottom_port *const bottom);
|
2005-09-13 19:50:38 +00:00
|
|
|
|
2008-07-02 08:56:41 +00:00
|
|
|
/* zfcp_sysfs.c */
|
2021-04-14 17:08:02 +00:00
|
|
|
extern const struct attribute_group *zfcp_sysfs_adapter_attr_groups[];
|
2013-04-26 14:13:49 +00:00
|
|
|
extern const struct attribute_group *zfcp_unit_attr_groups[];
|
2013-04-26 14:13:48 +00:00
|
|
|
extern const struct attribute_group *zfcp_port_attr_groups[];
|
2012-09-04 13:23:34 +00:00
|
|
|
extern struct mutex zfcp_sysfs_port_units_mutex;
|
2021-10-12 23:35:18 +00:00
|
|
|
extern const struct attribute_group *zfcp_sysfs_sdev_attr_groups[];
|
|
|
|
|
extern const struct attribute_group *zfcp_sysfs_shost_attr_groups[];
|
2019-05-23 13:23:46 +00:00
|
|
|
bool zfcp_sysfs_port_is_removing(const struct zfcp_port *const port);
|
2008-06-10 16:20:55 +00:00
|
|
|
|
2010-09-08 12:39:52 +00:00
|
|
|
/* zfcp_unit.c */
|
|
|
|
|
extern int zfcp_unit_add(struct zfcp_port *, u64);
|
|
|
|
|
extern int zfcp_unit_remove(struct zfcp_port *, u64);
|
|
|
|
|
extern struct zfcp_unit *zfcp_unit_find(struct zfcp_port *, u64);
|
|
|
|
|
extern struct scsi_device *zfcp_unit_sdev(struct zfcp_unit *unit);
|
|
|
|
|
extern void zfcp_unit_scsi_scan(struct zfcp_unit *);
|
|
|
|
|
extern void zfcp_unit_queue_scsi_scan(struct zfcp_port *);
|
|
|
|
|
extern unsigned int zfcp_unit_sdev_status(struct zfcp_unit *);
|
|
|
|
|
|
2005-04-16 22:20:36 +00:00
|
|
|
#endif /* ZFCP_EXT_H */
|