mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-10-06 08:46:46 +00:00
drm/i915/dp: Move max. vswing check to it's own function
Wrap the max. vswing check in a separate function. This makes the clock recovery phase of DP link training cleaner v3: Fixed the paranthesis warning (Mika Kahola) v2: Fixed the Compiler warning (Mika Kahola) Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com> Reviewed-by: Mika Kahola <mika.kahola@intel.com> Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
This commit is contained in:
parent
f169660ed4
commit
7bfaddf057
1 changed files with 13 additions and 4 deletions
|
@ -112,6 +112,18 @@ intel_dp_update_link_train(struct intel_dp *intel_dp)
|
|||
return ret == intel_dp->lane_count;
|
||||
}
|
||||
|
||||
static bool intel_dp_link_max_vswing_reached(struct intel_dp *intel_dp)
|
||||
{
|
||||
int lane;
|
||||
|
||||
for (lane = 0; lane < intel_dp->lane_count; lane++)
|
||||
if ((intel_dp->train_set[lane] &
|
||||
DP_TRAIN_MAX_SWING_REACHED) == 0)
|
||||
return false;
|
||||
|
||||
return true;
|
||||
}
|
||||
|
||||
/* Enable corresponding port and start training pattern 1 */
|
||||
static void
|
||||
intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp)
|
||||
|
@ -170,10 +182,7 @@ intel_dp_link_training_clock_recovery(struct intel_dp *intel_dp)
|
|||
}
|
||||
|
||||
/* Check to see if we've tried the max voltage */
|
||||
for (i = 0; i < intel_dp->lane_count; i++)
|
||||
if ((intel_dp->train_set[i] & DP_TRAIN_MAX_SWING_REACHED) == 0)
|
||||
break;
|
||||
if (i == intel_dp->lane_count) {
|
||||
if (intel_dp_link_max_vswing_reached(intel_dp)) {
|
||||
++loop_tries;
|
||||
if (loop_tries == 5) {
|
||||
DRM_ERROR("too many full retries, give up\n");
|
||||
|
|
Loading…
Reference in a new issue