mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-26 19:00:25 +00:00
[ALSA] emu10k1 - Check value ranges in ctl callbacks
Check value ranges in ctl callbacks properly. This fixes the unexpected crash due to wrong value assignment. Also, remove invalid comments in the last patch. Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Jaroslav Kysela <perex@perex.cz>
This commit is contained in:
parent
44d0a87995
commit
7e39e2273a
1 changed files with 0 additions and 9 deletions
|
@ -1089,7 +1089,6 @@ static int snd_emu10k1_send_volume_put(struct snd_kcontrol *kcontrol,
|
|||
{
|
||||
unsigned long flags;
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
struct snd_emu10k1_pcm_mixer *mix =
|
||||
&emu->pcm_mixer[snd_ctl_get_ioffidx(kcontrol, &ucontrol->id)];
|
||||
int change = 0, idx, val;
|
||||
|
@ -1142,7 +1141,6 @@ static int snd_emu10k1_attn_get(struct snd_kcontrol *kcontrol,
|
|||
struct snd_ctl_elem_value *ucontrol)
|
||||
{
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
struct snd_emu10k1_pcm_mixer *mix =
|
||||
&emu->pcm_mixer[snd_ctl_get_ioffidx(kcontrol, &ucontrol->id)];
|
||||
unsigned long flags;
|
||||
|
@ -1160,7 +1158,6 @@ static int snd_emu10k1_attn_put(struct snd_kcontrol *kcontrol,
|
|||
{
|
||||
unsigned long flags;
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
struct snd_emu10k1_pcm_mixer *mix =
|
||||
&emu->pcm_mixer[snd_ctl_get_ioffidx(kcontrol, &ucontrol->id)];
|
||||
int change = 0, idx, val;
|
||||
|
@ -1213,7 +1210,6 @@ static int snd_emu10k1_efx_send_routing_get(struct snd_kcontrol *kcontrol,
|
|||
{
|
||||
unsigned long flags;
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
struct snd_emu10k1_pcm_mixer *mix =
|
||||
&emu->efx_pcm_mixer[snd_ctl_get_ioffidx(kcontrol, &ucontrol->id)];
|
||||
int idx;
|
||||
|
@ -1233,7 +1229,6 @@ static int snd_emu10k1_efx_send_routing_put(struct snd_kcontrol *kcontrol,
|
|||
{
|
||||
unsigned long flags;
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
int ch = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
|
||||
struct snd_emu10k1_pcm_mixer *mix = &emu->efx_pcm_mixer[ch];
|
||||
int change = 0, idx, val;
|
||||
|
@ -1285,7 +1280,6 @@ static int snd_emu10k1_efx_send_volume_get(struct snd_kcontrol *kcontrol,
|
|||
{
|
||||
unsigned long flags;
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
struct snd_emu10k1_pcm_mixer *mix =
|
||||
&emu->efx_pcm_mixer[snd_ctl_get_ioffidx(kcontrol, &ucontrol->id)];
|
||||
int idx;
|
||||
|
@ -1303,7 +1297,6 @@ static int snd_emu10k1_efx_send_volume_put(struct snd_kcontrol *kcontrol,
|
|||
{
|
||||
unsigned long flags;
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
int ch = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
|
||||
struct snd_emu10k1_pcm_mixer *mix = &emu->efx_pcm_mixer[ch];
|
||||
int change = 0, idx, val;
|
||||
|
@ -1352,7 +1345,6 @@ static int snd_emu10k1_efx_attn_get(struct snd_kcontrol *kcontrol,
|
|||
struct snd_ctl_elem_value *ucontrol)
|
||||
{
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
struct snd_emu10k1_pcm_mixer *mix =
|
||||
&emu->efx_pcm_mixer[snd_ctl_get_ioffidx(kcontrol, &ucontrol->id)];
|
||||
unsigned long flags;
|
||||
|
@ -1368,7 +1360,6 @@ static int snd_emu10k1_efx_attn_put(struct snd_kcontrol *kcontrol,
|
|||
{
|
||||
unsigned long flags;
|
||||
struct snd_emu10k1 *emu = snd_kcontrol_chip(kcontrol);
|
||||
/* FIXME: Check limits */
|
||||
int ch = snd_ctl_get_ioffidx(kcontrol, &ucontrol->id);
|
||||
struct snd_emu10k1_pcm_mixer *mix = &emu->efx_pcm_mixer[ch];
|
||||
int change = 0, val;
|
||||
|
|
Loading…
Reference in a new issue