mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-08-28 11:49:32 +00:00
usb: renesas_usbhs: clear the BRDYSTS in usbhsg_ep_enable()
This patch fixes an issue that unexpected BRDY interruption happens when the usb_ep_{enable,disable}() are called with different direction. In this case, the driver will cause the following message: renesas_usbhs e6590000.usb: irq_ready run_error 1 : -16 This issue causes the followings: 1) A pipe is enabled as transmission 2) The pipe sent a data 3) The pipe is disabled and re-enabled as reception. 4) The pipe got a queue Since the driver doesn't clear the BRDYSTS flags after 2) above, the issue happens. If we add such clearing the flags into the driver, the code will become complicate. So, this patch clears the BRDYSTS flag of reception in usbhsg_ep_enable() to avoid complicate. Cc: <stable@vger.kernel.org> # v4.1+ (usbhs_xxxsts_clear() is needed) Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
This commit is contained in:
parent
772ce81264
commit
9ab967e6db
1 changed files with 5 additions and 2 deletions
|
@ -617,10 +617,13 @@ static int usbhsg_ep_enable(struct usb_ep *ep,
|
|||
* use dmaengine if possible.
|
||||
* It will use pio handler if impossible.
|
||||
*/
|
||||
if (usb_endpoint_dir_in(desc))
|
||||
if (usb_endpoint_dir_in(desc)) {
|
||||
pipe->handler = &usbhs_fifo_dma_push_handler;
|
||||
else
|
||||
} else {
|
||||
pipe->handler = &usbhs_fifo_dma_pop_handler;
|
||||
usbhs_xxxsts_clear(priv, BRDYSTS,
|
||||
usbhs_pipe_number(pipe));
|
||||
}
|
||||
|
||||
ret = 0;
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue