Eric Dumazet 01fb1626b6 netfilter: nft_limit: avoid possible divide error in nft_limit_init ... commit b895bdf5d6 upstream. div_u64() divides u64 by u32. nft_limit_init() wants to divide u64 by u64, use the appropriate math function (div64_u64) divide error: 0000 [#1] PREEMPT SMP KASAN CPU: 1 PID: 8390 Comm: syz-executor188 Not tainted 5.12.0-rc4-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011 RIP: 0010:div_u64_rem include/linux/math64.h:28 [inline] RIP: 0010:div_u64 include/linux/math64.h:127 [inline] RIP: 0010:nft_limit_init+0x2a2/0x5e0 net/netfilter/nft_limit.c:85 Code: ef 4c 01 eb 41 0f 92 c7 48 89 de e8 38 a5 22 fa 4d 85 ff 0f 85 97 02 00 00 e8 ea 9e 22 fa 4c 0f af f3 45 89 ed 31 d2 4c 89 f0 <49> f7 f5 49 89 c6 e8 d3 9e 22 fa 48 8d 7d 48 48 b8 00 00 00 00 00 RSP: 0018:ffffc90009447198 EFLAGS: 00010246 RAX: 0000000000000000 RBX: 0000200000000000 RCX: 0000000000000000 RDX: 0000000000000000 RSI: ffffffff875152e6 RDI: 0000000000000003 RBP: ffff888020f80908 R08: 0000200000000000 R09: 0000000000000000 R10: ffffffff875152d8 R11: 0000000000000000 R12: ffffc90009447270 R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000 FS: 000000000097a300(0000) GS:ffff8880b9d00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00000000200001c4 CR3: 0000000026a52000 CR4: 00000000001506e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: nf_tables_newexpr net/netfilter/nf_tables_api.c:2675 [inline] nft_expr_init+0x145/0x2d0 net/netfilter/nf_tables_api.c:2713 nft_set_elem_expr_alloc+0x27/0x280 net/netfilter/nf_tables_api.c:5160 nf_tables_newset+0x1997/0x3150 net/netfilter/nf_tables_api.c:4321 nfnetlink_rcv_batch+0x85a/0x21b0 net/netfilter/nfnetlink.c:456 nfnetlink_rcv_skb_batch net/netfilter/nfnetlink.c:580 [inline] nfnetlink_rcv+0x3af/0x420 net/netfilter/nfnetlink.c:598 netlink_unicast_kernel net/netlink/af_netlink.c:1312 [inline] netlink_unicast+0x533/0x7d0 net/netlink/af_netlink.c:1338 netlink_sendmsg+0x856/0xd90 net/netlink/af_netlink.c:1927 sock_sendmsg_nosec net/socket.c:654 [inline] sock_sendmsg+0xcf/0x120 net/socket.c:674 ____sys_sendmsg+0x6e8/0x810 net/socket.c:2350 ___sys_sendmsg+0xf3/0x170 net/socket.c:2404 __sys_sendmsg+0xe5/0x1b0 net/socket.c:2433 do_syscall_64+0x2d/0x70 arch/x86/entry/common.c:46 entry_SYSCALL_64_after_hwframe+0x44/0xae Fixes: c26844eda9 ("netfilter: nf_tables: Fix nft limit burst handling") Fixes: 3e0f64b7dd ("netfilter: nft_limit: fix packet ratelimiting") Signed-off-by: Eric Dumazet <edumazet@google.com> Diagnosed-by: Luigi Rizzo <lrizzo@google.com> Reported-by: syzbot <syzkaller@googlegroups.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2021-04-21 12:56:17 +02:00
..
6lowpan
9p	net: 9p: initialize sun_server.sun_path to have addr's value only when addr is valid	2020-11-05 11:43:20 +01:00
802
8021q	net: vlan: avoid leaks on register_vlan_dev() failures	2021-01-17 14:05:31 +01:00
appletalk	appletalk: Fix skb allocation size in loopback case	2021-04-07 14:47:41 +02:00
atm	atm: fix a memory leak of vcc->user_back	2020-10-01 13:17:58 +02:00
ax25	AX.25: Prevent integer overflows in connect and sendmsg	2020-07-31 18:39:31 +02:00
batman-adv	batman-adv: initialize "struct batadv_tvlv_tt_vlan_data"->reserved field	2021-04-14 08:24:11 +02:00
bluetooth	Bluetooth: Fix null pointer dereference in amp_read_loc_assoc_final_data	2021-03-07 12:20:45 +01:00
bpf
bpfilter	net/bpfilter: remove superfluous testing message	2020-04-21 09:04:53 +02:00
bridge	netfilter: bridge: add pre_exit hooks for ebtable unregistration	2021-04-21 12:56:16 +02:00
caif
can	can: bcm/raw: fix msg_namelen values depending on CAN_REQUIRED_SIZE	2021-04-14 08:24:14 +02:00
ceph	libceph: clear con->out_msg on Policy::stateful_server faults	2020-11-05 11:43:34 +01:00
core	neighbour: Disregard DEAD dst in neigh_update	2021-04-21 12:56:13 +02:00
dcb	net: dcb: Accept RTM_GETDCB messages carrying set-like DCB commands	2021-01-23 15:57:59 +01:00
dccp	ipv6: weaken the v4mapped source check	2021-04-07 14:47:38 +02:00
decnet	net: add bool confirm_neigh parameter for dst_ops.update_pmtu	2020-01-04 19:18:58 +01:00
dns_resolver	KEYS: Don't write out to userspace while holding key semaphore	2020-04-23 10:36:45 +02:00
dsa	net: dsa: tag_mtk: fix 802.1ad VLAN egress	2021-03-20 10:39:47 +01:00
ethernet	net: add annotations on hh->hh_len lockless accesses	2020-01-09 10:20:06 +01:00
hsr	net: hsr: Reset MAC header for Tx path	2021-04-14 08:24:12 +02:00
ieee802154	net: ieee802154: forbid monitor for add llsec seclevel	2021-04-21 12:56:15 +02:00
ife
ipv4	netfilter: arp_tables: add pre_exit hook for table unregister	2021-04-21 12:56:16 +02:00
ipv6	netfilter: x_tables: fix compat match/target pad out-of-bound write	2021-04-16 11:46:38 +02:00
iucv	net/af_iucv: remove WARN_ONCE on malformed RX packets	2021-03-07 12:20:42 +01:00
kcm
key	af_key: relax availability checks for skb size calculation	2021-02-13 13:52:54 +01:00
l2tp	l2tp: remove skb_dst_set() from l2tp_xmit_skb()	2020-07-22 09:32:47 +02:00
l3mdev
lapb	net: lapb: Copy the skb before sending a packet	2021-02-10 09:25:28 +01:00
llc	net: silence data-races on sk_backlog.tail	2020-10-01 13:17:15 +02:00
mac80211	mac80211: clear sta->fast_rx when STA removed from 4-addr VLAN	2021-04-21 12:56:15 +02:00
mac802154	net: mac802154: Fix general protection fault	2021-04-14 08:24:18 +02:00
mpls	net: avoid infinite loop in mpls_gso_segment when mpls_hlen == 0	2021-03-17 17:03:31 +01:00
ncsi	net/ncsi: Avoid channel_monitor hrtimer deadlock	2021-04-14 08:24:15 +02:00
netfilter	netfilter: nft_limit: avoid possible divide error in nft_limit_init	2021-04-21 12:56:17 +02:00
netlabel	cipso,calipso: resolve a number of problems with the DOI refcounts	2021-03-17 17:03:35 +01:00
netlink	genetlink: remove genl_bind	2020-07-22 09:32:46 +02:00
netrom	net: netrom: Fix potential nr_neigh refcnt leak in nr_add_node	2020-04-29 16:33:08 +02:00
nfc	nfc: Avoid endless loops caused by repeated llcp_sock_connect()	2021-04-14 08:24:10 +02:00
nsh
openvswitch	openvswitch: fix send of uninitialized stack memory in ct limit reply	2021-04-14 08:24:17 +02:00
packet	net/packet: fix overflow in tpacket_rcv	2020-09-09 19:12:29 +02:00
phonet
psample
qrtr	net: qrtr: fix a kernel-infoleak in qrtr_recvmsg()	2021-03-30 14:35:29 +02:00
rds	net/rds: Fix a use after free in rds_message_map_pages	2021-04-14 08:24:15 +02:00
rfkill	rfkill: Fix use-after-free in rfkill_resume()	2020-11-24 13:29:05 +01:00
rose	rose: Fix Null pointer dereference in rose_send_frame()	2020-12-08 10:40:23 +01:00
rxrpc	rxrpc: Fix clearance of Tx/Rx ring when releasing a call	2021-02-17 10:35:18 +01:00
sched	net: sched: bump refcount for new action in ACT replace mode	2021-04-14 08:24:18 +02:00
sctp	net/sctp: fix race condition in sctp_destroy_sock	2021-04-21 12:56:12 +02:00
smc	net/smc: fix direct access to ib_gid_addr->ndev in smc_ib_determine_gid()	2020-11-24 13:28:58 +01:00
strparser
sunrpc	rpc: fix NULL dereference on kmalloc failure	2021-04-07 14:47:38 +02:00
switchdev	net: switchdev: don't set port_obj_info->handled true when -EOPNOTSUPP	2021-02-07 15:35:46 +01:00
tipc	net:tipc: Fix a double free in tipc_sk_mcast_rcv	2021-04-14 08:24:15 +02:00
tls	net/tls: Protect from calling tls_dev_del for TLS RX twice	2020-12-08 10:40:23 +01:00
unix	skbuff: fix a data race in skb_queue_len()	2020-10-01 13:17:31 +02:00
vmw_vsock	selinux: vsock: Set SID for socket returned by accept()	2021-04-07 14:47:37 +02:00
wimax
wireless	cfg80211: remove WARN_ON() in cfg80211_sme_connect	2021-04-14 08:24:18 +02:00
x25	net/x25: prevent a couple of overflows	2020-12-08 10:40:26 +01:00
xdp	xsk: Replace datagram_poll by sock_poll_wait	2020-12-30 11:50:53 +01:00
xfrm	net: xfrm: Localize sequence counter per network namespace	2021-04-14 08:24:13 +02:00
compat.c	net/compat: Add missing sock updates for SCM_RIGHTS	2020-08-21 13:05:25 +02:00
Kconfig	net: Fix CONFIG_NET_CLS_ACT=n and CONFIG_NFT_FWD_NETDEV={y, m} build	2020-04-01 11:02:18 +02:00
Makefile
socket.c	net: Set fput_needed iff FDPUT_FPUT is set	2020-08-19 08:16:22 +02:00
sysctl_net.c