Thomas Gleixner fc2b20c092 debugobject: Prevent init race with static objects ... [ Upstream commit 63a759694e ] Statically initialized objects are usually not initialized via the init() function of the subsystem. They are special cased and the subsystem provides a function to validate whether an object which is not yet tracked by debugobjects is statically initialized. This means the object is started to be tracked on first use, e.g. activation. This works perfectly fine, unless there are two concurrent operations on that object. Schspa decoded the problem: T0 T1 debug_object_assert_init(addr) lock_hash_bucket() obj = lookup_object(addr); if (!obj) { unlock_hash_bucket(); - > preemption lock_subsytem_object(addr); activate_object(addr) lock_hash_bucket(); obj = lookup_object(addr); if (!obj) { unlock_hash_bucket(); if (is_static_object(addr)) init_and_track(addr); lock_hash_bucket(); obj = lookup_object(addr); obj->state = ACTIVATED; unlock_hash_bucket(); subsys function modifies content of addr, so static object detection does not longer work. unlock_subsytem_object(addr); if (is_static_object(addr)) <- Fails debugobject emits a warning and invokes the fixup function which reinitializes the already active object in the worst case. This race exists forever, but was never observed until mod_timer() got a debug_object_assert_init() added which is outside of the timer base lock held section right at the beginning of the function to cover the lockless early exit points too. Rework the code so that the lookup, the static object check and the tracking object association happens atomically under the hash bucket lock. This prevents the issue completely as all callers are serialized on the hash bucket lock and therefore cannot observe inconsistent state. Fixes: 3ac7fe5a4a ("infrastructure to debug (dynamic) objects") Reported-by: syzbot+5093ba19745994288b53@syzkaller.appspotmail.com Debugged-by: Schspa Shi <schspa@gmail.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Stephen Boyd <swboyd@chromium.org> Link: https://syzkaller.appspot.com/bug?id=22c8a5938eab640d1c6bcc0e3dc7be519d878462 Link: https://lore.kernel.org/lkml/20230303161906.831686-1-schspa@gmail.com Link: https://lore.kernel.org/r/87zg7dzgao.ffs@tglx Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-05-11 23:03:16 +09:00
..
842
crypto	crypto: lib - remove unneeded selection of XOR_BLOCKS	2022-08-26 18:40:14 +08:00
dim	dim: initialize all struct fields	2022-05-09 17:20:37 -07:00
fonts	lib/fonts: fix undefined behavior in bit shift for get_default_font	2022-12-31 13:31:56 +01:00
kunit	kunit: fix bug in the order of lines in debugfs logs	2023-05-11 23:03:05 +09:00
livepatch	selftests/livepatch: better synchronize test_klp_callbacks_busy	2022-06-15 10:29:10 +02:00
lz4	lib: make LZ4_decompress_safe_forceExtDict() static	2022-07-17 17:31:39 -07:00
lzo	lib/lzo/lzo1x_compress.c: replace ternary operator with min() and min_t()	2022-07-29 18:12:34 -07:00
math
mpi	lib/mpi: Fix buffer overrun when SG is too long	2023-03-10 09:32:52 +01:00
pldmfw
raid6	lib/raid6: Include <asm/ppc-opcode.h> for VPERMXOR	2022-03-08 15:20:21 -08:00
reed_solomon	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
test_fortify
vdso	lib/vdso: use "grep -E" instead of "egrep"	2022-11-23 19:50:15 +01:00
xz
zlib_deflate
zlib_dfltcc
zlib_inflate
zstd	zstd: Fix definition of assert()	2023-04-06 12:10:38 +02:00
.gitignore	bootconfig: Support embedding a bootconfig file in kernel	2022-04-26 17:58:51 -04:00
argv_split.c
ashldi3.c
ashrdi3.c
asn1_decoder.c
asn1_encoder.c
assoc_array.c	assoc_array: Fix BUG_ON during garbage collect	2022-06-01 18:29:06 -07:00
atomic64.c
atomic64_test.c
audit.c
base64.c	lib/base64: RFC4648-compliant base64 encoding	2022-08-02 17:14:47 -06:00
bcd.c
bch.c
bitfield_kunit.c
bitmap.c	lib/bitmap: remove bitmap_ord_to_pos	2022-09-26 12:19:12 -07:00
bitrev.c
bootconfig-data.S	bootconfig: Support embedding a bootconfig file in kernel	2022-04-26 17:58:51 -04:00
bootconfig.c	bootconfig: Support embedding a bootconfig file in kernel	2022-04-26 17:58:51 -04:00
bsearch.c
btree.c	lib/btree: simplify btree_{lookup|update}	2022-06-16 19:58:21 -07:00
bucket_locks.c
bug.c	cpuidle: lib/bug: Disable rcu_is_watching() during WARN/BUG	2023-03-10 09:33:47 +01:00
build_OID_registry
buildid.c
bust_spinlocks.c	kernel/panic: Drop unblank_screen call	2022-09-01 16:55:35 +02:00
check_signature.c
checksum.c
clz_ctz.c
clz_tab.c
cmdline.c	lib/cmdline: avoid page fault in next_arg	2022-09-11 21:55:06 -07:00
cmdline_kunit.c	treewide: use get_random_{u8,u16}() when possible, part 1	2022-10-11 17:42:58 -06:00
cmpdi2.c
compat_audit.c
cpu_rmap.c
cpumask.c	lib/find_bit: add find_next{,_and}_bit_wrap	2022-10-01 10:22:57 -07:00
cpumask_kunit.c	lib/test_cpumask: Add for_each_cpu_and(not) tests	2022-10-06 05:57:36 -07:00
crc-ccitt.c
crc-itu-t.c	crc-itu-t: fix typo in CRC ITU-T polynomial comment	2022-06-07 10:27:38 +02:00
crc-t10dif.c
crc4.c
crc7.c
crc8.c
crc16.c
crc32.c
crc32defs.h
crc32test.c
crc64-rocksoft.c	crypto: add rocksoft 64b crc guard tag framework	2022-03-07 12:48:35 -07:00
crc64.c	lib: add rocksoft model crc64	2022-03-07 12:48:35 -07:00
ctype.c
debug_info.c
debug_locks.c
debugobjects.c	debugobject: Prevent init race with static objects	2023-05-11 23:03:16 +09:00
dec_and_lock.c
decompress.c
decompress_bunzip2.c
decompress_inflate.c
decompress_unlz4.c
decompress_unlzma.c
decompress_unlzo.c
decompress_unxz.c
decompress_unzstd.c
devmem_is_allowed.c
devres.c	devres: remove devm_ioremap_np	2022-09-01 18:04:43 +02:00
digsig.c
dump_stack.c	printk: rename cpulock functions	2022-04-22 21:30:57 +02:00
dynamic_debug.c	dyndbg: add drm.debug style (drm/parameters/debug) bitmap support	2022-09-07 17:04:49 +02:00
dynamic_queue_limits.c
earlycpio.c	lib: move from strlcpy with unused retval to strscpy	2022-09-11 21:55:10 -07:00
errname.c	printf: fix errname.c list	2023-03-10 09:33:27 +01:00
error-inject.c	lib/error-inject: traverse list with mutex	2022-07-17 17:31:38 -07:00
errseq.c
extable.c
fault-inject-usercopy.c
fault-inject.c	mm: fix unexpected changes to {failslab|fail_page_alloc}.attr	2022-11-22 18:50:44 -08:00
fdt.c
fdt_addresses.c
fdt_empty_tree.c
fdt_ro.c
fdt_rw.c
fdt_strerror.c
fdt_sw.c
fdt_wip.c
find_bit.c	lib/find_bit: Introduce find_next_andnot_bit()	2022-10-06 05:57:36 -07:00
find_bit_benchmark.c	treewide: use prandom_u32_max() when possible, part 1	2022-10-11 17:42:55 -06:00
flex_proportions.c	flex_proportions: Disable preemption entering the write section.	2022-09-19 14:35:08 +02:00
fortify_kunit.c	fortify: Adjust KUnit test for modular build	2022-09-14 07:04:15 -07:00
gen_crc32table.c
gen_crc64table.c	lib: add rocksoft model crc64	2022-03-07 12:48:35 -07:00
genalloc.c
generic-radix-tree.c
glob.c	lib: remove back_str initialization	2022-04-29 14:38:01 -07:00
globtest.c
hexdump.c	hex2bin: fix access beyond string end	2022-04-27 10:57:33 -07:00
hweight.c
idr.c	ida: don't use BUG_ON() for debugging	2022-07-10 13:55:49 -07:00
inflate.c
interval_tree.c
interval_tree_test.c
iomap.c	kmsan: add iomap support	2022-10-03 14:03:21 -07:00
iomap_copy.c
iommu-helper.c
iov_iter.c	instrumented.h: allow instrumenting both sides of copy_from_user()	2022-10-03 14:03:18 -07:00
irq_poll.c	lib/irq_poll: Prevent softirq pending leak in irq_poll_cpu_dead()	2022-04-13 21:32:21 +02:00
irq_regs.c
is_signed_type_kunit.c	lib: Improve the is_signed_type() kunit test	2022-09-07 16:37:27 -07:00
is_single_threaded.c
kasprintf.c
Kconfig	This update includes the following changes:	2022-10-10 13:04:25 -07:00
Kconfig.debug	test_kprobes: Fix implicit declaration error of test_kprobes	2023-01-07 11:11:55 +01:00
Kconfig.kasan	kasan: drop CONFIG_KASAN_TAGS_IDENTIFY	2022-10-03 14:02:57 -07:00
Kconfig.kcsan	objtool: Make noinstr hacks optional	2022-04-22 12:32:04 +02:00
Kconfig.kfence	kfence: allow use of a deferrable timer	2022-03-22 15:57:11 -07:00
Kconfig.kgdb	parisc: Convert PDC console to an early console	2022-10-11 12:01:24 +02:00
Kconfig.kmsan	kmsan: make sure PREEMPT_RT is off	2022-11-08 15:57:24 -08:00
Kconfig.ubsan	ubsan: disable UBSAN_DIV_ZERO for clang	2022-07-14 15:45:26 -07:00
kfifo.c
klist.c
kobject.c	kobject: Fix slab-out-of-bounds in fill_kobj_path()	2023-03-10 09:33:30 +01:00
kobject_uevent.c
kstrtox.c	lib/kstrtox.c: add "false"/"true" support to kstrtobool()	2022-05-13 07:20:13 -07:00
kstrtox.h
libcrc32c.c
linear_ranges.c
list-test.c	list: test: Test the hlist structure	2022-04-05 13:32:27 -06:00
list_debug.c	lib/list_debug.c: Detect uninitialized lists	2022-06-16 19:58:20 -07:00
list_sort.c
llist.c	llist: use try_cmpxchg in llist_add_batch and llist_del_first	2022-09-11 21:55:06 -07:00
locking-selftest-hardirq.h
locking-selftest-mutex.h
locking-selftest-rlock-hardirq.h
locking-selftest-rlock-softirq.h
locking-selftest-rlock.h
locking-selftest-rsem.h
locking-selftest-rtmutex.h
locking-selftest-softirq.h
locking-selftest-spin-hardirq.h
locking-selftest-spin-softirq.h
locking-selftest-spin.h
locking-selftest-wlock-hardirq.h
locking-selftest-wlock-softirq.h
locking-selftest-wlock.h
locking-selftest-wsem.h
locking-selftest.c
lockref.c	lockref: stop doing cpu_relax in the cmpxchg loop	2023-02-01 08:34:34 +01:00
logic_iomem.c	lib/logic_iomem: correct fallback config references	2022-03-11 10:42:56 +01:00
logic_pio.c
lru_cache.c	lib/lru_cache: fix error free handing in lc_create	2022-07-17 17:31:37 -07:00
lshrdi3.c
Makefile	maple_tree: reorganize testing to restore module testing	2022-11-08 15:57:22 -08:00
maple_tree.c	maple_tree: fix a potential memory leak, OOB access, or other unpredictable bug	2023-04-26 14:28:39 +02:00
memcat_p.c
memcpy_kunit.c	kunit/memcpy: Avoid pathological compile-time string size	2022-09-07 16:37:48 -07:00
memory-notifier-error-inject.c
memregion.c
memweight.c
muldi3.c
net_utils.c
netdev-notifier-error-inject.c
nlattr.c	netlink: prevent potential spectre v1 gadgets	2023-02-01 08:34:43 +01:00
nmi_backtrace.c	printk: rename cpulock functions	2022-04-22 21:30:57 +02:00
notifier-error-inject.c	lib/notifier-error-inject: fix error when writing -errno to debugfs file	2022-12-31 13:31:58 +01:00
notifier-error-inject.h
objagg.c
of-reconfig-notifier-error-inject.c
oid_registry.c
once.c	once: rename _SLOW to _SLEEPABLE	2022-10-03 17:34:32 -07:00
overflow_kunit.c	overflow: Refactor test skips for Clang-specific issues	2022-10-25 14:57:42 -07:00
packing.c
parman.c
parser.c
pci_iomap.c
percpu-refcount.c	percpu_ref_init(): clean ->percpu_count_ref on failure	2022-05-18 02:20:17 -04:00
percpu_counter.c
percpu_test.c
plist.c
pm-notifier-error-inject.c
polynomial.c	lib: add generic polynomial calculation	2022-05-22 11:32:30 -07:00
radix-tree.c	lib/radix-tree: remove unused argument of insert_entries	2022-07-17 17:31:38 -07:00
random32.c	treewide: use get_random_bytes() when possible	2022-10-11 17:42:58 -06:00
ratelimit.c	ratelimit: Fix data-races in ___ratelimit().	2022-08-24 13:46:57 +01:00
rbtree.c
rbtree_test.c
ref_tracker.c
refcount.c
rhashtable.c
sbitmap.c	sbitmap: Try each queue to wake up at least one waiter	2023-03-10 09:34:34 +01:00
scatterlist.c	lib/scatterlist: use matched parameter type when calling __sg_free_table()	2022-07-17 17:31:39 -07:00
seq_buf.c
sg_pool.c	lib/sg_pool: change module_init(sg_pool_init) to subsys_initcall	2022-09-23 16:46:19 +02:00
sg_split.c
show_mem.c	mm: reduce noise in show_mem for lowmem allocations	2022-09-26 19:46:29 -07:00
siphash.c	SPDX changes for 5.19-rc1	2022-06-03 10:34:34 -07:00
slub_kunit.c	mm/slub, kunit: Make slub_kunit unaffected by user specified flags	2022-04-06 10:11:48 +02:00
smp_processor_id.c	lib/smp_processor_id: fix imbalanced instrumentation_end() call	2022-07-17 17:31:41 -07:00
sort.c	lib/sort: Add priv pointer to swap function	2022-03-17 20:17:18 -07:00
stackdepot.c	stackdepot: reserve 5 extra bits in depot_stack_handle_t	2022-10-03 14:03:18 -07:00
stackinit_kunit.c	lib: stackinit: update reference to kunit-tool	2022-09-30 13:21:22 -06:00
stmp_device.c
string.c	kmsan: disable strscpy() optimization under KMSAN	2022-10-03 14:03:22 -07:00
string_helpers.c	lib/string_helpers: Introduce parse_int_array_user()	2022-09-05 14:51:46 +01:00
strncpy_from_user.c	lib/strn*,objtool: Enforce user_access_begin() rules	2022-04-19 21:58:47 +02:00
strnlen_user.c	lib/strn*,objtool: Enforce user_access_begin() rules	2022-04-19 21:58:47 +02:00
syscall.c
test-kstrtox.c
test-string_helpers.c	treewide: use prandom_u32_max() when possible, part 1	2022-10-11 17:42:55 -06:00
test_bitmap.c	lib/bitmap: add tests for for_each() loops	2022-10-01 10:22:58 -07:00
test_bitops.c
test_bits.c
test_blackhole_dev.c
test_bpf.c	test_bpf: fix incorrect netdev features	2022-06-22 19:20:20 -07:00
test_debug_virtual.c
test_dynamic_debug.c	dyndbg: test DECLARE_DYNDBG_CLASSMAP, sysfs nodes	2022-09-07 17:04:49 +02:00
test_firmware.c	test_firmware: fix memory leak in test_firmware_init()	2022-12-31 13:32:40 +01:00
test_fprobe.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
test_fpu.c
test_free_pages.c	lib/test_free_pages.c: pass a pointer to virt_to_page()	2022-07-17 17:14:36 -07:00
test_hash.c
test_hexdump.c	treewide: use prandom_u32_max() when possible, part 1	2022-10-11 17:42:55 -06:00
test_hmm.c	hmm-tests: add test for migrate_device_range()	2022-10-12 18:51:50 -07:00
test_hmm_uapi.h	hmm-tests: add test for migrate_device_range()	2022-10-12 18:51:50 -07:00
test_ida.c
test_kmod.c	lib/test: use after free in register_test_dev_kmod()	2022-03-29 15:13:36 -07:00
test_kprobes.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
test_linear_ranges.c
test_list_sort.c	treewide: use prandom_u32_max() when possible, part 1	2022-10-11 17:42:55 -06:00
test_lockup.c
test_maple_tree.c	test_maple_tree: add more testing for mas_empty_area()	2023-03-30 12:49:26 +02:00
test_memcat_p.c
test_meminit.c	lib/test_meminit: add checks for the allocation functions	2022-10-12 18:51:49 -07:00
test_min_heap.c	treewide: use get_random_u32() when possible	2022-10-11 17:42:58 -06:00
test_module.c
test_objagg.c	treewide: use get_random_bytes() when possible	2022-10-11 17:42:58 -06:00
test_parman.c
test_printf.c	lib/test_printf.c: fix clang -Wformat warnings	2022-07-28 10:38:30 +02:00
test_ref_tracker.c
test_rhashtable.c	rhashtable: make test actually random	2022-10-26 13:39:09 +01:00
test_scanf.c
test_siphash.c	siphash: add SPDX tags as sole licensing authority	2022-05-19 18:54:22 +02:00
test_sort.c
test_static_key_base.c
test_static_keys.c
test_string.c	lib/test_string.c: add strspn and strcspn tests	2022-04-29 14:38:00 -07:00
test_strscpy.c
test_sysctl.c	selftests/sysctl: add sysctl macro test	2022-05-03 10:15:07 +02:00
test_ubsan.c
test_user_copy.c
test_uuid.c
test_vmalloc.c	treewide: use get_random_{u8,u16}() when possible, part 2	2022-10-11 17:42:58 -06:00
test_xarray.c	XArray: Fix xas_create_range() when multi-order entry present	2022-03-28 19:25:11 -04:00
textsearch.c
timerqueue.c
trace_readwrite.c	lib: Add register read/write tracing support	2022-06-15 17:41:12 +02:00
ts_bm.c	lib/ts_bm.c: remove redundant store to variable consumed after addition	2022-07-17 17:31:39 -07:00
ts_fsm.c
ts_kmp.c
ubsan.c	panic: Consolidate open-coded panic_on_warn checks	2023-01-24 07:24:41 +01:00
ubsan.h
ucmpdi2.c
ucs2_string.c
usercopy.c	uaccess: Add speculation barrier to copy_from_user()	2023-02-25 11:25:41 +01:00
uuid.c	treewide: use get_random_bytes() when possible	2022-10-11 17:42:58 -06:00
vsprintf.c	printk changes for 6.1	2022-10-10 11:24:19 -07:00
win_minmax.c
xarray.c	mm/huge_memory: Fix xarray node memory leak	2022-06-09 16:24:25 -04:00
xxhash.c