Miguel Ojeda 31a254f692 rust: arc: add explicit `drop()` around `Box::from_raw()` ... commit 828176d037 upstream. `Box::from_raw()` is `#[must_use]`, which means the result cannot go unused. In Rust 1.71.0, this was not detected because the block expression swallows the diagnostic [1]: unsafe { Box::from_raw(self.ptr.as_ptr()) }; It would have been detected, however, if the line had been instead: unsafe { Box::from_raw(self.ptr.as_ptr()); } i.e. the semicolon being inside the `unsafe` block, rather than outside. In Rust 1.72.0, the compiler started warning about this [2], so without this patch we will get: error: unused return value of `alloc::boxed::Box::<T>::from_raw` that must be used --> rust/kernel/sync/arc.rs:302:22 | 302 | unsafe { Box::from_raw(self.ptr.as_ptr()) }; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: call `drop(Box::from_raw(ptr))` if you intend to drop the `Box` = note: `-D unused-must-use` implied by `-D warnings` help: use `let _ = ...` to ignore the resulting value | 302 | unsafe { let _ = Box::from_raw(self.ptr.as_ptr()); }; | +++++++ + Thus add an add an explicit `drop()` as the `#[must_use]`'s annotation suggests (instead of the more general help line). Link: https://github.com/rust-lang/rust/issues/104253 [1] Link: https://github.com/rust-lang/rust/pull/112529 [2] Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@gmail.com> Reviewed-by: Gary Guo <gary@garyguo.net> Reviewed-by: Alice Ryhl <aliceryhl@google.com> Reviewed-by: Andreas Hindborg <a.hindborg@samsung.com> Reviewed-by: Björn Roy Baron <bjorn3_gh@protonmail.com> Link: https://lore.kernel.org/r/20230823160244.188033-2-ojeda@kernel.org Signed-off-by: Miguel Ojeda <ojeda@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-02-16 19:10:43 +01:00
..
arc	rust: sync: arc: Implement Arc<dyn Any + Send + Sync>::downcast()	2023-04-10 23:55:43 +02:00
lock	rust: sync: make doctests compilable/testable	2023-07-19 09:32:41 -06:00
arc.rs	rust: arc: add explicit `drop()` around `Box::from_raw()`	2024-02-16 19:10:43 +01:00
condvar.rs	rust: sync: introduce `CondVar`	2023-04-22 01:46:45 +02:00
lock.rs	rust: lock: Add intra-doc links to the Backend trait	2023-08-07 11:33:33 +02:00
locked_by.rs	rust: sync: introduce `LockedBy`	2023-04-22 00:20:00 +02:00