Mikulas Patocka 5735a2671f dm-crypt, dm-verity: disable tasklets ... commit 0a9bab391e upstream. Tasklets have an inherent problem with memory corruption. The function tasklet_action_common calls tasklet_trylock, then it calls the tasklet callback and then it calls tasklet_unlock. If the tasklet callback frees the structure that contains the tasklet or if it calls some code that may free it, tasklet_unlock will write into free memory. The commits 8e14f61015 and d9a02e016a try to fix it for dm-crypt, but it is not a sufficient fix and the data corruption can still happen [1]. There is no fix for dm-verity and dm-verity will write into free memory with every tasklet-processed bio. There will be atomic workqueues implemented in the kernel 6.9 [2]. They will have better interface and they will not suffer from the memory corruption problem. But we need something that stops the memory corruption now and that can be backported to the stable kernels. So, I'm proposing this commit that disables tasklets in both dm-crypt and dm-verity. This commit doesn't remove the tasklet support, because the tasklet code will be reused when atomic workqueues will be implemented. [1] https://lore.kernel.org/all/d390d7ee-f142-44d3-822a-87949e14608b@suse.de/T/ [2] https://lore.kernel.org/lkml/20240130091300.2968534-1-tj@kernel.org/ Signed-off-by: Mikulas Patocka <mpatocka@redhat.com> Cc: stable@vger.kernel.org Fixes: 39d42fa96b ("dm crypt: add flags to optionally bypass kcryptd workqueues") Fixes: 5721d4e5a9 ("dm verity: Add optional "try_verify_in_tasklet" feature") Signed-off-by: Mike Snitzer <snitzer@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>		2024-02-23 09:24:55 +01:00
..
bcache	bcache: avoid NULL checking to c->root in run_cache_set()	2023-12-20 17:01:56 +01:00
persistent-data	dm thin metadata: Fix ABBA deadlock by resetting dm_bufio_client	2023-06-16 18:24:13 -04:00
dm-audit.c	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-audit.h
dm-bio-prison-v1.c	dm: improve hash_locks sizing and hash function	2023-03-30 15:57:51 -04:00
dm-bio-prison-v1.h	dm bio prison v1: add dm_cell_key_has_valid_range	2023-03-30 15:57:51 -04:00
dm-bio-prison-v2.c	dm: address space issues relative to switch/while/for/...	2023-02-14 14:23:06 -05:00
dm-bio-prison-v2.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-bio-record.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-bufio.c	dm-bufio: fix no-sleep mode	2023-11-28 17:20:12 +00:00
dm-builtin.c	dm: adjust EXPORT_SYMBOL() to follow functions immediately	2023-02-14 14:23:07 -05:00
dm-cache-background-tracker.c	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-cache-background-tracker.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-cache-block-types.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-cache-metadata.c	Revert "mm: shrinkers: convert shrinker_rwsem to mutex"	2023-06-19 13:19:33 -07:00
dm-cache-metadata.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-cache-policy-internal.h	dm: add missing empty lines	2023-02-14 14:23:06 -05:00
dm-cache-policy-smq.c	dm cache policy smq: ensure IO doesn't prevent cleaner policy progress	2023-07-25 11:55:50 -04:00
dm-cache-policy.c	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-cache-policy.h	dm: address indent/space issues	2023-02-14 14:23:06 -05:00
dm-cache-target.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
dm-clone-metadata.c
dm-clone-metadata.h
dm-clone-target.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
dm-core.h	dm: fix a race condition in retrieve_deps	2023-09-14 11:18:29 -04:00
dm-crypt.c	dm-crypt, dm-verity: disable tasklets	2024-02-23 09:24:55 +01:00
dm-delay.c	dm-delay: fix a race between delay_presuspend and delay_bio	2023-12-03 07:33:09 +01:00
dm-dust.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-ebs-target.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-era-target.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
dm-exception-store.c	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-exception-store.h	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-flakey.c	dm flakey: introduce random_read_corrupt and random_write_corrupt options	2023-06-16 18:24:13 -04:00
dm-ima.c	dm: avoid inline filenames	2023-02-14 14:23:07 -05:00
dm-ima.h	dm: avoid inline filenames	2023-02-14 14:23:07 -05:00
dm-init.c	dm: open code dm_get_dev_t in dm_init_init	2023-06-05 10:57:40 -06:00
dm-integrity.c	dm-integrity: don't modify bio's immutable bio_vec in integrity_metadata()	2024-01-01 12:42:45 +00:00
dm-io-rewind.c	dm: avoid void function return statements	2023-02-14 14:23:07 -05:00
dm-io-tracker.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-io.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-ioctl.c	dm: fix a race condition in retrieve_deps	2023-09-14 11:18:29 -04:00
dm-kcopyd.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-linear.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-log-userspace-base.c	dm: avoid void function return statements	2023-02-14 14:23:07 -05:00
dm-log-userspace-transfer.c	dm: avoid split of quoted strings where possible	2023-02-14 14:23:07 -05:00
dm-log-userspace-transfer.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-log-writes.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-log.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-mpath.c	dm: push error reporting down to dm_register_target()	2023-04-11 12:01:01 -04:00
dm-mpath.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-path-selector.c	dm: adjust EXPORT_SYMBOL() to follow functions immediately	2023-02-14 14:23:07 -05:00
dm-path-selector.h	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-ps-historical-service-time.c	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-ps-io-affinity.c	dm: address space issues relative to switch/while/for/...	2023-02-14 14:23:06 -05:00
dm-ps-queue-length.c	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-ps-round-robin.c	dm: correct block comments format.	2023-02-14 14:23:06 -05:00
dm-ps-service-time.c	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-raid.c	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
dm-raid1.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-region-hash.c	dm: correct block comments format.	2023-02-14 14:23:06 -05:00
dm-rq.c	dm: avoid using symbolic permissions	2023-02-14 14:23:07 -05:00
dm-rq.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-snap-persistent.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-snap-transient.c	dm: avoid split of quoted strings where possible	2023-02-14 14:23:07 -05:00
dm-snap.c	block: replace fmode_t with a block-specific type for block open flags	2023-06-12 08:04:05 -06:00
dm-stats.c	dm stats: check for and propagate alloc_percpu failure	2023-03-16 13:37:06 -04:00
dm-stats.h	dm stats: check for and propagate alloc_percpu failure	2023-03-16 13:37:06 -04:00
dm-stripe.c	dm: remove unnecessary (void*) conversions	2023-04-11 12:01:01 -04:00
dm-switch.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-sysfs.c	dm sysfs: make kobj_type structure constant	2023-02-14 14:23:08 -05:00
dm-table.c	dm: fix a race condition in retrieve_deps	2023-09-14 11:18:29 -04:00
dm-target.c	dm: push error reporting down to dm_register_target()	2023-04-11 12:01:01 -04:00
dm-thin-metadata.c	- Update DM crypt to allocate compound pages if possible.	2023-06-30 12:16:00 -07:00
dm-thin-metadata.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-thin.c	- Update DM crypt to allocate compound pages if possible.	2023-06-30 12:16:00 -07:00
dm-uevent.c	dm: avoid spaces before function arguments or in favour of tabs	2023-02-14 14:23:06 -05:00
dm-uevent.h	dm: fix undue/missing spaces	2023-02-14 14:23:06 -05:00
dm-unstripe.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-verity-fec.c	dm-verity: align struct dm_verity_fec_io properly	2023-12-08 08:52:16 +01:00
dm-verity-fec.h	dm: change "unsigned" to "unsigned int"	2023-02-14 14:23:06 -05:00
dm-verity-loadpin.c	dm: verity-loadpin: Add NULL pointer check for 'bdev' parameter	2023-06-28 10:43:04 -07:00
dm-verity-target.c	dm-crypt, dm-verity: disable tasklets	2024-02-23 09:24:55 +01:00
dm-verity-verify-sig.c	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-verity-verify-sig.h	dm: add missing SPDX-License-Indentifiers	2023-02-14 14:23:06 -05:00
dm-verity.h	dm-crypt, dm-verity: disable tasklets	2024-02-23 09:24:55 +01:00
dm-writecache.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-zero.c	dm: add helper macro for simple DM target module init and exit	2023-04-11 12:09:08 -04:00
dm-zone.c	dm zone: Use the bitmap API to allocate bitmaps	2023-06-16 18:24:13 -04:00
dm-zoned-metadata.c	dm: dm-zoned: use __bio_add_page for adding single metadata page	2023-05-31 09:50:02 -06:00
dm-zoned-reclaim.c
dm-zoned-target.c	dm zoned: free dmz->ddev array in dmz_put_zoned_devices	2023-09-20 13:48:06 -04:00
dm-zoned.h	dm/dm-zoned: Use the enum req_op type	2022-07-14 12:14:31 -06:00
dm.c	dm: don't attempt to queue IO under RCU protection	2023-09-15 15:39:59 -04:00
dm.h	dm: remove stale/redundant dm_internal_{suspend,resume} prototypes in dm.h	2023-06-16 18:24:14 -04:00
Kconfig	dm audit: fix Kconfig so DM_AUDIT depends on BLK_DEV_DM	2024-01-20 11:51:45 +01:00
Makefile	hardening updates for v5.20-rc1	2022-08-02 14:38:59 -07:00
md-autodetect.c	init: improve the name_to_dev_t interface	2023-06-05 10:56:46 -06:00
md-bitmap.c	md/md-bitmap: hold 'reconfig_mutex' in backlog_store()	2023-07-27 00:13:30 -07:00
md-bitmap.h	md-bitmap: don't use ->index for pages backing the bitmap file	2023-07-27 00:13:29 -07:00
md-cluster.c	md: Hold mddev->reconfig_mutex when trying to get mddev->sync_thread	2023-08-15 09:40:26 -07:00
md-cluster.h
md-faulty.c	md/md-faulty: enable io accounting	2023-07-27 00:13:30 -07:00
md-linear.c	md/md-linear: enable io accounting	2023-07-27 00:13:30 -07:00
md-linear.h
md-multipath.c	md/md-multipath: enable io accounting	2023-07-27 00:13:29 -07:00
md-multipath.h
md.c	md: Whenassemble the array, consult the superblock of the freshest device	2024-02-05 20:14:24 +00:00
md.h	md: fix warning for holder mismatch from export_rdev()	2023-09-08 13:16:40 -07:00
raid0.c	md: raid0: account for split bio in iostat accounting	2023-08-17 21:11:31 -07:00
raid0.h	md/raid0: add discard support for the 'original' layout	2023-06-30 15:43:50 -07:00
raid1-10.c	md/raid1-10: fix casting from randomized structure in raid1_submit_write()	2023-06-23 09:33:16 -07:00
raid1.c	md/raid1: Use blk_opf_t for read and write operations	2024-01-25 15:35:46 -08:00
raid1.h	md/raid1: switch to use md_account_bio() for io accounting	2023-07-27 00:13:29 -07:00
raid5-cache.c	md/raid5-cache: fix null-ptr-deref for r5l_flush_stripe_to_raid()	2023-08-15 09:40:27 -07:00
raid5-log.h	md/raid5-ppl: Drop unused argument from ppl_handle_flush_request()	2022-08-02 17:14:31 -06:00
raid5-ppl.c	md: raid5: use __bio_add_page to add single page to new bio	2023-05-31 09:50:02 -06:00
raid5.c	Revert "Revert "md/raid5: Wait for MD_SB_CHANGE_PENDING in raid5d""	2024-01-25 15:36:01 -08:00
raid5.h	hardening updates for v6.5-rc1	2023-06-27 21:24:18 -07:00
raid10.c	md: Hold mddev->reconfig_mutex when trying to get mddev->sync_thread	2023-08-15 09:40:26 -07:00
raid10.h	md/raid10: switch to use md_account_bio() for io accounting	2023-07-27 00:13:29 -07:00