mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-29 22:02:02 +00:00
2c50a570e9
This patch was triggered by a remark from Russell that
introducing a call to the waituart (needed to fix debug prints
on the Qualcomm platforms) was dangerous because in some cases
this will involve waiting for a modem CTS (clear to send)
signal, and debug messages would maybe not work on platforms
with no modem connected to the UART port: they will just
hang waiting for the modem to assert CTS and this might never
happen.
Looking through all UART debug drivers implementing the waituart
macro I discovered that all users except two actually use this
macro to check if the UART is ready for TX, let's call this
TXRDY.
Only two debug UART drivers actually check for CTS:
- arch/arm/include/debug/8250.S
- arch/arm/include/debug/tegra.S
The former is very significant since the 8250 is possibly
the most common UART on the planet.
We have the following problem: the semantics of waituart are
ambiguous making it dangerous to introduce the macro to debug
code fixing debug prints for Qualcomm. To start to pry this
problem apart, this patch does the following:
- Convert all debug UART drivers to define two macros:
- waituartcts with the clear semantic to wait for CTS
to be asserted
- waituarttxrdy with the clear semantic to wait for the TX
capability of the UART to be ready
- When doing this take care to assign the right function to
each drivers macro, so they now do exactly the above.
- Update the three sites in the kernel invoking the waituart
macro to call waituartcts/waituarttxrdy in sequence, so that
the functional impact on the kernel should be zero.
After this we can start to change the code sites using this
code to do the right thing.
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
49 lines
1.2 KiB
ArmAsm
49 lines
1.2 KiB
ArmAsm
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/* arch/arm/mach-imx/include/mach/debug-macro.S
|
|
*
|
|
* Debugging macro include header
|
|
*
|
|
* Copyright (C) 1994-1999 Russell King
|
|
* Moved from linux/arch/arm/kernel/debug.S by Ben Dooks
|
|
*/
|
|
|
|
#include <asm/assembler.h>
|
|
#include "imx-uart.h"
|
|
|
|
/*
|
|
* FIXME: This is a copy of IMX_IO_P2V in hardware.h, and needs to
|
|
* stay sync with that. It's hard to maintain, and should be fixed
|
|
* globally for multi-platform build to use a fixed virtual address
|
|
* for low-level debug uart port across platforms.
|
|
*/
|
|
#define IMX_IO_P2V(x) ( \
|
|
(((x) & 0x80000000) >> 7) | \
|
|
(0xf4000000 + \
|
|
(((x) & 0x50000000) >> 6) + \
|
|
(((x) & 0x0b000000) >> 4) + \
|
|
(((x) & 0x000fffff))))
|
|
|
|
#define UART_VADDR IMX_IO_P2V(UART_PADDR)
|
|
|
|
.macro addruart, rp, rv, tmp
|
|
ldr \rp, =UART_PADDR @ physical
|
|
ldr \rv, =UART_VADDR @ virtual
|
|
.endm
|
|
|
|
.macro senduart,rd,rx
|
|
ARM_BE8(rev \rd, \rd)
|
|
str \rd, [\rx, #0x40] @ TXDATA
|
|
.endm
|
|
|
|
.macro waituartcts,rd,rx
|
|
.endm
|
|
|
|
.macro waituarttxrdy,rd,rx
|
|
.endm
|
|
|
|
.macro busyuart,rd,rx
|
|
1002: ldr \rd, [\rx, #0x98] @ SR2
|
|
ARM_BE8(rev \rd, \rd)
|
|
tst \rd, #1 << 3 @ TXDC
|
|
beq 1002b @ wait until transmit done
|
|
.endm
|