John Fastabend c024db9603 bpf, sockmap: Do not inc copied_seq when PEEK flag set ... [ Upstream commit da9e915eaf ] When data is peek'd off the receive queue we shouldn't considered it copied from tcp_sock side. When we increment copied_seq this will confuse tcp_data_ready() because copied_seq can be arbitrarily increased. From application side it results in poll() operations not waking up when expected. Notice tcp stack without BPF recvmsg programs also does not increment copied_seq. We broke this when we moved copied_seq into recvmsg to only update when actual copy was happening. But, it wasn't working correctly either before because the tcp_data_ready() tried to use the copied_seq value to see if data was read by user yet. See fixes tags. Fixes: e5c6de5fa0 ("bpf, sockmap: Incorrectly handling copied_seq") Fixes: 04919bed94 ("tcp: Introduce tcp_read_skb()") Signed-off-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com> Link: https://lore.kernel.org/bpf/20230926035300.135096-3-john.fastabend@gmail.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-10-10 22:00:41 +02:00
..
6lowpan
9p	9p: virtio: make sure 'offs' is initialized in zc_request	2023-09-13 09:42:21 +02:00
802	mrp: introduce active flags to prevent UAF when applicant uninit	2022-12-31 13:33:02 +01:00
8021q	vlan: fix a potential uninit-value in vlan_dev_hard_start_xmit()	2023-05-24 17:32:47 +01:00
appletalk
atm	atm: hide unused procfs functions	2023-06-09 10:34:16 +02:00
ax25
batman-adv	batman-adv: Hold rtnl lock during MTU update via netlink	2023-08-30 16:11:08 +02:00
bluetooth	Bluetooth: ISO: Fix handling of listen for unicast	2023-10-10 22:00:40 +02:00
bpf	Revert "bpf, test_run: fix &xdp_frame misplacement for LIVE_FRAMES"	2023-03-17 08:50:32 +01:00
bpfilter
bridge	net: bridge: use DEV_STATS_INC()	2023-10-06 14:56:41 +02:00
caif	net: caif: Fix use-after-free in cfusbl_device_notify()	2023-03-17 08:50:24 +01:00
can	can: raw: add missing refcount for memory leak fix	2023-08-30 16:11:11 +02:00
ceph	libceph: fix potential hang in ceph_osdc_notify()	2023-08-11 12:08:19 +02:00
core	net/core: Fix ETH_P_1588 flow dissector	2023-10-06 14:56:36 +02:00
dcb	net: dcb: choose correct policy to parse DCB_ATTR_BCN	2023-08-11 12:08:17 +02:00
dccp	dccp: fix dccp_v4_err()/dccp_v6_err() again	2023-10-06 14:56:39 +02:00
devlink	devlink: remove reload failed checks in params get/set callbacks	2023-09-23 11:11:01 +02:00
dns_resolver
dsa	net: dsa: sja1105: always enable the send_meta options	2023-07-19 16:22:06 +02:00
ethernet
ethtool	ipv6: Remove in6addr_any alternatives.	2023-09-19 12:28:10 +02:00
hsr	net: hsr: Add __packed to struct hsr_sup_tlv.	2023-10-06 14:56:57 +02:00
ieee802154	net: ieee802154: fix error return code in dgram_bind()	2022-10-07 09:29:17 +02:00
ife
ipv4	bpf, sockmap: Do not inc copied_seq when PEEK flag set	2023-10-10 22:00:41 +02:00
ipv6	net: release reference to inet6_dev pointer	2023-10-10 22:00:37 +02:00
iucv	net/iucv: Fix size of interrupt data	2023-03-22 13:33:50 +01:00
kcm	kcm: Fix error handling for SOCK_DGRAM in kcm_sendmsg().	2023-09-19 12:28:10 +02:00
key	net: af_key: fix sadb_x_filter validation	2023-08-23 17:52:32 +02:00
l2tp	net: annotate data-races around sk->sk_mark	2023-08-11 12:08:14 +02:00
l3mdev
lapb
llc	llc: Don't drop packet from non-root netns.	2023-07-27 08:50:45 +02:00
mac80211	wifi: mac80211: fix potential key use-after-free	2023-10-10 22:00:41 +02:00
mac802154	mac802154: fix missing INIT_LIST_HEAD in ieee802154_if_add()	2022-12-05 09:53:08 +01:00
mctp	net: mctp: purge receive queues on sk destruction	2023-02-06 08:06:34 +01:00
mpls	net: mpls: fix stale pointer if allocation fails during device rename	2023-02-22 12:59:53 +01:00
mptcp	mptcp: userspace pm allow creating id 0 subflow	2023-10-10 22:00:38 +02:00
ncsi	ncsi: Propagate carrier gain/loss events to the NCSI controller	2023-10-06 14:56:57 +02:00
netfilter	net: replace calls to sock->ops->connect() with kernel_connect()	2023-10-10 22:00:38 +02:00
netlabel	netlabel: fix shift wrapping bug in netlbl_catmap_setlong()	2023-09-13 09:42:24 +02:00
netlink	netlink: convert nlk->flags to atomic flags	2023-09-23 11:11:02 +02:00
netrom	netrom: Deny concurrent connect().	2023-09-13 09:42:35 +02:00
nfc	net: nfc: Fix use-after-free caused by nfc_llcp_find_local	2023-07-19 16:21:13 +02:00
nsh	net: nsh: Use correct mac_offset to unwind gso skb in nsh_gso_segment()	2023-05-24 17:32:45 +01:00
openvswitch	net: openvswitch: reject negative ifindex	2023-08-23 17:52:35 +02:00
packet	net/packet: annotate data-races around tp->status	2023-08-16 18:27:26 +02:00
phonet
psample
qrtr	net: qrtr: Fix an uninit variable access bug in qrtr_tx_resume()	2023-04-20 12:35:09 +02:00
rds	net: replace calls to sock->ops->connect() with kernel_connect()	2023-10-10 22:00:38 +02:00
rfkill
rose	net/rose: Fix to not accept on connected socket	2023-02-22 12:59:42 +01:00
rxrpc	rxrpc: Fix hard call timeout units	2023-05-17 11:53:35 +02:00
sched	net/sched: Retire rsvp classifier	2023-09-23 11:11:13 +02:00
sctp	sctp: annotate data-races around sk->sk_wmem_queued	2023-09-19 12:28:00 +02:00
smc	net/smc: bugfix for smcr v2 server connect success statistic	2023-10-06 14:56:53 +02:00
strparser
sunrpc	Revert "SUNRPC dont update timeout value on connection reset"	2023-10-06 14:57:03 +02:00
switchdev
tipc	tipc: stop tipc crypto on failure in tipc_node_create	2023-08-03 10:24:02 +02:00
tls	net/tls: do not free tls_rec on async operation in bpf_exec_tx_verdict()	2023-09-19 12:28:09 +02:00
unix	af_unix: Fix data-race around unix_tot_inflight.	2023-09-19 12:28:02 +02:00
vmw_vsock	vsock: avoid to close connected socket after the timeout	2023-05-24 17:32:44 +01:00
wireless	wifi: cfg80211: fix cqm_config access race	2023-10-10 22:00:40 +02:00
x25	net/x25: Fix to not accept on connected socket	2023-02-09 11:28:13 +01:00
xdp	xsk: Fix xsk_diag use-after-free error during socket cleanup	2023-09-19 12:28:01 +02:00
xfrm	xfrm: add forgotten nla_policy for XFRMA_MTIMER_THRESH	2023-08-23 17:52:32 +02:00
compat.c	use less confusing names for iov_iter direction initializers	2023-02-09 11:28:04 +01:00
devres.c
Kconfig
Kconfig.debug	net: make NET_(DEV|NS)_REFCNT_TRACKER depend on NET	2022-09-20 14:23:56 -07:00
Makefile	devlink: move code to a dedicated directory	2023-08-30 16:11:00 +02:00
socket.c	net: prevent rewrite of msg_name in sock_sendmsg()	2023-10-10 22:00:39 +02:00
sysctl_net.c