John Fastabend c024db9603 bpf, sockmap: Do not inc copied_seq when PEEK flag set ... [ Upstream commit da9e915eaf ] When data is peek'd off the receive queue we shouldn't considered it copied from tcp_sock side. When we increment copied_seq this will confuse tcp_data_ready() because copied_seq can be arbitrarily increased. From application side it results in poll() operations not waking up when expected. Notice tcp stack without BPF recvmsg programs also does not increment copied_seq. We broke this when we moved copied_seq into recvmsg to only update when actual copy was happening. But, it wasn't working correctly either before because the tcp_data_ready() tried to use the copied_seq value to see if data was read by user yet. See fixes tags. Fixes: e5c6de5fa0 ("bpf, sockmap: Incorrectly handling copied_seq") Fixes: 04919bed94 ("tcp: Introduce tcp_read_skb()") Signed-off-by: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Daniel Borkmann <daniel@iogearbox.net> Reviewed-by: Jakub Sitnicki <jakub@cloudflare.com> Link: https://lore.kernel.org/bpf/20230926035300.135096-3-john.fastabend@gmail.com Signed-off-by: Sasha Levin <sashal@kernel.org>		2023-10-10 22:00:41 +02:00
..
bpfilter
netfilter	netfilter: tproxy: fix deadlock due to missing BH disable	2023-03-17 08:50:25 +01:00
af_inet.c	ipv4: fix data-races around inet->inet_id	2023-08-30 16:11:02 +02:00
ah4.c	xfrm: ah: add extack to ah_init_state, ah6_init_state	2022-09-29 07:17:59 +02:00
arp.c	ipv4: move from strlcpy with unused retval to strscpy	2022-08-22 17:59:37 -07:00
bpf_tcp_ca.c	bpf: Use 0 instead of NOT_INIT for btf_struct_access() writes	2022-09-10 17:27:32 -07:00
cipso_ipv4.c	cipso: Fix data-races around sysctl.	2022-07-08 12:10:33 +01:00
datagram.c	ipv4: fix data-races around inet->inet_id	2023-08-30 16:11:02 +02:00
devinet.c	net: ipv4: fix one memleak in __inet_del_ifa()	2023-09-19 12:28:08 +02:00
esp4.c	net: ipv4: Use kfree_sensitive instead of kfree	2023-07-27 08:50:45 +02:00
esp4_offload.c	xfrm: Linearize the skb after offloading if needed.	2023-06-28 11:12:29 +02:00
fib_frontend.c	ipv4: Fix incorrect table ID in IOCTL path	2023-03-22 13:33:50 +01:00
fib_lookup.h	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-02-17 11:44:20 -08:00
fib_notifier.c	net: ipv4: remove superfluous header files from fib_notifier.c	2021-09-28 17:32:56 -07:00
fib_rules.c	ipv4: remove unnecessary type castings	2022-04-30 15:12:58 +01:00
fib_semantics.c	ipv4: annotate data-races around fi->fib_dead	2023-09-19 12:28:00 +02:00
fib_trie.c	ipv4: annotate data-races around fi->fib_dead	2023-09-19 12:28:00 +02:00
fou.c	genetlink: start to validate reserved header bytes	2022-08-29 12:47:15 +01:00
gre_demux.c
gre_offload.c	net: gro: skb_gro_header helper function	2022-08-25 10:33:21 +02:00
icmp.c	icmp: guard against too small mtu	2023-04-13 16:55:21 +02:00
igmp.c	igmp: limit igmpv3_newpack() packet size to IP_MAX_MTU	2023-09-13 09:42:59 +02:00
inet_connection_sock.c	tcp: annotate data-races around icsk->icsk_syn_retries	2023-07-27 08:50:48 +02:00
inet_diag.c	net: annotate data-races around sk->sk_mark	2023-08-11 12:08:14 +02:00
inet_fragment.c	ipv4: remove unnecessary type castings	2022-04-30 15:12:58 +01:00
inet_hashtables.c	tcp: Fix bind() regression for v4-mapped-v6 non-wildcard address.	2023-09-19 12:28:10 +02:00
inet_timewait_sock.c	Revert "tcp: avoid the lookup process failing to get sk in ehash table"	2023-07-27 08:50:45 +02:00
inetpeer.c	inetpeer: Fix data-races around sysctl.	2022-07-08 12:10:33 +01:00
ip_forward.c	ip: Fix data-races around sysctl_ip_fwd_update_priority.	2022-07-15 11:49:55 +01:00
ip_fragment.c	net: ip: Handle delivery_time in ip defrag	2022-03-03 14:38:48 +00:00
ip_gre.c	erspan: do not use skb_mac_header() in ndo_start_xmit()	2023-03-30 12:49:09 +02:00
ip_input.c	ipv4: ignore dst hint for multipath routes	2023-09-19 12:28:01 +02:00
ip_options.c	ipv4: drop fragmentation code from ip_options_build()	2022-01-29 17:53:07 +00:00
ip_output.c	net/ipv4: return the real errno instead of -EINVAL	2023-09-23 11:11:02 +02:00
ip_sockglue.c	net: annotate data-races around sk->sk_priority	2023-08-11 12:08:15 +02:00
ip_tunnel.c	net: tunnels: annotate lockless accesses to dev->needed_headroom	2023-03-22 13:33:46 +01:00
ip_tunnel_core.c	tunnels: fix kasan splat when generating ipv4 pmtu error	2023-08-16 18:27:27 +02:00
ip_vti.c	ip_vti: fix potential slab-use-after-free in decode_session6	2023-08-23 17:52:32 +02:00
ipcomp.c	xfrm: ipcomp: add extack to ipcomp{4,6}_init_state	2022-09-29 07:18:00 +02:00
ipconfig.c	Driver core / kernfs changes for 6.0-rc1	2022-08-04 11:31:20 -07:00
ipip.c	net: Add helper function to parse netlink msg of ip_tunnel_parm	2022-10-03 07:59:06 +01:00
ipmr.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-09-22 13:02:10 -07:00
ipmr_base.c	ipmr: adopt rcu_read_lock() in mr_dump()	2022-06-24 11:34:38 +01:00
Kconfig	tcp: configurable source port perturb table size	2022-11-16 13:02:04 +00:00
Makefile
metrics.c	ipv4: prevent potential spectre v1 gadget in ip_metrics_convert()	2023-02-01 08:34:45 +01:00
netfilter.c	netfilter: Use l3mdev flow key when re-routing mangled packets	2022-05-16 13:03:29 +02:00
netlink.c
nexthop.c	nexthop: Fix infinite nexthop bucket dump when using maximum nexthop ID	2023-08-16 18:27:28 +02:00
ping.c	ping: Fix potentail NULL deref for /proc/net/icmp.	2023-04-13 16:55:24 +02:00
proc.c	tcp: Don't allocate tcp_death_row outside of struct netns_ipv4.	2022-09-20 10:21:49 -07:00
protocol.c
raw.c	net: annotate data-races around sk->sk_priority	2023-08-11 12:08:15 +02:00
raw_diag.c	raw: Fix NULL deref in raw_get_next().	2023-04-13 16:55:23 +02:00
route.c	ipv4: fix null-deref in ipv4_link_failure	2023-10-06 14:56:38 +02:00
syncookies.c	mptcp: remove MPTCP 'ifdef' in TCP SYN cookies	2023-01-07 11:11:44 +01:00
sysctl_net_ipv4.c	net/ipv4: ping_group_range: allow GID from 2147483648 to 4294967294	2023-06-14 11:15:16 +02:00
tcp.c	bpf: tcp_read_skb needs to pop skb regardless of seq	2023-10-10 22:00:41 +02:00
tcp_bbr.c	bpf: Switch to new kfunc flags infrastructure	2022-07-21 20:59:42 -07:00
tcp_bic.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_bpf.c	bpf, sockmap: Do not inc copied_seq when PEEK flag set	2023-10-10 22:00:41 +02:00
tcp_cdg.c	Random number generator fixes for Linux 6.1-rc1.	2022-10-16 15:27:07 -07:00
tcp_cong.c	tcp: Add tracepoint for tcp_set_ca_state	2022-04-07 20:33:15 -07:00
tcp_cubic.c	bpf: Switch to new kfunc flags infrastructure	2022-07-21 20:59:42 -07:00
tcp_dctcp.c	bpf: Switch to new kfunc flags infrastructure	2022-07-21 20:59:42 -07:00
tcp_dctcp.h
tcp_diag.c	tcp: Access &tcp_hashinfo via net.	2022-09-20 10:21:49 -07:00
tcp_fastopen.c	tcp: annotate data-races around fastopenq.max_qlen	2023-07-27 08:50:49 +02:00
tcp_highspeed.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_htcp.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_hybla.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_illinois.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_input.c	tcp: tcp_enter_quickack_mode() should be static	2023-09-13 09:42:30 +02:00
tcp_ipv4.c	ipv4: fix data-races around inet->inet_id	2023-08-30 16:11:02 +02:00
tcp_lp.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_metrics.c	tcp_metrics: fix data-race in tcpm_suck_dst() vs fastopen	2023-08-11 12:08:18 +02:00
tcp_minisocks.c	tcp: annotate data-races around tcp_rsk(req)->ts_recent	2023-07-27 08:50:45 +02:00
tcp_nv.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_offload.c	tcp: gso: really support BIG TCP	2023-06-14 11:15:20 +02:00
tcp_output.c	net: annotate data-races around sk->sk_forward_alloc	2023-09-19 12:28:01 +02:00
tcp_rate.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-04-28 13:02:01 -07:00
tcp_recovery.c	tcp: Fix data-races around sysctl_tcp_recovery.	2022-07-20 10:14:50 +01:00
tcp_scalable.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_timer.c	net: tcp: fix unexcepted socket die when snd_wnd is 0	2023-09-13 09:42:32 +02:00
tcp_ulp.c	net/ulp: use consistent error code when blocking ULP	2023-01-24 07:24:43 +01:00
tcp_vegas.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_vegas.h
tcp_veno.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_westwood.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tcp_yeah.c	tcp: add accessors to read/set tp->snd_cwnd	2022-04-06 12:05:41 -07:00
tunnel4.c
udp.c	net: annotate data-races around sk->sk_forward_alloc	2023-09-19 12:28:01 +02:00
udp_bpf.c	bpf, sockmap: Fix an infinite loop error when len is 0 in tcp_bpf_recvmsg_parser()	2023-03-17 08:50:24 +01:00
udp_diag.c
udp_impl.h	net: remove noblock parameter from recvmsg() entities	2022-04-12 15:00:25 +02:00
udp_offload.c	gro: remove rcu_read_lock/rcu_read_unlock from gro_complete handlers	2021-11-24 17:21:42 -08:00
udp_tunnel_core.c	net/tunnel: wait until all sk_user_data reader finish before releasing the sock	2022-12-31 13:32:27 +01:00
udp_tunnel_nic.c	udp_tunnel: Fix end of loop test in udp_tunnel_nic_unregister()	2022-02-23 12:35:00 +00:00
udp_tunnel_stub.c
udplite.c	udplite: Fix NULL pointer dereference in __sk_mem_raise_allocated().	2023-05-30 14:03:20 +01:00
xfrm4_input.c	xfrm: fix inbound ipv4/udp/esp packets to UDPv6 dualstack sockets	2023-06-28 11:12:28 +02:00
xfrm4_output.c
xfrm4_policy.c	net: rename reference+tracking helpers	2022-06-09 21:52:55 -07:00
xfrm4_protocol.c	net: xfrm: unexport __init-annotated xfrm4_protocol_init()	2022-06-08 10:10:13 -07:00
xfrm4_state.c
xfrm4_tunnel.c	xfrm: tunnel: add extack to ipip_init_state, xfrm6_tunnel_init_state	2022-09-29 07:18:00 +02:00