mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-05 18:39:59 +00:00
a9ff696160
Making virt_to_pfn() a static inline taking a strongly typed (const void *) makes the contract of a passing a pointer of that type to the function explicit and exposes any misuse of the macro virt_to_pfn() acting polymorphic and accepting many types such as (void *), (unitptr_t) or (unsigned long) as arguments without warnings. Doing this is a bit intrusive: virt_to_pfn() requires PHYS_PFN_OFFSET and PAGE_SHIFT to be defined, and this is defined in <asm/page.h>, so this must be included *before* <asm/memory.h>. The use of macros were obscuring the unclear inclusion order here, as the macros would eventually be resolved, but a static inline like this cannot be compiled with unresolved macros. The naive solution to include <asm/page.h> at the top of <asm/memory.h> does not work, because <asm/memory.h> sometimes includes <asm/page.h> at the end of itself, which would create a confusing inclusion loop. So instead, take the approach to always unconditionally include <asm/page.h> at the end of <asm/memory.h> arch/arm uses <asm/memory.h> explicitly in a lot of places, however it turns out that if we just unconditionally include <asm/memory.h> into <asm/page.h> and switch all inclusions of <asm/memory.h> to <asm/page.h> instead, we enforce the right order and <asm/memory.h> will always have access to the definitions. Put an inclusion guard in place making it impossible to include <asm/memory.h> explicitly. Link: https://lore.kernel.org/linux-mm/20220701160004.2ffff4e5ab59a55499f4c736@linux-foundation.org/ Signed-off-by: Linus Walleij <linus.walleij@linaro.org> |
||
|---|---|---|
| .. | ||
| common.h | ||
| emev2.h | ||
| headsmp-apmu.S | ||
| headsmp-scu.S | ||
| headsmp.S | ||
| Kconfig | ||
| Makefile | ||
| platsmp-apmu.c | ||
| platsmp-scu.c | ||
| platsmp.c | ||
| pm-rcar-gen2.c | ||
| r8a7779.h | ||
| rcar-gen2.h | ||
| regulator-quirk-rcar-gen2.c | ||
| setup-emev2.c | ||
| setup-r7s9210.c | ||
| setup-r7s72100.c | ||
| setup-r8a73a4.c | ||
| setup-r8a7740.c | ||
| setup-r8a7778.c | ||
| setup-r8a7779.c | ||
| setup-rcar-gen2.c | ||
| setup-sh73a0.c | ||
| sh73a0.h | ||
| smp-emev2.c | ||
| smp-r8a7779.c | ||
| smp-sh73a0.c | ||
| suspend.c | ||
| timer.c | ||