linux-stable/drivers/staging/r8188eu/core
Martin Kaiser b5929325f0 staging: r8188eu: Revert "staging: r8188eu: simplify rtw_get_ff_hwaddr"
This reverts commit fd48124e09 ("staging: r8188eu: simplify
rtw_get_ff_hwaddr").

The cleanup in this commit removes the qsel to addr mappings in
rtw_get_ff_hwaddr. The underlying assumption is that rtw_write_port
uses its addr parameter only for the high_queue check.

This is obviously incorrect as rtw_write_port calls
ffaddr2pipehdl(pdvobj, addr);
where addr is mapped to a usb bulk endpoint.

Unfortunately, testing did not show any problems. The Edimax V2 on which I
tested has two bulk out endpoints. I guess that with the incorrect patch,
addr could only be 0 (no high queue) or 6 (high queue), both of which were
mapped to the first bulk out endpoint. Data transfers did still work...

Fixes: fd48124e09 ("staging: r8188eu: simplify rtw_get_ff_hwaddr")
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20230213195407.15085-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-02-16 13:55:03 +01:00
..
rtw_ap.c staging: r8188eu: make rtw_sta_flush to void 2022-10-31 09:05:18 +01:00
rtw_br_ext.c staging: r8188eu: remove unnecessary casting 2022-11-08 16:29:46 +01:00
rtw_cmd.c staging: r8188eu: merge _rtw_enqueue_cmd into its caller 2023-02-16 13:54:38 +01:00
rtw_efuse.c staging: r8188eu: merge EFUSE_ShadowMapUpdate with its caller 2022-07-11 10:06:45 +02:00
rtw_fw.c staging: r8188eu: convert rtw_writeN() to common error logic 2023-01-17 19:35:22 +01:00
rtw_ieee80211.c staging: r8188eu: Add blank line after declarations 2022-06-10 09:00:46 +02:00
rtw_ioctl_set.c staging: r8188eu: change return type of rtw_set_802_11_disassociate to void 2022-11-08 16:26:34 +01:00
rtw_iol.c staging: r8188eu: call rtw_IOL_append_WRF_cmd directly 2022-06-20 10:00:52 +02:00
rtw_led.c staging: r8188eu: remove state checks in rtw_led_control 2022-11-08 16:29:29 +01:00
rtw_mlme.c staging: r8188eu: xmit_priv's vcs is not used 2023-01-17 19:35:25 +01:00
rtw_mlme_ext.c staging: r8188eu: remove intermediate token variable 2023-01-17 19:31:11 +01:00
rtw_p2p.c staging: r8188eu: remove unused da parameter 2022-12-05 13:29:23 +01:00
rtw_pwrctrl.c staging: r8188eu: remove change_rfpwrstate 2023-02-07 08:41:18 +01:00
rtw_recv.c staging: r8188eu: correct error logic of _rtw_init_recv_priv() 2023-02-06 10:48:01 +01:00
rtw_rf.c staging: r8188eu: clean up rtw_rf.c 2022-02-25 10:06:49 +01:00
rtw_security.c staging: r8188eu: convert aes_cipher() to void 2022-11-17 19:48:46 +01:00
rtw_sta_mgt.c staging: r8188eu: replace hand coded loop with list_for_each_entry 2023-02-16 13:54:41 +01:00
rtw_wlan_util.c staging: r8188eu: use subtype helper in rtw_check_bcn_info 2022-12-05 13:29:32 +01:00
rtw_xmit.c staging: r8188eu: Revert "staging: r8188eu: simplify rtw_get_ff_hwaddr" 2023-02-16 13:55:03 +01:00