linux-stable/drivers/staging/r8188eu
Martin Kaiser b5929325f0 staging: r8188eu: Revert "staging: r8188eu: simplify rtw_get_ff_hwaddr"
This reverts commit fd48124e09 ("staging: r8188eu: simplify
rtw_get_ff_hwaddr").

The cleanup in this commit removes the qsel to addr mappings in
rtw_get_ff_hwaddr. The underlying assumption is that rtw_write_port
uses its addr parameter only for the high_queue check.

This is obviously incorrect as rtw_write_port calls
ffaddr2pipehdl(pdvobj, addr);
where addr is mapped to a usb bulk endpoint.

Unfortunately, testing did not show any problems. The Edimax V2 on which I
tested has two bulk out endpoints. I guess that with the incorrect patch,
addr could only be 0 (no high queue) or 6 (high queue), both of which were
mapped to the first bulk out endpoint. Data transfers did still work...

Fixes: fd48124e09 ("staging: r8188eu: simplify rtw_get_ff_hwaddr")
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20230213195407.15085-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-02-16 13:55:03 +01:00
..
core staging: r8188eu: Revert "staging: r8188eu: simplify rtw_get_ff_hwaddr" 2023-02-16 13:55:03 +01:00
hal staging: r8188eu: bagg_pkt parameter is not used 2023-02-08 13:30:00 +01:00
include staging: r8188eu: Revert "staging: r8188eu: simplify rtw_get_ff_hwaddr" 2023-02-16 13:55:03 +01:00
os_dep staging: r8188eu: simplify xmit_buf flags 2023-02-08 13:30:00 +01:00
Kconfig staging: r8188eu: Remove conditionals CONFIG_88EU_{AP_MODE,P2P} 2021-09-13 08:49:54 +02:00
Makefile staging: r8188eu: remove hal/odm_RegConfig8188E.c 2022-09-27 10:28:11 +02:00
TODO