Merge pull request #100 from adnanh/env-names

Do not prefix EnvName with HOOK_
This commit is contained in:
Adnan Hajdarević 2016-09-29 19:20:06 +02:00 committed by GitHub
commit c6530b17e7
3 changed files with 3 additions and 3 deletions

View file

@ -367,7 +367,7 @@ func (h *Hook) ExtractCommandArgumentsForEnv(headers, query, payload *map[string
if arg, ok := h.PassEnvironmentToCommand[i].Get(headers, query, payload); ok { if arg, ok := h.PassEnvironmentToCommand[i].Get(headers, query, payload); ok {
if h.PassEnvironmentToCommand[i].EnvName != "" { if h.PassEnvironmentToCommand[i].EnvName != "" {
// first try to use the EnvName if specified // first try to use the EnvName if specified
args = append(args, EnvNamespace+h.PassEnvironmentToCommand[i].EnvName+"="+arg) args = append(args, h.PassEnvironmentToCommand[i].EnvName+"="+arg)
} else { } else {
// then fallback on the name // then fallback on the name
args = append(args, EnvNamespace+h.PassEnvironmentToCommand[i].Name+"="+arg) args = append(args, EnvNamespace+h.PassEnvironmentToCommand[i].Name+"="+arg)

View file

@ -179,7 +179,7 @@ var hookExtractCommandArgumentsForEnvTests = []struct {
"test", "test",
[]Argument{Argument{"header", "a", "MYKEY"}}, []Argument{Argument{"header", "a", "MYKEY"}},
&map[string]interface{}{"a": "z"}, nil, nil, &map[string]interface{}{"a": "z"}, nil, nil,
[]string{"HOOK_MYKEY=z"}, []string{"MYKEY=z"},
true, true,
}, },
// failures // failures

View file

@ -21,7 +21,7 @@ import (
) )
const ( const (
version = "2.4.0" version = "2.5.0"
) )
var ( var (