Commit graph

76 commits

Author SHA1 Message Date
Adnan Hajdarević
12c48f87cb Merge pull request #19 from moorereason/test-json
Add tests for ParseJSONParameters
2015-03-21 10:28:20 +01:00
Adnan Hajdarević
acf38c3210 Merge pull request #18 from moorereason/extract-tests
Add new tests for ExtractParameter
2015-03-21 10:26:36 +01:00
Cameron Moore
d3f368cb8f Add tests for ParseJSONParameters
This commit adds 100% coverage to Hook.ParaseJSONParameters.
2015-03-20 23:22:30 -05:00
Cameron Moore
943bc258f7 Add new tests for ExtractParameter
This commit regains 100% coverage for ExtractParameter after changes
from commit 688483d.
2015-03-20 22:43:39 -05:00
Adnan Hajdarevic
231426da57 removed leftover debug trace, fixed a panic bug 2015-03-21 01:26:04 +01:00
Adnan Hajdarević
baec1cadc5 Merge pull request #17 from adnanh/json-parameters
added parse-parameters-as-json property to hooks, fixed some bugs in old...
2015-03-21 01:18:44 +01:00
Adnan Hajdarevic
688483d6d1 added parse-parameters-as-json property to hooks, fixed some bugs in old code 2015-03-21 01:10:17 +01:00
Adnan Hajdarević
bddb523b67 Merge pull request #16 from moorereason/fix-notrule
Fix infinite loop in NotRule.Evaluate
2015-03-20 23:37:49 +01:00
Adnan Hajdarević
b8807ed434 Merge pull request #15 from moorereason/fix-negindex
Only support unsigned ints for slice indexes
2015-03-20 23:31:42 +01:00
Adnan Hajdarević
8527a9b23e Merge pull request #14 from moorereason/hook-tests
Complete hook test suite
2015-03-20 23:31:23 +01:00
Cameron Moore
becd8935be Fix infinite loop in NotRule.Evaluate 2015-03-20 16:58:58 -05:00
Cameron Moore
230d16dd93 Only support unsigned ints for slice indexes
This commit changes ExtractParameter to parse slice indexes as unsigned
ints.  Fixes test case "a.-1.b".
2015-03-20 16:54:03 -05:00
Cameron Moore
9a7dedbc09 Complete hook test suite
This commit provides 100% test coverage of the hook package.

Two bugs were discovered with these tests.  I'll be submitting separate
commits to fix those issues.
2015-03-20 16:46:08 -05:00
Adnan Hajdarević
84ce6f262a Merge pull request #13 from moorereason/refactor-helpers
Refactor to remove helpers package
2015-03-20 15:05:07 +01:00
Cameron Moore
7dd55f5232 Refactor to remove helpers package
This commit removes the "helpers" package by moving functions from the
package into the other packages that use them.

CheckPayloadSignature() and ExtractParamater() are simply moved to the
"hook" package.  I'm not sure of the usefulness of having these
functions exported, but I left them allow for now.

ValuesToMap() is moved to the "main" webhook package and renamed to
valuesToMap().

Tests were moved into the "hook" package since we only test
ExtractParameter() right now.

This commit closes adnanh/webhook#12.
2015-03-20 08:55:42 -05:00
Adnan Hajdarević
d8a21582a3 Merge pull request #11 from moorereason/fix-extractparam
Fix ExtractParameter and add tests
2015-03-19 20:29:14 +01:00
Cameron Moore
8a627f7e67 Fix slice traversal in ExtractParameter
With these changes, I'm able to pass tests "a.1.b" and "a.1.b.c".
2015-03-19 12:15:37 -05:00
Cameron Moore
7635cfde33 Add another slice test to ExtractParameter tests 2015-03-19 11:55:24 -05:00
Cameron Moore
2a2a20dcb8 Add tests for ExtractParameter 2015-03-19 11:32:10 -05:00
Adnan Hajdarević
10755eb9d9 Merge pull request #9 from moorereason/vet
Cleanups from static analyzers
2015-03-19 16:31:24 +01:00
Cameron Moore
e9aaeb579e Rework negroni Logger creation
From `go vet`:

webhook.go:98: github.com/codegangsta/negroni.Logger composite literal uses unkeyed fields
2015-03-19 09:23:47 -05:00
Cameron Moore
956589fab3 Improve placement of variable declaration
Thanks to rsc.io/grind
2015-03-19 09:21:15 -05:00
Adnan Hajdarevic
f83af97138 added per-hook defined response message 2015-03-17 19:34:54 +01:00
Adnan Hajdarevic
5a96a5721a added custom url prefix for served hooks url path 2015-03-17 19:05:18 +01:00
Adnan Hajdarević
37b310feaa Merge pull request #4 from adnanh/development
added support for https
2015-03-14 13:06:14 +01:00
Adnan Hajdarevic
ad76b51e6a updated minor version to 2.2.0 2015-03-14 13:04:28 +01:00
Adnan Hajdarevic
4304aaa2d5 readme update 2015-03-14 13:03:51 +01:00
Adnan Hajdarevic
a2fac2373b updated readme to include https 2015-03-14 13:02:41 +01:00
Adnan Hajdarevic
c9adceb5d8 added support for https 2015-03-14 12:59:54 +01:00
Adnan Hajdarevic
8488d3c432 Merge branch 'master' of github.com:adnanh/webhook 2015-03-14 12:44:24 +01:00
Adnan Hajdarevic
d3f5da5489 bumped up the minor version to 2.1.0 2015-03-14 12:44:05 +01:00
Adnan Hajdarević
59b4954845 Update README.md 2015-03-14 12:42:59 +01:00
Adnan Hajdarević
36aea82855 Merge pull request #3 from adnanh/development
added ability to hot reload the hooks file
2015-03-14 12:39:05 +01:00
Adnan Hajdarevic
652109d46e added ability to hot reload the hooks file 2015-03-14 12:37:45 +01:00
Adnan Hajdarevic
a7bbff0963 fixed invalid parameter name in example file 2015-03-13 01:59:10 +01:00
Adnan Hajdarevic
0b269e4870 fixed payload-hash-sha1 for github header 2015-03-13 01:54:23 +01:00
Adnan Hajdarević
40d01e4d5a typo 2015-03-13 01:43:44 +01:00
Adnan Hajdarevic
90528b2ed9 webhook 2.0.0 2015-03-13 01:31:49 +01:00
Adnan Hajdarevic
489750a710 added logger 2015-03-12 13:09:50 +01:00
Adnan Hajdarevic
b332c9e715 added flags 2015-03-11 17:08:53 +01:00
Adnan Hajdarevic
bacf2b3666 negroni boilerplate 2015-03-11 16:48:52 +01:00
Adnan Hajdarevic
c96b0497e4 updates to README wiki links 2015-03-11 02:23:16 +01:00
Adnan Hajdarevic
56560d3809 merge 2015-03-11 02:21:00 +01:00
Adnan Hajdarevic
d858b54309 new path 2015-03-11 02:19:32 +01:00
Adnan Hajdarević
a6023dea8f Update README.md 2015-03-08 14:29:01 +01:00
Adnan Hajdarević
93ab47359d Update README.md 2015-02-26 16:43:45 +01:00
Adnan Hajdarević
2e16eb5d77 bumped up the minor version 2015-02-26 15:56:41 +01:00
Adnan Hajdarević
f47ba2ad97 Update webhook.go
misplaced closing bracket...
2015-02-26 15:56:15 +01:00
Adnan Hajdarevic
d285c08f9f logical error 2015-02-25 01:06:55 +01:00
Adnan Hajdarevic
899e5333e8 removed debug output 2015-02-25 01:05:33 +01:00