vbatts/cri-o
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

CONTRIBUTING: Link to .github/CODEOWNERS

Browse source 
Remove a dead "Becoming a Maintainer" link and that stub section,
since CRI-O currently doesn't document that process.  By leaving it
undocumented, maintainer changes falls back to the usual pull-request
review process.

Link to CODEOWNERS and associated documentation so that folks can
figure out what the usual pull-request processs is.  The "most" wiggle
is because CRI-O seems to have not required review from code owners
[1], based on GitHub's [2]:

  Review has been requested on this pull request. It is not required
  to merge.

wording.

[1]: https://help.github.com/articles/enabling-required-reviews-for-pull-requests/
[2]: https://github.com/kubernetes-incubator/cri-o/pull/1265

Signed-off-by: W. Trevor King <wking@tremily.us>
This commit is contained in:
W. Trevor King 2018-01-19 15:34:58 -08:00
parent 77561e95cf
commit 7b20cd1ccd
1 changed files with 2 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

21
CONTRIBUTING.md
View file

@ -8,7 +8,6 @@ that we follow.
* [Reporting Issues](#reporting-issues)
* [Submitting Pull Requests](#submitting-pull-requests)
* [Communications](#communications)
* [Becoming a Maintainer](#becoming-a-maintainer)
## Reporting Issues
@ -55,9 +54,7 @@ PRs that fix issues should include a reference like `Closes #XXXX` in the
commit message so that github will automatically close the referenced issue
when the PR is merged.
<!--
All PRs require at least two LGTMs (Looks Good To Me) from maintainers.
-->
Most PRs will be reviewied by at least one [code owner][code-owners] (listed [here](.github/CODEOWNERS)).
### Sign your PRs
@ -125,18 +122,4 @@ and
[PRs](https://github.com/kubernetes-incubator/cri-o/pulls)
tracking system.
<!--
## Becoming a Maintainer
To become a maintainer you must first be nominated by an existing maintainer.
If a majority (>50%) of maintainers agree then the proposal is adopted and
you will be added to the list.
Removing a maintainer requires at least 75% of the remaining maintainers
approval, or if the person requests to be removed then it is automatic.
Normally, a maintainer will only be removed if they are considered to be
inactive for a long period of time or are viewed as disruptive to the community.
The current list of maintainers can be found in the
[MAINTAINERS](MAINTAINERS) file.
-->
[code-owners]: https://help.github.com/articles/about-codeowners/