vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

linux/hostdisk: Limit strcpy size to buffer size.

Browse source 
Found by: Coverity scan.
This commit is contained in:
Vladimir Serbinenko 2015-01-27 16:48:53 +01:00
parent 916733ea6a
commit c2fc41990a
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
grub-core/osdep/linux/hostdisk.c
View file

@ -376,7 +376,7 @@ grub_util_fd_open_device (const grub_disk_t disk, grub_disk_addr_t sector, int f
part_start = grub_partition_get_start (disk->partition); part_start = grub_partition_get_start (disk->partition);
strcpy (dev, grub_util_biosdisk_get_osdev (disk)); strlcpy (dev, grub_util_biosdisk_get_osdev (disk), sizeof (dev));
if (disk->partition if (disk->partition
&& strncmp (dev, "/dev/", 5) == 0) && strncmp (dev, "/dev/", 5) == 0)
{ {
@ -439,7 +439,7 @@ grub_util_fd_open_device (const grub_disk_t disk, grub_disk_addr_t sector, int f
if (*max == 0) if (*max == 0)
*max = ~0ULL; *max = ~0ULL;
is_partition = 0; is_partition = 0;
strcpy (dev, grub_util_biosdisk_get_osdev (disk)); strlcpy (dev, grub_util_biosdisk_get_osdev (disk), sizeof (dev));
goto reopen; goto reopen;
} }
sector -= part_start; sector -= part_start;