vbatts/grub
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
8929 commits 7 branches 0 tags 143 MiB
Commit graph

8929 commits

This branch
This branch
All branches
Author SHA1 Message Date
Vladimir Serbinenko
2ae9457e6e disk/lvm: Use zalloc to ensure that segments are initialised to sane value. 
Reported by: EmanueL Czirai.
 2015-02-14 20:31:00 +01:00
Daniel Kiper
8e5bc2f4d3 multiboot2: Fix information request tag size calculation 
Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
 2015-02-14 19:26:04 +03:00
Andrei Borzenkov
fc535b32b9 diskfilter: fix double free of lv names for mdraid 
Avoid micro-optimization in grub_diskfilter_make_raid and make sure
name and fullname are independent strings. This avoids need to special
case it everywhere else.

Also fix memory leak in failure case in grub_diskfilter_make_raid.

Closes: 41582
 2015-02-14 19:08:58 +03:00
Andrei Borzenkov
e27fdbd686 diskfilter: fix crash in validate_lv for mdraid arrays 
Commit 750f4bacd3 put LV validation before
actual vg assignment. Make grub_diskfilter_make_raid to assign ->vg as
happens in other cases for consistency. Also clean up redundant code and add
explicit NULL lv->vg check in validate_lv.

Also fix segment validation in validate_lv; it became obvious when crash
was fixed.

Closes: 44199
 2015-02-14 17:56:01 +03:00
Jiri Slaby
32cd33bd19 util: mkimage, fix gcc5 build failure 
gcc5 reports:
../util/mkimage.c: In function 'grub_install_get_image_target':
../util/mkimage.c:954:5: error: loop exit may only be reached after undefined behavior [-Werror=aggressive-loop-optimizations]
     && j < ARRAY_SIZE (image_targets[i].names); j++)
     ^
../util/mkimage.c:953:39: note: possible undefined statement is here
      for (j = 0; image_targets[i].names[j]
                                        ^

Well, let's move the index 'j' test before accesing the array to:
1) make the loop obvious
2) make gcc happy

Signed-off-by: Jiri Slaby <jslaby@suse.cz>
 2015-02-12 22:18:01 +03:00
Leif Lindholm
c0f529ea67 arm: implement additional relocations generated by gcc 4.9 at -O3 
GCC 4.9 also generates R_ARM_THM_MOVW_ABS_NC and R_ARM_THM_MOVT_ABS,
as an alternative to ABS32.

Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
 2015-02-03 22:50:08 +00:00
Andrei Borzenkov
016875dd52 setup: fix blocklist size calculation 
Found by: Coverity scan.
 2015-01-30 22:57:39 +03:00
Andrei Borzenkov
151c19a42a grub-fstest: fix descriptor leak 
Found by: Coverity scan.
 2015-01-30 22:45:58 +03:00
Andrei Borzenkov
12abe75aa0 net/pxe: fix error condition 
Test return value of grub_netbuff_reserve(), buf itself cannot be
NULL here.

Found by: Coverity scan.
 2015-01-30 22:39:11 +03:00
Andrei Borzenkov
7aaed66455 grub-mkimage: fix potential NULL pointer dereference 
Move fatal check whether symtab_section is NULL before first reference.

Found by: Coverity scan.
 2015-01-30 22:26:05 +03:00
Andrei Borzenkov
b40fde29a4 net/ip: check result of grub_netbuff_push 
Found by: Coverity scan.
 2015-01-30 22:09:51 +03:00
Andrei Borzenkov
1e047e53ae tests: add test command file tests 
This requires access to files in both host and grub image, so
implementing as separate test unit instead of script test was
more easy.
 2015-01-30 21:42:46 +03:00
Andrei Borzenkov
f153fcb5a5 test: consistently use TMPDIR and same name pattern for temp files 2015-01-30 20:31:20 +03:00
Andrei Borzenkov
958167b91c test: fix previous commit - we need to return from subexpression 
( ... ) was processed recursively, we need to return from it. Revert
this change.
 2015-01-30 20:21:56 +03:00
Andrei Borzenkov
d29259b134 test: do not stop after first file test or closing bracket 
Closes: 44115
 2015-01-30 20:10:43 +03:00
Leif Lindholm
2da4171eab configure.ac: don't use -msoft-float for arm64 
aarch64 toolchains do not support the -msoft-float option added by
commit 3661261f. Insted, for arm64 use -march=armv8-a+nofp+nosimd.

Reported-by: Ryan Harkin <ryan.harkin@linaro.org>
 2015-01-28 20:44:41 +00:00
Andrei Borzenkov
9883307a52 script/execute.c: fix memory leak. 
Make sure to continue loop over array after failure to free
allocated strings.

Found by: Coverity scan.
 2015-01-28 20:35:28 +03:00
Andrei Borzenkov
2efab86d5a syslinux_parse: fix memory leak. 
Found by: Coverity scan.
 2015-01-28 20:09:25 +03:00
Andrei Borzenkov
1a4e47879c Change quotes to match overall style in NEWS 2015-01-27 22:34:50 +03:00
Andrei Borzenkov
fbb4aa1c05 loader/xnu: fix memory leak. 
Foound by: Coverity scan.
 2015-01-27 22:12:06 +03:00
Andrei Borzenkov
11aae26cc3 util/grub-probe: fix memory leaks. 
Found by: Coverity scan.
 2015-01-27 22:11:52 +03:00
Andrei Borzenkov
edc94e4b0b fs/hfsplus: fix memory leak. 
Found by: Coverity scan.
 2015-01-27 21:19:28 +03:00
Andrei Borzenkov
3900726fa8 fs/zfs/zfscrypt.c: fix indentation. 2015-01-27 21:13:10 +03:00
Andrei Borzenkov
fa13e60527 fs/zfs/zfscrypt.c: fix memory leaks. 
Found by: Coverity scan.
 2015-01-27 21:12:19 +03:00
Andrei Borzenkov
3db4f05a10 commands/parttool: fix memory leak. 
Found by: Coverity scan.
 2015-01-27 20:55:25 +03:00
Andrei Borzenkov
e871994849 fs/zfs/zfs.c: fix memory leak. 
Found by: Coverity scan.
 2015-01-27 20:52:27 +03:00
Andrei Borzenkov
637fc62699 linux/ofpath: fix descriptor leak 
Found by: Coverity scan
 2015-01-27 20:29:00 +03:00
Andrei Borzenkov
7ba137f628 linux/hostdisk: use strncpy instead of strlcpy 
strlcpy is not available on Linux as part of standard libraries.
It probably is not worth extra configure checks espicially as we
need to handle missing function anyway.
 2015-01-27 20:00:23 +03:00
Vladimir Serbinenko
9ee5ae1fae Document intentional fallthroughs. 
Found by: Coverity scan.
 2015-01-27 17:17:58 +01:00
Vladimir Serbinenko
8f95eae423 linux/ofpath: Fix error handling. 
Found by: Coverity Scan.
 2015-01-27 16:49:49 +01:00
Vladimir Serbinenko
c2fc41990a linux/hostdisk: Limit strcpy size to buffer size. 
Found by: Coverity scan.
 2015-01-27 16:48:53 +01:00
Vladimir Serbinenko
916733ea6a fs/zfscrypt: Add missing explicit cast. 
Found by: Coverity scan.
 2015-01-27 16:35:37 +01:00
Vladimir Serbinenko
0daf46fdbd fs/zfs: Fix error handling. 
Found by: Coverity Scan.
 2015-01-27 16:32:21 +01:00
Vladimir Serbinenko
69a52e95d4 fs/{cbfs,cpio}: Remove useless check if mode is NULL. 
Callers already ensure that it's not null.

Found by: Coverity Scan.
 2015-01-27 16:32:21 +01:00
Vladimir Serbinenko
4192f2e3d1 commands/acpi: Use ALIGN_UP rather than manual expression. 
Improves readability and hopefully automatic scanning.

Found by: Coverity Scan.
 2015-01-27 16:32:21 +01:00
Andrei Borzenkov
bd196014ec util/setup: fix memory leak. 
Found by: Coverity scan.
 2015-01-26 23:04:09 +03:00
Andrei Borzenkov
fe4efe0d50 util/mkimage: fix memory leaks. 
Found by: Coverity scan.
 2015-01-26 23:04:09 +03:00
Andrei Borzenkov
1a87156e01 util/grub-mount: fix descriptor leak. 
Found by: Coverity scan.
 2015-01-26 23:04:09 +03:00
Andrei Borzenkov
bd4e20eedf util/grub-mkstandalone: fix memory leak. 
Found by: Coverity scan.
 2015-01-26 23:04:09 +03:00
Andrei Borzenkov
be0743b052 util/grub-install: rearrange code to avoid memory leak. 
Found by: Coverity scan.
 2015-01-26 23:04:09 +03:00
Andrei Borzenkov
e61f4eba18 linux/getroot: fix memory leak. 
Found by: Coverity scan.
 2015-01-26 23:04:09 +03:00
Andrei Borzenkov
5e27fb06f2 util/install: fix memory leak. 
Found by: Coverity scan.
 2015-01-26 23:04:09 +03:00
Andrei Borzenkov
64440daa21 util/setup: fix memory leak. 
Found by: Coverity scan.
 2015-01-26 23:04:09 +03:00
Andrei Borzenkov
e2a21238da linux/ofpath: fix various memory leaks. 
Found by: Coverity scan.
 2015-01-26 23:04:00 +03:00
Andrei Borzenkov
6704abade6 linux/getroot: fix descriptor leak. 
Found by: Coverity scan.
 2015-01-26 23:02:55 +03:00
Vladimir Serbinenko
11eed6abce util/misc.c: Check ftello return value. 
Found by: Coverity scan.
 2015-01-26 09:56:24 +01:00
Vladimir Serbinenko
5d61a6a612 grub-macbless: Fix resource leak. 
Found by: Coverity scan.
 2015-01-26 09:55:58 +01:00
Vladimir Serbinenko
3c6384832b grub-install: Fix memory leak. 
Found by: Coverity scan.
 2015-01-26 09:55:30 +01:00
Vladimir Serbinenko
c3f5230597 grub-install-common: Fix sizeof usage. 
Found by: Coverity scan.
 2015-01-26 09:54:50 +01:00
Vladimir Serbinenko
866f469683 util/getroot: Add missing grub_disk_close. 
Found by: Coverity scan.
 2015-01-26 09:54:14 +01:00