fix: prevents re-creating locations and labels when someone joins group (#262)

* closes #258

* remove debug statement

backend/internal/core/services/service_user.go

@@ -54,12 +54,14 @@ func (svc *UserService) RegisterUser(ctx context.Context, data UserRegistration)
 		err   error
 		group repo.Group
 		token repo.GroupInvitation
-		isOwner = false
+
+		// creatingGroup is true if the user is creating a new group.
+		creatingGroup = false
 	)
 
 	switch data.GroupToken {
 	case "":
-		isOwner = true
+		creatingGroup = true
 		group, err = svc.repos.Groups.GroupCreate(ctx, "Home")
 		if err != nil {
 			log.Err(err).Msg("Failed to create group")
@@ -81,7 +83,7 @@ func (svc *UserService) RegisterUser(ctx context.Context, data UserRegistration)
 		Password:    hashed,
 		IsSuperuser: false,
 		GroupID:     group.ID,
-		IsOwner:     isOwner,
+		IsOwner:     creatingGroup,
 	}
 
 	usr, err := svc.repos.Users.Create(ctx, usrCreate)
@@ -89,6 +91,8 @@ func (svc *UserService) RegisterUser(ctx context.Context, data UserRegistration)
 		return repo.UserOut{}, err
 	}
 
+	// Create the default labels and locations for the group.
+	if creatingGroup {
 		for _, label := range defaultLabels() {
 			_, err := svc.repos.Labels.Create(ctx, group.ID, label)
 			if err != nil {
@@ -102,8 +106,9 @@ func (svc *UserService) RegisterUser(ctx context.Context, data UserRegistration)
 				return repo.UserOut{}, err
 			}
 		}
+	}
 
-	// Decrement the invitation token if it was used
+	// Decrement the invitation token if it was used.
 	if token.ID != uuid.Nil {
 		err = svc.repos.Groups.InvitationUpdate(ctx, token.ID, token.Uses-1)
 		if err != nil {

backend/internal/data/repo/repo_items.go

@@ -653,7 +653,7 @@ func (e *ItemsRepository) GetAllCustomFieldNames(ctx context.Context, GID uuid.U
 
 	var fields []st
 
-	err := e.db.Debug().Item.Query().
+	err := e.db.Item.Query().
 		Where(
 			item.HasGroupWith(group.ID(GID)),
 		).