addressed PR comments

This commit is contained in:
Eric Sommerlade 2023-09-09 13:35:50 +01:00
parent 47d5f35257
commit cb864773ba

View file

@ -475,13 +475,11 @@ endif()
if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "arm" OR ${CMAKE_SYSTEM_PROCESSOR} MATCHES "aarch64" OR "${CMAKE_GENERATOR_PLATFORM_LWR}" MATCHES "arm64")
message(STATUS "ARM detected")
if (MSVC)
# TODO: arm msvc?
# x86 add_compile_options(/arch:AVX2)
add_compile_definitions(__ARM_NEON)
add_compile_definitions(__ARM_FEATURE_FMA)
add_compile_definitions(__ARM_FEATURE_DOTPROD)
#add_compile_definitions(__ARM_FEATURE_FP16_VECTOR_ARITHMETIC)
add_compile_definitions(__aarch64__) # MSVC _M_ARM64
# add_compile_definitions(__ARM_FEATURE_FP16_VECTOR_ARITHMETIC) # MSVC doesn't support vdupq_n_f16, vld1q_f16, vst1q_f16
add_compile_definitions(__aarch64__) # MSVC defines _M_ARM64 instead
else()
if (${CMAKE_SYSTEM_PROCESSOR} MATCHES "armv6")
# Raspberry Pi 1, Zero