adservice: restore old grpc views until new grpc version is released. (#144)

This commit is contained in:
rghetia 2019-02-14 18:14:42 -08:00 committed by Ahmet Alp Balkan
parent 09f5ce89da
commit 741c669c34

View file

@ -270,7 +270,14 @@ public final class AdService {
/** Main launches the server from the command line. */
public static void main(String[] args) throws IOException, InterruptedException {
// Registers all RPC views.
RpcViews.registerAllGrpcViews();
/**
* [TODO:rghetia] replace registerAllViews with registerAllGrpcViews.
* registerAllGrpcViews registers new views using new measures however current grpc version records against
* old measures. When new version of grpc (0.19) is release revert back to new. After reverting
* back to new the new measure will not provide any tags (like method). This will create
* some discrepencies when compared grpc measurements in Go services.
*/
RpcViews.registerAllViews();
new Thread(
new Runnable() {