vbatts/microservices-demo
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity

adservice: restore old grpc views until new grpc version is released. (#144)

Browse source
This commit is contained in:
rghetia 2019-02-14 18:14:42 -08:00 committed by Ahmet Alp Balkan
parent 09f5ce89da
commit 741c669c34
1 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/adservice/src/main/java/hipstershop/AdService.java
View file

@ -270,7 +270,14 @@ public final class AdService {
/** Main launches the server from the command line. */ /** Main launches the server from the command line. */
public static void main(String[] args) throws IOException, InterruptedException { public static void main(String[] args) throws IOException, InterruptedException {
// Registers all RPC views. // Registers all RPC views.
RpcViews.registerAllGrpcViews(); /**
* [TODO:rghetia] replace registerAllViews with registerAllGrpcViews.
* registerAllGrpcViews registers new views using new measures however current grpc version records against
* old measures. When new version of grpc (0.19) is release revert back to new. After reverting
* back to new the new measure will not provide any tags (like method). This will create
* some discrepencies when compared grpc measurements in Go services.
*/
RpcViews.registerAllViews();
new Thread( new Thread(
new Runnable() { new Runnable() {