vbatts/pkg
1
0
Fork 0
Code Pull requests Releases Activity
1287 commits 2 branches 0 tags 3.9 MiB
Commit graph

1287 commits

This branch
This branch
All branches
Author SHA1 Message Date
Yestin Sun
6ae14a2625 Improve test accuracy for pkg/chrootarchive (part 2) 
Check test correctness of untar by comparing destination with
source. For part 2, it checkes hashes of source and destination
files or the target files of symbolic links.

This is a supplement to the #11601 fix.

Signed-off-by: Yestin Sun <sunyi0804@gmail.com>
 2015-04-13 21:46:14 -07:00
Ahmet Alp Balkan
627d5ea83b names-generator: use local random instance 
Instead of seeding/polluting the global random instance,
creating a local `rand.Random` instance which provides the same
level of randomness.

Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
 2015-04-14 02:35:16 +00:00
Antonio Murdaca
d7a5d5b94c Refactor utils/utils, fixes #11923 
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
 2015-04-14 01:37:36 +02:00
Michael Crosby
b15e56b3ef Merge pull request #12044 from reteptilian/11721-remove-randomstring-3 
fixes 11721 replace stringutils.GenerateRandomString with stringid.GenerateRandomID
 2015-04-13 13:47:50 -07:00
Evan Hazlett
86168f3594 Merge pull request #12204 from yestin/11601-supplement-tests-part-1 
Improve test accuracy for pkg/chrootarchive (part 1)
 2015-04-13 16:14:18 -04:00
Michael Crosby
08ddc4edc5 Merge pull request #12342 from LK4D4/fix_vet_warn 
Fix vet warning
 2015-04-13 12:56:47 -07:00
Evan Hazlett
347857acba Merge pull request #12276 from estesp/10246-really-fix-arg-list 
Send archive options via pipe in chrootarchive
 2015-04-13 14:44:47 -04:00
Alexander Morozov
2f1072efe0 Fix vet warning 
pkg/archive/archive_test.go:496: arg changes for printf verb %s of wrong type: []archive.Change

Signed-off-by: Alexander Morozov <lk4d4@docker.com>
 2015-04-13 11:43:30 -07:00
Michael Crosby
a07cb3c4e6 Merge pull request #12297 from vdemeester/11603-pkg-archive-test-coverage 
Add test on archive.go (#11603)
 2015-04-13 10:54:21 -07:00
Deshi Xiao
3aad0991ea correct pkg/stdcopy NewStdWriter function comments 
pkg/stdcopy NewStdWriter function has wrong doc comment,
utils is not correct, it should be stdcopy

Signed-off-by: Deshi Xiao <xiaods@gmail.com>
 2015-04-13 17:21:27 +08:00
Phil Estes
70210e11f2 Send archive options via pipe in chrootarchive 
After finding our initial thinking on env. space versus arg list space
was wrong, we need to solve this by using a pipe between the caller and
child to marshall the (potentially very large) options array to the
archiver.

Docker-DCO-1.1-Signed-off-by: Phil Estes <estesp@linux.vnet.ibm.com> (github: estesp)
 2015-04-12 21:16:54 -04:00
Vincent Demeester
2fd964cc1d Add test on archive.go (#11603) 
- Trying to add or complete unit test to each ``func``
- Removing dead code (``escapeName``)

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
 2015-04-11 23:21:37 +02:00
Brendan Dixon
a15746e7cf Turned off Ctrl+C processing by Windows shell 
Signed-off-by: Brendan Dixon <brendand@microsoft.com>
 2015-04-10 15:43:35 -07:00
Tibor Vass
34332b8151 Merge pull request #12238 from brendandixon/win-cli/fixes 
Corrected int16 overflow and buffer sizes
 2015-04-10 13:36:23 -04:00
Richard Burnison
a513a8b8e0 Only use fallback to short IDs when obvious. 
As reported in #11294, the Docker daemon will execute contains it
shouldn't run in the event that a requested tag is present in an image's
ID. This leads to the wrong image being started up silently.

This change reduces the risk of such a collision by using the short ID
iff the actual revOrTag looks like a short ID (not that it necessarily
is).

Signed-off-by: Richard Burnison <rburnison@ebay.com>
 2015-04-10 13:20:44 -04:00
WiseTrem
fb7d4d784e Remove pools_nopool.go & build tag from pools.go 
Fix #11576

Signed-off-by: Gleb Shepelev <shepelyov.g@gmail.com>
 2015-04-10 02:32:55 +03:00
Brendan Dixon
06eb6c91a0 Corrected int16 overflow and buffer sizes 
Signed-off-by: Brendan Dixon <brendand@microsoft.com>
 2015-04-09 09:03:04 -07:00
Ahmet Alp Balkan
b4cd20a3ad namesgenerator: Proposing Kilby/Noyce 
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
 2015-04-09 04:11:06 -07:00
Yestin Sun
f16c4275d2 Improve test accuracy for pkg/chrootarchive (part 1) 
Check test correctness of untar by comparing destination with
source. For part one, it only compares the directories.

This is a supplement to the #11601 fix.

Signed-off-by: Yestin Sun <yestin.sun@polyera.com>
 2015-04-08 14:07:31 -07:00
Chris Stivers
4f5c0ee46d Proposing Seymour Cray 
Signed-off-by: Chris Stivers <chris@stivers.us>
 2015-04-08 13:17:22 -07:00
Jessie Frazelle
ecea125be8 Merge pull request #11909 from runcom/11908-refactor-utils-utils-daemon 
Refactor utils/utils_daemon
 2015-04-07 13:24:24 -07:00
Vincent Batts
53738aa452 Merge pull request #12033 from rhvgoyal/devmapper-cleanup 
Devmapper Graph Driver Misc cleanup
 2015-04-07 15:49:32 -04:00
Ahmet Alp Balkan
cdead8bb8f Swap width/height in GetWinsize and monitorTtySize 
Signed-off-by: Ahmet Alp Balkan <ahmetalpbalkan@gmail.com>
 2015-04-06 14:31:42 -07:00
Brendan Dixon
52a4467d1d Windows console fixes 
Corrected integer size passed to Windows
Corrected DisableEcho / SetRawTerminal to not modify state
Cleaned up and made routines more idiomatic
Corrected raw mode state bits
Removed duplicate IsTerminal
Corrected off-by-one error
Minor idiomatic change

Signed-off-by: Brendan Dixon <brendand@microsoft.com>
 2015-04-03 15:02:52 -07:00
Jessie Frazelle
165fb82759 Merge pull request #11886 from jamiehannaford/pkg-mnt-docs 
Document exported functions and consts in pkg/mount
 2015-04-03 21:28:11 +00:00
Antonio Murdaca
c38e2a81e4 Refactor ultis/utils_daemon, fixes #11908 
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
 2015-04-03 20:20:04 +02:00
Jamie Hannaford
bd4431719e Add documentation for exported functions and types 
Signed-off-by: Jamie Hannaford <jamie.hannaford@rackspace.com>
 2015-04-03 11:33:34 +02:00
Joey Gibson
11603e6535 Fix vet warnings in pkg/requestdecorator/requestdecorator_test.go #12041 
Signed-off-by: Joey Gibson <joey@joeygibson.com>
 2015-04-03 00:18:21 -04:00
Vivek Goyal
4401f264f9 devmapper: Use a pointer as argument to deferred function UdevWait() 
UdevWait() is deferred and takes uint cookie as an argument. As arguments
to deferred functions are calculated at the time of call, it is possible
that any update to cookie later by libdm are not taken into account when
UdevWait() is called. Hence use a pointer to uint as argument to UdevWait()
function.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
 2015-04-02 16:47:14 -04:00
Vivek Goyal
ee419fae0c devicemapper: Remove debug messages from RemoveDevice() 
devmapper graph driver retries device removal 1000 times in case of failure
and if this fills up console with 1000 messages (when daemon is running in
debug mode). So remove these debug messages.
 
Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
 2015-04-02 16:47:14 -04:00
Peter Esbensen
88e878b013 Fixes #11721 removed GenerateRandomString 
Signed-off-by: Peter Esbensen <pkesbensen@gmail.com>

gofmt

Signed-off-by: Peter Esbensen <pkesbensen@gmail.com>
 2015-04-02 08:07:52 -07:00
Peter Esbensen
ae440baf74 Added unit tests for stringutils GenerateRandomAlphaOnlyString and GenerateRandomAsciiString 
Signed-off-by: Peter Esbensen <pkesbensen@gmail.com>
 2015-04-02 07:12:47 -07:00
Vincent Batts
7bde17186d Merge pull request #11099 from iavael/bugfix/tar-symlinks 
Fixed handling hardlinks to symlinks in tar stream
 2015-04-01 18:34:00 -04:00
unclejack
d9fa79b73c pkg/broadcastwriter: reset after 4 KB w/o stream 
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
 2015-04-01 01:26:19 +03:00
Alexander Morozov
61ad4654f5 Skip heavy operations if there is no jsonlog writers 
Signed-off-by: Alexander Morozov <lk4d4@docker.com>
 2015-04-01 01:02:18 +03:00
unclejack
dd54d0419c pkg/broadcastwriter: use []byte to lower alloc 
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
 2015-04-01 01:02:18 +03:00
unclejack
90c3318cb6 pkg/jsonlog: add JSONLogBytes for low allocations 
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
 2015-04-01 01:02:18 +03:00
unclejack
d71cd58cbb pkg/broadcastwriter: add test w/ "" stream only 
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
 2015-04-01 01:02:18 +03:00
Michael Crosby
266eb178e1 Merge pull request #11952 from ankushagarwal/#11581 
Add some documentation to pkg/system
 2015-03-31 14:58:32 -07:00
Derek McGowan
4844f711fb Fix progress reader output on close 
Currently the progress reader won't close properly by not setting the close size.

fixes #11849

Signed-off-by: Derek McGowan <derek@mcgstyle.net> (github: dmcgowan)
 2015-03-31 13:17:25 -07:00
Ankush Agarwal
eea8abd59e Add some documentation to pkg/system 
Partially addresses #11581

Signed-off-by: Ankush Agarwal <ankushagarwal11@gmail.com>
 2015-03-31 12:00:33 -07:00
Jessica Frazelle
dce6f8ba76 fix basicAuth function not in go1.3.3 
Docker-DCO-1.1-Signed-off-by: Jessie Frazelle <jess@docker.com> (github: jfrazelle)

Docker-DCO-1.1-Signed-off-by: Jessie Frazelle <princess@docker.com> (github: jfrazelle)
 2015-03-30 15:28:34 -07:00
Michael Crosby
f7cc7614c9 Merge pull request #11893 from runcom/11892-refactor-utils-flags 
Refactor utils/flags.go
 2015-03-30 13:35:40 -07:00
Michael Crosby
d09a989733 Merge pull request #11900 from runcom/11899-refactor-utils-http 
Refactor utils/http.go
 2015-03-30 13:11:45 -07:00
Antonio Murdaca
068260af07 Refactor utils/http.go, fixes #11899 
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
 2015-03-30 17:59:57 +02:00
unclejack
d98dd3ecef pkg/broadcastwriter: avoid alloc w/ WriteString 
Signed-off-by: Cristian Staretu <cristian.staretu@gmail.com>
 2015-03-29 15:20:53 +03:00
Antonio Murdaca
8b84610fdc Refactor utils/flags.go, fixes #11892 
Signed-off-by: Antonio Murdaca <me@runcom.ninja>
 2015-03-29 03:22:46 +02:00
Michael Crosby
7923701584 Merge pull request #11853 from EricR/doc-PkgSysInfo 
Add some basic doc for SysInfo
 2015-03-27 14:52:20 -07:00
Michael Crosby
b1a14e04d6 Merge pull request #11871 from NinjaTrappeur/dry-run-test 
Fix vet warning in devicemapper.
 2015-03-27 14:48:55 -07:00
Félix Baylac-Jacqué
0159237dda Fix vet warning in devicemapper. 
Issue #11828

Signed-off-by: Félix Baylac-Jacqué <baylac.felix@gmail.com>
 2015-03-27 20:16:25 +01:00