Fix JS NPEs
This commit is contained in:
parent
7ec0ad45fc
commit
70cc895b95
4 changed files with 5 additions and 3 deletions
|
@ -3,7 +3,7 @@
|
|||
<span class="commit-circle"></span>
|
||||
</span>
|
||||
<span class="anchor" href="{{ getUrl(commitSha, urlTemplate) }}" target="_blank"
|
||||
is-only-text="!urlTemplate">
|
||||
is-only-text="!urlTemplate || !getUrl(commitSha, urlTemplate)">
|
||||
{{ commitSha.substring(0, 8) }}
|
||||
</span>
|
||||
</span>
|
||||
|
|
|
@ -3,13 +3,13 @@
|
|||
<!-- Branch -->
|
||||
<span ng-switch-when="heads">
|
||||
<i class="fa fa-code-fork" data-container="body" data-title="Branch" bs-tooltip></i>
|
||||
<span class="anchor" href="{{ getUrl(ref, branchTemplate, 'branch') }}" is-only-text="!branchTemplate" target="_blank">{{ getTitle(ref) }}</span>
|
||||
<span class="anchor" href="{{ getUrl(ref, branchTemplate, 'branch') }}" is-only-text="!branchTemplate || !getUrl(ref, branchTemplate, 'branch')" target="_blank">{{ getTitle(ref) }}</span>
|
||||
</span>
|
||||
|
||||
<!-- Tag -->
|
||||
<span ng-switch-when="tags">
|
||||
<i class="fa fa-tag" data-container="body" data-title="Tag" bs-tooltip></i>
|
||||
<span class="anchor" href="{{ getUrl(ref, tagTemplate, 'tag') }}" is-only-text="!tagTemplate" target="_blank">{{ getTitle(ref) }}</span>
|
||||
<span class="anchor" href="{{ getUrl(ref, tagTemplate, 'tag') }}" is-only-text="!tagTemplate || !getUrl(ref, tagTemplate, 'tag')" target="_blank">{{ getTitle(ref) }}</span>
|
||||
</span>
|
||||
</span>
|
||||
</span>
|
||||
|
|
|
@ -15,6 +15,7 @@ angular.module('quay').directive('sourceCommitLink', function () {
|
|||
},
|
||||
controller: function($scope, $element) {
|
||||
$scope.getUrl = function(sha, template) {
|
||||
if (!template) { return ''; }
|
||||
return template.replace('{sha}', sha);
|
||||
};
|
||||
}
|
||||
|
|
|
@ -33,6 +33,7 @@ angular.module('quay').directive('sourceRefLink', function () {
|
|||
};
|
||||
|
||||
$scope.getUrl = function(ref, template, kind) {
|
||||
if (!template) { return ''; }
|
||||
return template.replace('{' + kind + '}', $scope.getTitle(ref));
|
||||
};
|
||||
}
|
||||
|
|
Reference in a new issue