Small JS fixes for the PR
This commit is contained in:
parent
f8deb85751
commit
c9812864be
3 changed files with 4 additions and 5 deletions
|
@ -5,7 +5,7 @@ angular.module('quay').factory('ExternalLoginService', ['Features', 'Config', 'A
|
||||||
function(Features, Config, ApiService) {
|
function(Features, Config, ApiService) {
|
||||||
var externalLoginService = {};
|
var externalLoginService = {};
|
||||||
|
|
||||||
externalLoginService.EXTERNAL_LOGINS = window.__external_login;
|
externalLoginService.EXTERNAL_LOGINS = window.__external_login || [];
|
||||||
|
|
||||||
externalLoginService.getLoginUrl = function(loginService, action, callback) {
|
externalLoginService.getLoginUrl = function(loginService, action, callback) {
|
||||||
var errorDisplay = ApiService.errorDisplay('Could not load external login service ' +
|
var errorDisplay = ApiService.errorDisplay('Could not load external login service ' +
|
||||||
|
@ -31,8 +31,7 @@ angular.module('quay').factory('ExternalLoginService', ['Features', 'Config', 'A
|
||||||
|
|
||||||
externalLoginService.getSingleSigninUrl = function(callback) {
|
externalLoginService.getSingleSigninUrl = function(callback) {
|
||||||
if (!externalLoginService.hasSingleSignin()) {
|
if (!externalLoginService.hasSingleSignin()) {
|
||||||
callback(null);
|
return callback(null);
|
||||||
return;
|
|
||||||
}
|
}
|
||||||
|
|
||||||
// If there is a single external login service and direct login is disabled,
|
// If there is a single external login service and direct login is disabled,
|
||||||
|
|
Reference in a new issue