Commit graph

8903 commits

Author SHA1 Message Date
Joseph Schorr
e66a3a98c4 CHANGELOG for v2.9.2 2018-05-16 10:36:30 -04:00
josephschorr
42d749a634
Merge pull request #3084 from quay/fix-authorize-url
Fix authorize URL for Gitlab OAuth
2018-05-15 18:31:48 -04:00
Joseph Schorr
421f59e1ff Fix authorize URL for Gitlab OAuth
We now add the ? on the server side, so it should be removed on the client side
2018-05-15 18:18:48 -04:00
josephschorr
fda8d65942
Merge pull request #3083 from quay/notification-robots
Notifications can target robots, but the model did not reflect that
2018-05-15 16:22:02 -04:00
Joseph Schorr
f5fafc480f Notifications can target robots, but the model did not reflect that
This fixes a breakage when deleting robots that have notifications targeting them.
2018-05-15 16:19:46 -04:00
josephschorr
93165a7273
Merge pull request #3081 from quay/fix-oidc-redirect
Fix bug with missing & in authorization URL for OIDC
2018-05-15 16:08:50 -04:00
josephschorr
0c3b6d5b1a
Merge pull request #3082 from quay/migrate-logs-caching
Add some additional caching and logs to the robot cleanup migration
2018-05-15 15:35:59 -04:00
Joseph Schorr
ad1da86986 Add some additional caching and logs to the robot cleanup migration 2018-05-15 15:34:54 -04:00
Joseph Schorr
22a39c3007 Fix bug with missing & in authorization URL for OIDC
Also adds testing to ensure we don't break this again
2018-05-15 14:52:00 -04:00
josephschorr
58612955d6
Merge pull request #3079 from quay/joseph.schorr/QUAY-927/robots-limit
Limit robots displayed in entity search
2018-05-15 13:59:48 -04:00
josephschorr
6780a1f06b
Merge pull request #3077 from quay/joseph.schorr/QUAY-931/log-slowdown
Logs slowdown fixes
2018-05-15 13:28:05 -04:00
Joseph Schorr
5c50161d85 Limit robots displayed in entity search
Before, we'd load *all* the robots, which can be a huge issue in namespaces with a large number of robots. Now, we only load the top-20 robots (as per recency in login), and we also limit the information returned to the entity search to save some bandwidth.

Fixes https://jira.coreos.com/browse/QUAY-927
2018-05-15 11:00:57 -04:00
josephschorr
4c0ab81ac8
Merge pull request #3080 from quay/joseph.schorr/QUAY-936/delete-async-ui
Filter out deleted users and organizations from the superuser list
2018-05-15 10:58:45 -04:00
Joseph Schorr
b98c65b3a3 Filter out deleted users and organizations from the superuser list
Superusers were getting confused because the users/orgs were being disabled and renamed, but still appeared in the list until they were GCed by the background worker. Now we just hide them.

Fixes https://jira.coreos.com/browse/QUAY-936
2018-05-15 10:42:41 -04:00
josephschorr
7878435805
Merge pull request #3078 from quay/joseph.schorr/QUAY-855/trigger-history
Fix display of triggered builds if their trigger has been deleted
2018-05-14 15:40:08 -04:00
Joseph Schorr
99c986df6c Fix display of triggered builds if their trigger has been deleted
Before this change, if a build was triggered by a build trigger that was subsequently deleted, we'd display "Manually triggered" for the build in the UI, even though we have sufficient metadata to show *nearly the same* normal build information. After this change, if we have said trigger metadata, we still display as much as we can.

Fixes https://jira.coreos.com/browse/QUAY-855
2018-05-14 15:30:52 -04:00
Joseph Schorr
e3248bde47 Small fixes to make loading of logs faster
Removes filtering of log types where not necessary, removes filtering based on namespace when filtering based on repository (superfluous check that was causing issues in MySQL preventing the use of the correct index) and fix some other small issues around the API

Fixes https://jira.coreos.com/browse/QUAY-931
2018-05-14 11:41:49 -04:00
Joseph Schorr
29058201e5 Fix bug in modelutil pagination that caused us to load far more results than necessary
Also adds tests for the modelutil pagination
2018-05-14 11:40:31 -04:00
josephschorr
e5b86d4763
Merge pull request #3076 from quay/joseph.schorr/QUAY-937/star-search
Fix MySQL bug in full text search
2018-05-14 10:10:54 -04:00
Joseph Schorr
49699fe251 Fix MySQL bug in full text search
Fixes https://jira.coreos.com/browse/QUAY-937
2018-05-14 08:41:40 -04:00
josephschorr
7345ff855c
Merge pull request #3071 from quay/joseph.schorr/QUAY-932/namespace-robot-deletion
Fix issue where we didn't delete robots immediately under a namespace
2018-05-11 00:27:17 +03:00
josephschorr
44db41d66e
Merge pull request #3074 from quay/cert-upload-fix
Further fixes to the Kubernetes config provider, and a new set of proper unit tests
2018-05-11 00:26:11 +03:00
josephschorr
5cccd45cd7
Merge pull request #3073 from quay/joseph.schorr/QUAY-935/robot-create-bug
Fix error displayed if a description was not entered for creating a robot
2018-05-10 18:06:08 +03:00
Joseph Schorr
2ae69dc651 Further fixes to the Kubernetes config provider, and a new set of proper unit tests 2018-05-10 16:44:18 +03:00
Joseph Schorr
e7ee235b31 Fix error displayed if a description was not entered for creating a robot
We were sending a `null` description, which the schema does not allow

Fixes https://jira.coreos.com/browse/QUAY-935
2018-05-10 12:42:33 +03:00
josephschorr
babb7bb803
Merge pull request #3072 from quay/joseph.schorr/QUAY-933/dockerfile-path
Fix lookup of Dockerfile in archives
2018-05-09 21:04:53 +03:00
Joseph Schorr
134433c715 Fix lookup of Dockerfile in archives
Fixes https://jira.coreos.com/browse/QUAY-933
2018-05-09 21:04:37 +03:00
Joseph Schorr
f06eec8a35 Fix issue where we didn't delete robots immediately under a namespace
This could result in "hanging" robot accounts, although that would only leak the names of said accounts. Now we delete them immediately AND we proactively delete them before replacing the namespace (just to be sure)
2018-05-09 17:53:30 +03:00
Sam Chow
bd1f3e6bb8
Merge pull request #3068 from quay/browser-notifications
Browser notifications setting
2018-05-08 14:49:28 -04:00
Sam Chow
5e80e5423c add button class 2018-05-08 12:02:52 -04:00
Sam Chow
3a25a7c9e6 remove useless props in button 2018-05-08 10:39:10 -04:00
josephschorr
7722721396
Merge pull request #3064 from quay/joseph.schorr/QUAY-928/fix-worker-count
Fix worker count to  use CPU affinity correctly and be properly bounded
2018-05-07 20:45:26 +03:00
josephschorr
de36b36f9a
Merge pull request #3051 from quay/joseph.schorr/QUAY-911/fix-kub-provider
Fix Kubernetes config provider for recent changes in Kub API
2018-05-07 20:45:09 +03:00
Sam Chow
7b28f745f7 Update naming of optional parameter 2018-05-07 12:47:29 -04:00
Sam Chow
84ad1d83e1 Add support for Enterprise logos in notifications 2018-05-07 11:11:33 -04:00
Sam Chow
6fe579119b Use cookie service and small cleanup for pr 2018-05-04 17:15:00 -04:00
Sam Chow
2d3583fb44 Add button to enable desktop notifications 2018-05-04 16:24:56 -04:00
josephschorr
f0ec26ea54
Merge pull request #3066 from quay/ipresolver-bug
Missing parens on IP resolver lookup
2018-05-04 02:17:53 +03:00
Joseph Schorr
942f526016 Missing parens on IP resolver lookup
Also adds a generic catch in case this happens again; we should *never* fail
2018-05-04 02:14:26 +03:00
josephschorr
bf943e7713
Merge pull request #3065 from quay/joseph.schorr/QUAY-929/upgrade-recaptcha
Fix recaptcha after recent Google changes
2018-05-03 18:49:01 +03:00
Joseph Schorr
00b0e831a8 Fix recaptcha after recent Google changes
Fixes https://jira.coreos.com/browse/QUAY-929
2018-05-03 18:45:55 +03:00
Joseph Schorr
b26a131085 Fix worker count to use CPU affinity correctly and be properly bounded
We were using the `cpu_count`, which doesn't respect container affinity. Now, we use `cpu_affinity` and also bound to make sure we don't start a million workers

Fixes https://jira.coreos.com/browse/QUAY-928
2018-05-03 11:57:20 +03:00
Sam Chow
e80c56e441
Merge pull request #3062 from quay/long-robots
Add some css for long name edge case of robots
2018-05-02 13:58:13 -04:00
Sam Chow
49ce38ea04 Add styling for overflowing table & dropdown robot
Bound modal box by container, remove !important

The important was introduced as a fix to
https://jira.coreos.com/browse/QUAY-881
However, after removal it does not seem to be necessary (Cannot
reproduce with the !important gone).

Adds bounding for the modal boxes & title

Joins the username/password for robot in box
2018-05-02 13:57:20 -04:00
Joseph Schorr
8c1b0e673c Implement the remaining registry tests in the new py.test format 2018-05-01 13:28:24 +03:00
Joseph Schorr
77adf9dd77 Fix bug which allowed for implicit library namespace access via the V1 registry protocol when the feature flag was off
Now we raise a 400 as expected
2018-05-01 13:28:24 +03:00
Joseph Schorr
178c8e7cb0 Fix bug in in-memory data cache
Previously, if we didn't find a key, we'd empty the entire cache, making it essentially a single-key cache. We skip clearing now, although this does mean we won't GC expired entries (not a problem for tests, though)
2018-05-01 13:28:24 +03:00
Joseph Schorr
23c19bcbc1 Implement support for registry integration tests via py.test
This change implements support for registry integration tests using the new py.test-based live server test fixture. We can now parametrize the protocols we use (in prep for V2_2), and it makes the code *much* cleaner and less hacky.

Note that moving the vast majority of the tests over from the existing impl will come as a followup PR
2018-05-01 13:28:24 +03:00
Joseph Schorr
85496b8195 Translate LiveServerTestCase into a py.test-compatible liveserver fixture
This allow us to super-easily instantiate a live, running Flask server with the test app, as well as interact with it, without any of the crazy boilerplate we previously used
2018-05-01 13:28:24 +03:00
Sam Chow
c8824aeb58
Merge pull request #3061 from quay/fix-empty-creds
Default to the first credential tab if no cookie saved
2018-04-26 10:26:23 -07:00