Stephen Day
57a6854ae0
Merge pull request #281 from tcnghia/patch-1
...
Update api.md
2015-03-20 16:51:09 -07:00
Nghia Tran
5e06d6500c
Update api.md
...
It seems a few places "download" instead of "upload".
Signed-off-by: Nghia Tran <tcnghia@gmail.com>
2015-03-20 07:56:30 -07:00
Stephen Day
06fcf053e7
Merge pull request #275 from docker/stevvooe-patch-2
...
digest: remove unnecessary error pointer formats in test
2015-03-18 19:25:35 -07:00
Stephen Day
2ced84f31d
Remove unnecessary error pointer formats in test
...
The linter was complaining about these and they are quite unnecessary.
2015-03-18 19:02:32 -07:00
Olivier Gambier
d957768537
Merge pull request #274 from stevvooe/tarsum-verification-deadlock
...
digest: correctly close pipe after error in tarsum verification
2015-03-18 18:38:31 -07:00
Stephen J Day
8c254edb9a
Correctly close pipe after error in tarsum verification
...
This addresses a subtle deadlock where an error during a copy prevented pipe
closure to propagate correctly. By closing down the read end of the pipe rather
than the write end, the waiting writer is properly signaled. A nice side-effect
of this change is that errors encountered by io.Copy are no propagated to the
verifier's Write method.
A test to ensure validation errors for unsupported digest types has been added,
as well.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-03-18 18:26:09 -07:00
Olivier Gambier
53e1b27a76
Merge pull request #268 from docker/stevvooe-patch-2
...
Update Sprint label link from Ready
2015-03-17 21:29:12 -07:00
Stephen Day
7e7b6109dc
Merge pull request #236 from endophage/config
...
Adding docs for full suite of configuration options
2015-03-17 21:12:19 -07:00
Stephen Day
1f229923d3
Update Sprint label link from Ready
2015-03-17 18:56:56 -07:00
Stephen Day
ac550484be
Merge pull request #226 from stevvooe/json-canonicalization
...
doc/spec: canonicalized JSON format for distribution APIs
2015-03-16 13:21:39 -07:00
Stephen J Day
e891939ebc
spec: Canonicalized JSON Format for Distribution APIs
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-03-16 13:03:02 -07:00
Stephen Day
47cf298bd0
Merge pull request #261 from jlhawn/url_for_method
...
Refactor Layer interface to return a Handler
2015-03-13 17:27:42 -07:00
Olivier Gambier
40ec1222a9
Merge pull request #259 from stevvooe/validate-var-prefixes
...
context: validate prefix lookups for WithRequest/WithResponse contexts
2015-03-13 16:54:40 -07:00
Josh Hawn
db5689aa86
Refactor Layer interface to return a Handler
...
... Rather than ServeHTTP directly.
Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
2015-03-12 21:59:07 -07:00
Stephen J Day
77dc35fbd6
Validate prefix lookups for WithRequest/WithResponse contexts
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-03-12 19:09:26 -07:00
Stephen Day
37447b3abd
Merge pull request #258 from jlhawn/url_for_method
...
Insert request method option storage driver URLFor
2015-03-12 17:16:54 -07:00
Josh Hawn
e062e66ee1
Insert request method option storage driver URLFor
...
Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
2015-03-12 17:06:40 -07:00
Stephen Day
70560cceaf
Merge pull request #256 from ncdc/master
...
Send WWW-Authenticate header for silly auth
2015-03-11 19:01:23 -07:00
Andy Goldstein
4491e755b8
Send WWW-Authenticate header for silly auth
...
Signed-off-by: Andy Goldstein <agoldste@redhat.com>
2015-03-11 15:20:15 -04:00
Stephen Day
8aacddd095
Merge pull request #244 from endophage/cloudfront_refactor
...
registry/middleware, registry/storage, configuration: refactoring cloudfront + generic middlewares
2015-03-11 12:10:49 -07:00
David Lawrence
3853e66f4b
don't panic during a request when configuring repository middleware. Return a 500 with an appropriate error
...
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-03-11 08:59:02 -07:00
Andy Goldstein
b5a63d75ea
Fix Godoc typos
...
Signed-off-by: Andy Goldstein <agoldste@redhat.com>
2015-03-11 08:56:29 -07:00
David Lawrence
c858a4ba89
Final polish to cloudfront and larger middleware refactor
...
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-03-11 08:56:29 -07:00
Andy Goldstein
a20abfbf3c
Middleware!
...
Convert middleware in the config to be a map of type->[]Middleware
Add support for registry & repository middleware.
Some naming updates as well.
Signed-off-by: Andy Goldstein <agoldste@redhat.com>
2015-03-11 08:56:28 -07:00
David Lawrence
4acda57e05
Refactoring cloudfactory layer handler into a more generic storage
...
middleware concept.
This also breaks the dependency the storage package had on goamz
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-03-11 08:56:28 -07:00
Stephen Day
0c130dff5b
Merge pull request #255 from xiekeyang/digest-refactoring
...
supplement of digest refactoring
2015-03-10 23:56:00 -07:00
xiekeyang
04f8bfbede
supplement of digest refactoring
2015-03-11 14:13:29 +08:00
Derek McGowan
fb81ecb0fa
Merge pull request #251 from jlhawn/digest_pkg_cleanup
...
digest: Minor refactoring
2015-03-10 19:17:37 -07:00
Josh Hawn
87959abe8f
digest: Minor refactoring
...
Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
2015-03-10 16:44:19 -07:00
Stephen Day
cbdc3621cf
Merge pull request #247 from endophage/coverage
...
minor refactor + tests for app.go just to improve test coverage.
2015-03-10 13:16:27 -07:00
David Lawrence
490e90d299
adding full suite of configuration options
...
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-03-10 12:45:36 -07:00
David Lawrence
6dcec265a0
minor refactor + tests for app.go just to improve test coverage.
...
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-03-09 16:31:30 -07:00
Stephen Day
ddde6b4363
Merge pull request #242 from ncdc/remove-max-component-length
...
Remove max repository component length restriction
2015-03-06 18:24:05 -08:00
Andy Goldstein
e1e724860f
Remove max repository component length restriction
...
Fixes #241
Signed-off-by: Andy Goldstein <agoldste@redhat.com>
2015-03-06 19:55:33 -05:00
Stephen Day
f0ccdd448f
Merge pull request #239 from jlhawn/event_target_update
...
notifications: update notification event Target fields
2015-03-06 16:45:06 -08:00
Stephen Day
e3dd701004
Merge pull request #238 from endophage/canonical_sha256
...
digest, registry/storage, registry/handlers: switch to SHA256 as canonical digest
2015-03-06 15:27:14 -08:00
David Lawrence
b777e389b9
fixing up tests to work with for non-tarsum future
...
Signed-off-by: David Lawrence <david.lawrence@docker.com> (github: endophage)
2015-03-06 14:54:23 -08:00
Stephen Day
81a03041d4
Merge pull request #243 from stevvooe/storagedriver-docs
...
doc: move storage driver readmes into docs
2015-03-06 11:25:42 -08:00
Josh Hawn
d3bc4c4b38
Switch to SHA256 as canonical digest
...
Also support client digests linking to canonical digest.
2015-03-06 09:49:05 -08:00
Josh Hawn
a877811c0b
Update notification event Target fields
...
Docker-DCO-1.1-Signed-off-by: Josh Hawn <josh.hawn@docker.com> (github: jlhawn)
2015-03-05 18:01:50 -08:00
Stephen Day
b4cc5e3ecc
Merge pull request #211 from stevvooe/immutable-manifest-references
...
doc/spec, registry: immutable manifest reference support
2015-03-05 17:38:45 -08:00
Stephen J Day
52865bb128
doc/storagedrivers: update storage driver documentation links
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-03-05 17:30:40 -08:00
Stephen J Day
41b1e22f97
doc: move storage driver readmes into docs
...
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-03-05 17:23:33 -08:00
Stephen J Day
40273b1d36
Implement immutable manifest reference support
...
This changeset implements immutable manifest references via the HTTP API. Most
of the changes follow from modifications to ManifestService. Once updates were
made across the repo to implement these changes, the http handlers were change
accordingly. The new methods on ManifestService will be broken out into a
tagging service in a later PR.
Unfortunately, due to complexities around managing the manifest tag index in an
eventually consistent manner, direct deletes of manifests have been disabled.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-03-04 21:40:55 -08:00
Stephen J Day
f536633ca8
spec: fetch manifests by tag or digest
...
Manifests are now fetched by a field called "reference", which may be a tag or
a digest. When using digests to reference a manifest, the data is immutable.
The routes and specification have been updated to allow this.
There are a few caveats to this approach:
1. It may be problematic to rely on data format to differentiate between a tag
and a digest. Currently, they are disjoint but there may modifications on
either side that break this guarantee.
2. The caching characteristics of returned content are very different for
digest versus tag-based references. Digest urls can be cached forever while tag
urls cannot.
Both of these are minimal caveats that we can live with in the future.
Signed-off-by: Stephen J Day <stephen.day@docker.com>
2015-03-04 21:39:36 -08:00
Stephen Day
0418788239
Merge pull request #233 from xiekeyang/master
...
digest: func Validate in digest doesn't filter no-hex data
2015-03-04 21:30:34 -08:00
Stephen Day
f65cba0c38
Merge pull request #240 from xiekeyang/patch222
...
doc/spec: patch #222 to api.md.tmpl
2015-03-04 21:24:40 -08:00
xiekeyang
4f9a6782bb
patch #222 to api.md.tmpl
2015-03-05 13:12:27 +08:00
xiekeyang
7a01d1fae2
Merge branch 'master' of https://github.com/xiekeyang/distribution
2015-03-05 10:40:53 +08:00
xiekeyang
8081a13cdf
:func Validate in digest doesn't filter no-hex data
2015-03-05 10:36:48 +08:00