vbatts/registry
1
0
Fork 0
Code Issues Pull requests Releases Wiki Activity
3014 commits 18 branches 0 tags 22 MiB
Commit graph

3014 commits

This branch
This branch
All branches
Author SHA1 Message Date
João Pereira
cc4627fc6e
Merge pull request #2460 from robermorales/patch-1 
Improve error message in case invalid env var found
 2021-11-25 13:36:00 +00:00
Rober Morales-Chaparro
4f173262e4 patch-1 - adding more info to the error message 
Signed-off-by: Rober Morales-Chaparro <rober.morales@rstor.io>
Signed-off-by: Rober Morales-Chaparro <rober.morales@ebury.com>
 2021-11-24 15:55:22 +01:00
Rober Morales-Chaparro
579107cf2e Improve error message in case invalid env var found 
If you set an env var with non-yaml content but accidentally collides with a possible configuration env var,...

The current error is

```configuration error: error parsing /etc/docker/registry/config.yml: yaml: unmarshal errors:
  line 1: cannot unmarshal !!str `tcp://1...` into configuration.Parameters```

With this change we can see at least which is the problematic env var.

Some orchestrators such as docker-compose set env vars on top on user env vars, so debugging can be tricky if you are not passing vars, and the error is pointing you to a problably valid config file.

Signed-off-by: Rober Morales-Chaparro <rober@rstor.io>
Signed-off-by: Rober Morales-Chaparro <rober.morales@ebury.com>
 2021-11-24 15:55:22 +01:00
Milos Gajdos
41a0452eea
Merge pull request from GHSA-qq97-vm5h-rrhg 
manifest: validate document type before unmarshal
 2021-11-23 19:16:40 +00:00
Milos Gajdos
a29a3c99a6
Merge pull request #3534 from thaJeztah/bump_oci_specs 2021-11-18 08:35:04 +00:00
João Pereira
2ccf55b8c4
Merge pull request #3529 from wy65701436/fix-g404 2021-11-18 08:15:21 +00:00
Sebastiaan van Stijn
6fbba6a99b
go.mod: github.com/opencontainers/image-spec v1.0.2 
- Bring mediaType out of reserved status
- specs-go: adding mediaType to the index and manifest structures

full diff: https://github.com/opencontainers/image-spec/compare/v1.0.1...v1.0.2

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2021-11-17 22:25:16 +01:00
Wang Yan
f637481c67 fix go check issues 
1, Fix GoSec G404: Use of weak random number generator (math/rand instead of crypto/rand)
2, Fix Static check: ST1019: package "github.com/sirupsen/logrus" is being imported more than once

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-11-15 17:31:33 +08:00
Samuel Karp
b59a6f8279
manifest: validate document type before unmarshal 
Signed-off-by: Samuel Karp <skarp@amazon.com>
 2021-11-05 10:21:17 -07:00
Milos Gajdos
6248a88d03
Merge pull request #3515 from wyckster/patch-1 
Fixed typo in error message
 2021-11-01 14:28:38 +00:00
Chad Faragher
f619db7336 Fixed typo in error message 
The wording of the error message had a typo (missing the word "not") that gave it the opposite meaning from the intended meaning.

Signed-off-by: Chad Faragher <wyckster@hotmail.com>
 2021-10-28 14:50:04 -04:00
Wang Yan
b106d89db3
Merge pull request #3518 from wy65701436/go17 
bump up golang v1.17
 2021-10-28 11:15:35 +08:00
Wang Yan
3f4c558dac bump up golang v1.17 
Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-10-27 15:51:30 +08:00
Milos Gajdos
1563384b69
Merge pull request #3480 from CollinShoop/optimize-s3-walk 
Optimize storagedriver/s3 Walk (up to ~500x) + small bugfix
 2021-09-26 10:24:39 +01:00
Milos Gajdos
a60a3f69eb
Merge pull request #3411 from dmage/cloudfront-update-frequency 
updatefrequency should not be saved into duration
 2021-09-21 15:01:21 +01:00
Oleg Bulatov
f5709b285a updatefrequency should not be saved into duration 
When updatefrequency is set and is a string, its value should be saved
into updateFrequency, and it shouldn't override duration.

Signed-off-by: Oleg Bulatov <oleg@bulatov.me>
 2021-09-21 11:12:34 +02:00
Milos Gajdos
677772e08d
Merge pull request #3138 from devigned/autorest-update 
chore: update azure go-autorest dependencies
 2021-08-26 09:13:26 +01:00
David Justice
3e68d47da6
chore: update azure go-autorest dependencies 
Signed-off-by: David Justice <david@devigned.com>
 2021-08-25 13:43:18 -04:00
Wang Yan
eda4e7152a
Merge pull request #3488 from aviral26/docs 
docs: update release-tool link
 2021-08-24 17:27:07 +08:00
Aviral Takkar
b07018ff3d
docs: update release-tool link 
Signed-off-by: Aviral Takkar <aviral26@users.noreply.github.com>
 2021-08-23 00:01:41 -07:00
Milos Gajdos
1cdeff259b
Merge pull request #3487 from justincormack/must 
Change should to must in v2 spec
 2021-08-20 14:00:19 +01:00
Justin Cormack
1660df4b60
Change should to must in v2 spec 
We found some examples of manifests with URLs specififed that did
not provide a digest or size. This breaks the security model by allowing
the content to change, as it no longer provides a Merkle tree. This
was not intended, so explicitly disallow by tightening wording.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
 2021-08-20 12:14:42 +01:00
Milos Gajdos
ecdf4b7e43
Merge pull request #3474 from thaJeztah/update_go_116 
Update to go 1.16, and run CI on 1.15.x and 1.16.x
 2021-08-19 08:59:46 +01:00
Collin Shoop
cf81f67a16 storagedriver/s3: Optimized Walk implementation + bugfix 
Optimized S3 Walk impl by no longer listing files recursively. Overall gives a huge performance increase both in terms of runtime and S3 calls (up to ~500x).

Fixed a bug in WalkFallback where ErrSkipDir for was not handled as documented for non-directory.

Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
 2021-08-16 16:07:25 -04:00
Milos Gajdos
0256de4688
Merge pull request #3479 from CollinShoop/updated-s3-delete-to-handle-edge-cases 
Updated s3 delete to no longer noop under a rare edge case
 2021-08-16 15:40:00 +01:00
Collin Shoop
9e873f31ec storagedriver/s3: Adding back missing import. 
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
 2021-08-12 11:56:13 -04:00
Collin Shoop
e625bc7160 storagedriver/s3: Removed temporary S3 test 
(cherry picked from commit ce80e98cea1d15aa2a2ab931c8b9a1161fc6e218)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
 2021-08-12 11:56:13 -04:00
Collin Shoop
dc5b77101d storagedriver/s3: Cleaning up tests 
(cherry picked from commit 483ba26165ca66bcf18a1eaadf41ebe4d3bd5f85)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
 2021-08-12 11:56:13 -04:00
Collin Shoop
6da7217b99 storagedriver/s3: Optimize s3 Delete test cleanup. 
(cherry picked from commit e4af4dc3a6da6da724e7cff18cf5b6da6ef2a3fd)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
 2021-08-12 11:56:13 -04:00
Collin Shoop
03f9eb3a18 storagedriver/s3: Fixed a Delete noop edgecase 
Delete was not working when the subpath immediately followed the given path started with an ascii lower than "/" such as dash "-" and underscore "_" and requests no files to be deleted.

(cherry picked from commit 5d8fa0ce94b68cce70237805db92cdd8d40de282)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
 2021-08-12 11:56:13 -04:00
Collin Shoop
05a258e711 storagedriver/s3: Added Delete tests to s3_test 
(cherry picked from commit 1e3b6b67a8e6d7f01307518370f0731212935d05)
Signed-off-by: Collin Shoop <cshoop@digitalocean.com>
 2021-08-12 10:57:24 -04:00
Sebastiaan van Stijn
a07b54eb68
Update to go 1.16, and run CI on 1.15.x and 1.16.x 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2021-08-10 12:12:28 +02:00
Justin Cormack
38ab4c606e
Merge pull request #3441 from justincormack/sargun 
Propose Sargun as a maintainer
 2021-08-04 11:49:54 +01:00
João Pereira
01f589cf87
Merge pull request #3450 from wy65701436/fixes-3446 
use memory as the cache in test
 2021-07-02 13:29:54 +01:00
Wang Yan
0f50e0388d use memory as the cache in test 
Fixes #3446

Signed-off-by: Wang Yan <wangyan@vmware.com>
 2021-07-02 19:41:47 +08:00
João Pereira
93ecc3f919
Merge pull request #3442 from milosgajdos/fix-readme-conformance 2021-06-30 18:57:33 +01:00
Milos Gajdos
351b260774
Fix OCI conformance workflow report and README badge 
Signed-off-by: Milos Gajdos <milosgajdos83@gmail.com>
 2021-06-30 15:37:18 +01:00
Wang Yan
3fa4e42634
Merge pull request #3448 from milosgajdos/action-job-names 
Make GH workflows job names unique
 2021-06-30 22:03:43 +08:00
João Pereira
26b0a79fca
Merge pull request #3444 from sudo-bmitch/pr-api-http-status 2021-06-30 12:59:49 +01:00
Milos Gajdos
21ffbdbedd
Change GH workflows job names 
Make workflow jobs unique soe we can manage which ones are required to
pass the build.

Signed-off-by: Milos Gajdos <milosgajdos83@gmail.com>
 2021-06-30 08:20:39 +01:00
Brandon Mitchell
9c7967a32d Update PUT and PATCH APIs 
Signed-off-by: Brandon Mitchell <git@bmitch.net>
 2021-06-29 14:16:33 -04:00
Brandon Mitchell
3f09e31ea6 Fixing http status for PUT/PATCH APIs 
Signed-off-by: Brandon Mitchell <git@bmitch.net>
 2021-06-28 15:23:04 -04:00
Milos Gajdos
ad8f5caba0
Merge pull request #3382 from wy65701436/oci-conformance 
OCI: add conformance test github action
 2021-06-27 15:56:49 +01:00
Wang Yan
263da70ea6
Merge pull request #3410 from khaosdoctor/patch-1 
Fix html not rendering markdown link properly
 2021-06-27 17:44:10 +08:00
Justin Cormack
d3cd41aa84
Propose Sargun as a maintainer 
Sargun is a large user of Distribution at Netflix, and is interested
in helping maintain, especially around storage drivers.

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
 2021-06-24 20:22:26 +01:00
João Pereira
a1e30cca34
Merge pull request #3435 from yecril71pl/patch-1 
Fix typo in README
 2021-06-18 09:33:31 +01:00
Christopher Yeleighton
7244cd3bdf typo: a client implementation 
Signed-off-by: Christopher Yeleighton <ne01026@shark.2a.pl>
 2021-06-17 23:57:30 +02:00
João Pereira
6d75bd043a
Merge pull request #3425 from lostsquirrel/patch-1 
Fix the /v2/_catalog n parameter description
 2021-06-17 11:10:14 +01:00
lisong
24e1ea0b93 Merge branch 'patch-1' of github.com:lostsquirrel/distribution into patch-1 2021-06-17 17:34:37 +08:00
lostsquirrel
6d9a3aba04 fix the /v2/_catalog n parameter description 
If `n` is not present only 100 entries returned

Signed-off-by: lisong <lisong@cdsunrise.net>
 2021-06-17 17:33:55 +08:00