Michael S. Tsirkin 2145ab513e virtio_pci: use irq to detect interrupt support ... commit 71491c54ea ("virtio_pci: don't try to use intxif pin is zero") breaks virtio_pci on powerpc, when running as a qemu guest. vp_find_vqs() bails out because pci_dev->pin == 0. But pci_dev->irq is populated correctly, so vp_find_vqs_intx() would succeed if we called it - which is what the code used to do. This seems to happen because pci_dev->pin is not populated in pci_assign_irq(). A PCI core bug? Maybe. However Linus said: I really think that that is basically the only time you should use that 'pci_dev->pin' thing: it basically exists not for "does this device have an IRQ", but for "what is the routing of this irq on this device". and The correct way to check for "no irq" doesn't use NO_IRQ at all, it just does if (dev->irq) ... so let's just check irq and be done with it. Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Reported-by: Michael Ellerman <mpe@ellerman.id.au> Fixes: 71491c54ea ("virtio_pci: don't try to use intxif pin is zero") Cc: "Angus Chen" <angus.chen@jaguarmicro.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Tested-by: Michael Ellerman <mpe@ellerman.id.au> Acked-by: Jason Wang <jasowang@redhat.com> Message-Id: <20221012220312.308522-1-mst@redhat.com>		2022-10-13 09:33:03 -04:00
..
accessibility
acpi	More ACPI updates for 6.1-rc1	2022-10-10 13:28:06 -07:00
amba
android	Scheduler changes for v6.1:	2022-10-10 09:10:28 -07:00
ata	ata changes for 6.1-rc1	2022-10-07 10:48:49 -07:00
atm
auxdisplay
base	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
bcma
block	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
bluetooth
bus	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
cdrom
char	Fix a bunch of little problems in IPMI	2022-10-11 10:42:25 -07:00
clk	Here's the main clk pull request for this merge window. We have some	2022-10-08 10:06:48 -07:00
clocksource	A boring time, timekeeping, timers update:	2022-10-10 10:16:00 -07:00
comedi
connector
counter	gpio updates for v6.1-rc1	2022-10-08 09:46:29 -07:00
cpufreq	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
cpuidle	RISC-V Patches for the 6.1 Merge Window, Part 1	2022-10-09 13:24:01 -07:00
crypto	This update includes the following changes:	2022-10-10 13:04:25 -07:00
cxl
dax	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
dca
devfreq
dio
dma	dmaengine updates for v6.1-rc1	2022-10-07 15:56:34 -07:00
dma-buf	whack-a-mole: cropped up open-coded file_inode() uses...	2022-10-06 17:22:11 -07:00
edac	Merge branches 'edac-drivers' and 'edac-misc' into edac-updates-for-v6.1	2022-10-04 10:00:25 +02:00
eisa
extcon	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
firewire
firmware	Merge branch 'dmi-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jdelvare/staging	2022-10-11 10:44:20 -07:00
fpga	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
fsi
gnss
gpio	These are the pin control changes for the v6.1 kernel cycle:	2022-10-11 10:59:59 -07:00
gpu	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
greybus
hid	Input updates for 6.1 merge window:	2022-10-11 10:53:25 -07:00
hsi
hte
hv	hyperv-next for 6.1	2022-10-10 13:59:01 -07:00
hwmon	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
hwspinlock
hwtracing	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
i2c	- correct a variable type in the new pci1xxxx driver	2022-10-11 11:03:42 -07:00
i3c
idle
iio	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
infiniband	v6.1 merge window pull request	2022-10-07 12:05:29 -07:00
input	Input updates for 6.1 merge window:	2022-10-11 10:53:25 -07:00
interconnect
iommu	IOMMU Updates for Linux v6.1:	2022-10-10 13:20:53 -07:00
ipack	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
irqchip	IOMMU Updates for Linux v6.1:	2022-10-10 13:20:53 -07:00
isdn	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2022-10-03 17:44:18 -07:00
leds	platform-drivers-x86 for v6.1-1	2022-10-05 10:38:24 -07:00
macintosh	powerpc updates for 6.1	2022-10-09 14:05:15 -07:00
mailbox	mailbox: qcom-ipcc: flag IRQ NO_THREAD	2022-10-05 21:51:58 -05:00
mcb
md	for-6.1/passthrough-2022-10-04	2022-10-07 09:35:50 -07:00
media	Scheduler changes for v6.1:	2022-10-10 09:10:28 -07:00
memory
memstick
message
mfd	- Core Frameworks	2022-10-07 11:24:20 -07:00
misc	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
mmc	TTY/Serial driver update for 6.1-rc1	2022-10-07 16:36:24 -07:00
most
mtd	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
mux
net	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
nfc
ntb
nubus
nvdimm	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
nvme	for-6.1/passthrough-2022-10-04	2022-10-07 09:35:50 -07:00
nvmem
of	Devicetree updates for v6.1:	2022-10-10 13:13:51 -07:00
opp
parisc	asm-generic updates for v6.1	2022-10-06 12:10:37 -07:00
parport
pci	pci-v6.1-changes	2022-10-11 11:08:18 -07:00
pcmcia
peci
perf	Perf events updates for v6.1:	2022-10-10 09:27:46 -07:00
phy	pci-v6.1-changes	2022-10-11 11:08:18 -07:00
pinctrl	These are the pin control changes for the v6.1 kernel cycle:	2022-10-11 10:59:59 -07:00
platform	More ACPI updates for 6.1-rc1	2022-10-10 13:28:06 -07:00
pnp	Merge branches 'acpi-apei', 'acpi-wakeup', 'acpi-reboot' and 'acpi-thermal'	2022-10-10 18:11:11 +02:00
power	power supply and reset changes for the v6.1 series	2022-10-07 11:48:30 -07:00
powercap	Scheduler changes for v6.1:	2022-10-10 09:10:28 -07:00
pps
ps3
ptp
pwm	pwm: Changes for v6.1-rc1	2022-10-07 11:32:10 -07:00
rapidio
ras
regulator	- Core Frameworks	2022-10-07 11:24:20 -07:00
remoteproc	remoteproc: virtio: Fix warning on bindings by removing the of_match_table	2022-10-05 09:20:44 -06:00
reset	Here's the main clk pull request for this merge window. We have some	2022-10-08 10:06:48 -07:00
rpmsg
rtc
s390	s390 updates for the 6.1 merge window	2022-10-09 13:51:40 -07:00
sbus
scsi	hyperv-next for 6.1	2022-10-10 13:59:01 -07:00
sh
siox
slimbus
soc	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
soundwire	soundwire updates for 6.1-rc1	2022-10-07 16:13:55 -07:00
spi	spi: Updates for v6.1	2022-10-04 19:36:53 -07:00
spmi
ssb
staging	Here's the main clk pull request for this merge window. We have some	2022-10-08 10:06:48 -07:00
target	SCSI misc on 20221007	2022-10-07 12:33:18 -07:00
tc
tee	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
thermal	More thermal control updates for 6.1-rc1	2022-10-10 13:52:14 -07:00
thunderbolt	USB/Thunderbolt changes for 6.1-rc1	2022-10-07 16:48:26 -07:00
tty	TTY/Serial driver update for 6.1-rc1	2022-10-07 16:36:24 -07:00
ufs	SCSI misc on 20221007	2022-10-07 12:33:18 -07:00
uio
usb	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
vdpa	virtio: fixes, features	2022-10-10 14:02:53 -07:00
vfio
vhost	virtio: fixes, features	2022-10-10 14:02:53 -07:00
video	fbdev: mb862xx: Fix check of return value from irq_of_parse_and_map()	2022-10-08 15:20:09 +02:00
virt	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
virtio	virtio_pci: use irq to detect interrupt support	2022-10-13 09:33:03 -04:00
vlynq
w1	Char/Misc and other driver changes for 6.1-rc1	2022-10-08 08:56:37 -07:00
watchdog	powerpc updates for 6.1	2022-10-09 14:05:15 -07:00
xen	- Yu Zhao's Multi-Gen LRU patches are here. They've been under test in	2022-10-10 17:53:04 -07:00
zorro
Kconfig
Makefile