linux-stable/drivers/staging/r8188eu/include
Martin Kaiser b5929325f0 staging: r8188eu: Revert "staging: r8188eu: simplify rtw_get_ff_hwaddr"
This reverts commit fd48124e09 ("staging: r8188eu: simplify
rtw_get_ff_hwaddr").

The cleanup in this commit removes the qsel to addr mappings in
rtw_get_ff_hwaddr. The underlying assumption is that rtw_write_port
uses its addr parameter only for the high_queue check.

This is obviously incorrect as rtw_write_port calls
ffaddr2pipehdl(pdvobj, addr);
where addr is mapped to a usb bulk endpoint.

Unfortunately, testing did not show any problems. The Edimax V2 on which I
tested has two bulk out endpoints. I guess that with the incorrect patch,
addr could only be 0 (no high queue) or 6 (high queue), both of which were
mapped to the first bulk out endpoint. Data transfers did still work...

Fixes: fd48124e09 ("staging: r8188eu: simplify rtw_get_ff_hwaddr")
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20230213195407.15085-1-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2023-02-16 13:55:03 +01:00
..
drv_types.h staging: r8188eu: remove intf_stop pointer 2023-02-07 08:41:03 +01:00
Hal8188EPhyCfg.h staging: r8188eu: remove PHY_RFConfig8188E() 2022-09-30 14:34:36 +02:00
Hal8188EPhyReg.h staging: r8188eu: correct misspelled words in comments 2022-10-22 10:00:22 +02:00
Hal8188ERateAdaptive.h staging: r8188eu: replace confusing macros 2022-06-20 09:58:58 +02:00
hal_com.h staging: r8188eu: make c2h_evt_read() static 2022-09-11 13:56:59 +02:00
hal_intf.h staging: r8188eu: use standard error codes in rtl8188eu_inirp_init 2023-02-07 08:41:03 +01:00
HalHWImg8188E_BB.h staging: r8188eu: convert ODM_ReadAndConfig_AGC_TAB_1T_8188E() to int 2022-09-30 14:34:30 +02:00
HalHWImg8188E_MAC.h staging: r8188eu: convert ODM_ReadAndConfig_MAC_REG_8188E() to int 2022-09-30 14:34:30 +02:00
HalHWImg8188E_RF.h staging: r8188eu: convert ODM_ReadAndConfig_RadioA_1T_8188E() to int 2022-09-30 14:34:30 +02:00
HalPhyRf_8188e.h staging: r8188eu: clean up _PHY_PathADDAOn 2021-11-15 10:02:03 +01:00
HalPwrSeqCmd.h staging: r8188eu: move pwr seq defines to HalPwrSeqCmd.c 2022-07-08 14:27:05 +02:00
HalVerDef.h staging: r8188eu: ROMVer is always zero 2022-04-08 15:47:10 +02:00
ieee80211.h staging: r8188eu: use ieee80211 defines for back action codes 2022-06-06 08:05:48 +02:00
odm.h staging: r8188eu: remove unused ijk_matrix_regs_set implementation 2022-11-08 16:26:17 +01:00
odm_HWConfig.h staging: r8188eu: remove ODM_ConfigRFWithHeaderFile() 2022-08-23 15:40:50 +02:00
odm_RegDefine11N.h
odm_RTL8188E.h staging: r8188eu: merge odm_types.h into other headers 2022-10-20 17:19:37 +02:00
osdep_intf.h staging: r8188eu: remove struct intf_priv 2023-01-27 10:10:35 +01:00
osdep_service.h staging: r8188eu: remove extern from function prototypes 2022-11-02 08:28:41 +01:00
rtl8188e_cmd.h staging: r8188eu: Fix some endian problems 2023-01-23 19:03:53 +01:00
rtl8188e_dm.h staging: r8188eu: EntryMaxUndecoratedSmoothedPWDB is set but not used 2022-01-25 16:28:41 +01:00
rtl8188e_hal.h staging: r8188eu: Associate pointer symbol with parameter name 2022-10-22 10:00:22 +02:00
rtl8188e_recv.h staging: r8188eu: make rtl8188eu_{init,free}_recv_priv() static 2022-08-16 15:14:59 +02:00
rtl8188e_rf.h staging: r8188eu: remove PHY_RF6052_Config8188E() 2022-09-30 14:34:36 +02:00
rtl8188e_spec.h staging: r8188eu: remove some unused CAM defines 2023-01-17 19:31:21 +01:00
rtl8188e_xmit.h staging: r8188eu: remove redundant parameter 2023-01-27 10:10:36 +01:00
rtw_ap.h staging: r8188eu: make rtw_sta_flush to void 2022-10-31 09:05:18 +01:00
rtw_br_ext.h staging: r8188eu: remove all aliased DBG_88E calls 2022-02-17 16:00:36 +01:00
rtw_cmd.h staging: r8188eu: make rtw_chk_hi_queue_cmd a void function 2023-01-27 10:10:36 +01:00
rtw_eeprom.h staging: r8188eu: use a local buffer for efuse data 2022-07-11 10:06:45 +02:00
rtw_efuse.h staging: r8188eu: merge EFUSE_ShadowMapUpdate with its caller 2022-07-11 10:06:45 +02:00
rtw_event.h
rtw_fw.h staging: r8188eu: move struct rt_firmware to rtw_fw.h 2022-04-08 15:47:10 +02:00
rtw_ht.h
rtw_io.h staging: r8188eu: use standard error codes in rtw_read_port 2023-02-07 08:41:03 +01:00
rtw_ioctl.h staging: r8188eu: clean up rtw_ioctl.h 2022-04-08 15:47:11 +02:00
rtw_ioctl_set.h staging: r8188eu: change return type of rtw_set_802_11_disassociate to void 2022-11-08 16:26:34 +01:00
rtw_iol.h staging: r8188eu: call rtw_IOL_append_WRF_cmd directly 2022-06-20 10:00:52 +02:00
rtw_led.h staging: r8188eu: remove padapter from struct led_priv 2022-10-20 17:41:42 +02:00
rtw_mlme.h staging: r8188eu: merge two rtw_free_network_nolock functions 2022-11-08 16:29:30 +01:00
rtw_mlme_ext.h staging: r8188eu: remove unused da parameter 2022-12-05 13:29:23 +01:00
rtw_p2p.h
rtw_pwrctrl.h staging: r8188eu: remove change_rfpwrstate 2023-02-07 08:41:18 +01:00
rtw_recv.h staging: r8188eu: correct misspelled words in comments 2022-10-22 10:00:22 +02:00
rtw_rf.h staging: r8188eu: remove unused enum and defines 2022-01-03 14:31:08 +01:00
rtw_security.h staging: r8188eu: remove unused aes tables from rtw_security.c 2022-02-21 18:11:34 +01:00
rtw_xmit.h staging: r8188eu: Revert "staging: r8188eu: simplify rtw_get_ff_hwaddr" 2023-02-16 13:55:03 +01:00
sta_info.h staging: r8188eu: convert rtw_free_stainfo() to void 2022-11-02 08:28:41 +01:00
usb_ops.h staging: r8188eu: remove usb_ops_linux.h 2023-01-27 10:12:55 +01:00
usb_osintf.h staging: r8188eu: remove header usb_vendor_req.h 2022-04-08 15:47:11 +02:00
wifi.h staging: r8188eu: use ieee80211 helper for protected bit 2022-12-05 13:26:13 +01:00
wlan_bssdef.h staging: r8188eu: remove unused struct declarations 2022-11-08 16:29:21 +01:00