mirror of
https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
synced 2024-09-15 15:15:47 +00:00
f63f856086
Sparse lists the following warnings: CHECK drivers/staging/r8188eu/core/rtw_mlme.c drivers/staging/r8188eu/core/rtw_mlme.c:1197:49: warning: incorrect type in argument 2 (different base types) drivers/staging/r8188eu/core/rtw_mlme.c:1197:49: expected restricted __le16 [usertype] mstatus_rpt drivers/staging/r8188eu/core/rtw_mlme.c:1197:49: got unsigned short [assigned] [usertype] media_status_rpt drivers/staging/r8188eu/core/rtw_mlme.c:1275:57: warning: incorrect type in argument 2 (different base types) drivers/staging/r8188eu/core/rtw_mlme.c:1275:57: expected restricted __le16 [usertype] mstatus_rpt drivers/staging/r8188eu/core/rtw_mlme.c:1275:57: got unsigned short [assigned] [usertype] media_status CHECK drivers/staging/r8188eu/core/rtw_mlme_ext.c drivers/staging/r8188eu/core/rtw_mlme_ext.c:6842:58: warning: incorrect type in argument 2 (different base types) drivers/staging/r8188eu/core/rtw_mlme_ext.c:6842:58: expected restricted __le16 [usertype] mstatus_rpt drivers/staging/r8188eu/core/rtw_mlme_ext.c:6842:58: got unsigned short [assigned] [usertype] media_status The second argument of rtl8188e_set_FwMediaStatus_cmd() needs to be in CPU order, not little-endian; however, when it uses that value to call FillH2CCmd_88E() the parameter must be in little-endian order as that value will be sent to the firmware. Note that the conversion from LE to CPU order was le16_to_cpu() rather than the correct cpu_to_le16. The definition of FillH2CCmd_88E() is revised, and the proper conversion routine is used. Note that the original code performed one byte swap on the secong argument of FillH2CCmd_88E(), and got the correct answer even though the semantics were very wrong. Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> # Edimax N150 Reviewed-by: Dan Carpenter <error27@gmail.com> Reported-by: Gaurav Pathak <gauravpathak129@gmail.com> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net> Link: https://lore.kernel.org/r/20230120191119.13163-1-Larry.Finger@lwfinger.net Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
90 lines
2.2 KiB
C
90 lines
2.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
|
|
/* Copyright(c) 2007 - 2011 Realtek Corporation. */
|
|
|
|
#ifndef __RTL8188E_CMD_H__
|
|
#define __RTL8188E_CMD_H__
|
|
|
|
enum RTL8188E_H2C_CMD_ID {
|
|
/* Class Common */
|
|
H2C_COM_RSVD_PAGE = 0x00,
|
|
H2C_COM_MEDIA_STATUS_RPT = 0x01,
|
|
H2C_COM_SCAN = 0x02,
|
|
H2C_COM_KEEP_ALIVE = 0x03,
|
|
H2C_COM_DISCNT_DECISION = 0x04,
|
|
H2C_COM_INIT_OFFLOAD = 0x06,
|
|
H2C_COM_REMOTE_WAKE_CTL = 0x07,
|
|
H2C_COM_AP_OFFLOAD = 0x08,
|
|
H2C_COM_BCN_RSVD_PAGE = 0x09,
|
|
H2C_COM_PROB_RSP_RSVD_PAGE = 0x0A,
|
|
|
|
/* Class PS */
|
|
H2C_PS_PWR_MODE = 0x20,
|
|
H2C_PS_TUNE_PARA = 0x21,
|
|
H2C_PS_TUNE_PARA_2 = 0x22,
|
|
H2C_PS_LPS_PARA = 0x23,
|
|
H2C_PS_P2P_OFFLOAD = 0x24,
|
|
|
|
/* Class DM */
|
|
H2C_DM_MACID_CFG = 0x40,
|
|
H2C_DM_TXBF = 0x41,
|
|
};
|
|
|
|
struct cmd_msg_parm {
|
|
u8 eid; /* element id */
|
|
u8 sz; /* sz */
|
|
u8 buf[6];
|
|
};
|
|
|
|
struct setpwrmode_parm {
|
|
u8 Mode;/* 0:Active,1:LPS,2:WMMPS */
|
|
u8 SmartPS_RLBM;/* LPS= 0:PS_Poll,1:PS_Poll,2:NullData,WMM= 0:PS_Poll,1:NullData */
|
|
u8 AwakeInterval; /* unit: beacon interval */
|
|
u8 bAllQueueUAPSD;
|
|
u8 PwrState;/* AllON(0x0c),RFON(0x04),RFOFF(0x00) */
|
|
};
|
|
|
|
struct H2C_SS_RFOFF_PARAM {
|
|
u8 ROFOn; /* 1: on, 0:off */
|
|
u16 gpio_period; /* unit: 1024 us */
|
|
} __packed;
|
|
|
|
struct joinbssrpt_parm {
|
|
u8 OpMode; /* RT_MEDIA_STATUS */
|
|
};
|
|
|
|
struct rsvdpage_loc {
|
|
u8 LocProbeRsp;
|
|
u8 LocPsPoll;
|
|
u8 LocNullData;
|
|
u8 LocQosNull;
|
|
u8 LocBTQosNull;
|
|
};
|
|
|
|
struct P2P_PS_Offload_t {
|
|
u8 Offload_En:1;
|
|
u8 role:1; /* 1: Owner, 0: Client */
|
|
u8 CTWindow_En:1;
|
|
u8 NoA0_En:1;
|
|
u8 NoA1_En:1;
|
|
u8 AllStaSleep:1; /* Only valid in Owner */
|
|
u8 discovery:1;
|
|
u8 rsvd:1;
|
|
};
|
|
|
|
struct P2P_PS_CTWPeriod_t {
|
|
u8 CTWPeriod; /* TU */
|
|
};
|
|
|
|
/* host message to firmware cmd */
|
|
void rtl8188e_set_FwPwrMode_cmd(struct adapter *padapter, u8 Mode);
|
|
void rtl8188e_set_FwJoinBssReport_cmd(struct adapter *padapter, u8 mstatus);
|
|
u8 rtl8188e_set_raid_cmd(struct adapter *padapter, u32 mask);
|
|
void rtl8188e_Add_RateATid(struct adapter *padapter, u32 bitmap, u8 arg,
|
|
u8 rssi_level);
|
|
|
|
void rtl8188e_set_p2p_ps_offload_cmd(struct adapter *adapt, u8 p2p_ps_state);
|
|
|
|
void CheckFwRsvdPageContent(struct adapter *adapt);
|
|
void rtl8188e_set_FwMediaStatus_cmd(struct adapter *adapt, u16 mstatus_rpt);
|
|
|
|
#endif/* __RTL8188E_CMD_H__ */
|