Commit graph

8530 commits

Author SHA1 Message Date
Joseph Schorr
2ae69dc651 Further fixes to the Kubernetes config provider, and a new set of proper unit tests 2018-05-10 16:44:18 +03:00
Joseph Schorr
e7ee235b31 Fix error displayed if a description was not entered for creating a robot
We were sending a `null` description, which the schema does not allow

Fixes https://jira.coreos.com/browse/QUAY-935
2018-05-10 12:42:33 +03:00
josephschorr
babb7bb803
Merge pull request #3072 from quay/joseph.schorr/QUAY-933/dockerfile-path
Fix lookup of Dockerfile in archives
2018-05-09 21:04:53 +03:00
Joseph Schorr
134433c715 Fix lookup of Dockerfile in archives
Fixes https://jira.coreos.com/browse/QUAY-933
2018-05-09 21:04:37 +03:00
Joseph Schorr
f06eec8a35 Fix issue where we didn't delete robots immediately under a namespace
This could result in "hanging" robot accounts, although that would only leak the names of said accounts. Now we delete them immediately AND we proactively delete them before replacing the namespace (just to be sure)
2018-05-09 17:53:30 +03:00
Sam Chow
bd1f3e6bb8
Merge pull request #3068 from quay/browser-notifications
Browser notifications setting
2018-05-08 14:49:28 -04:00
Sam Chow
5e80e5423c add button class 2018-05-08 12:02:52 -04:00
Sam Chow
3a25a7c9e6 remove useless props in button 2018-05-08 10:39:10 -04:00
josephschorr
7722721396
Merge pull request #3064 from quay/joseph.schorr/QUAY-928/fix-worker-count
Fix worker count to  use CPU affinity correctly and be properly bounded
2018-05-07 20:45:26 +03:00
josephschorr
de36b36f9a
Merge pull request #3051 from quay/joseph.schorr/QUAY-911/fix-kub-provider
Fix Kubernetes config provider for recent changes in Kub API
2018-05-07 20:45:09 +03:00
Sam Chow
7b28f745f7 Update naming of optional parameter 2018-05-07 12:47:29 -04:00
Sam Chow
84ad1d83e1 Add support for Enterprise logos in notifications 2018-05-07 11:11:33 -04:00
Sam Chow
6fe579119b Use cookie service and small cleanup for pr 2018-05-04 17:15:00 -04:00
Sam Chow
2d3583fb44 Add button to enable desktop notifications 2018-05-04 16:24:56 -04:00
josephschorr
f0ec26ea54
Merge pull request #3066 from quay/ipresolver-bug
Missing parens on IP resolver lookup
2018-05-04 02:17:53 +03:00
Joseph Schorr
942f526016 Missing parens on IP resolver lookup
Also adds a generic catch in case this happens again; we should *never* fail
2018-05-04 02:14:26 +03:00
josephschorr
bf943e7713
Merge pull request #3065 from quay/joseph.schorr/QUAY-929/upgrade-recaptcha
Fix recaptcha after recent Google changes
2018-05-03 18:49:01 +03:00
Joseph Schorr
00b0e831a8 Fix recaptcha after recent Google changes
Fixes https://jira.coreos.com/browse/QUAY-929
2018-05-03 18:45:55 +03:00
Joseph Schorr
b26a131085 Fix worker count to use CPU affinity correctly and be properly bounded
We were using the `cpu_count`, which doesn't respect container affinity. Now, we use `cpu_affinity` and also bound to make sure we don't start a million workers

Fixes https://jira.coreos.com/browse/QUAY-928
2018-05-03 11:57:20 +03:00
Sam Chow
e80c56e441
Merge pull request #3062 from quay/long-robots
Add some css for long name edge case of robots
2018-05-02 13:58:13 -04:00
Sam Chow
49ce38ea04 Add styling for overflowing table & dropdown robot
Bound modal box by container, remove !important

The important was introduced as a fix to
https://jira.coreos.com/browse/QUAY-881
However, after removal it does not seem to be necessary (Cannot
reproduce with the !important gone).

Adds bounding for the modal boxes & title

Joins the username/password for robot in box
2018-05-02 13:57:20 -04:00
Joseph Schorr
8c1b0e673c Implement the remaining registry tests in the new py.test format 2018-05-01 13:28:24 +03:00
Joseph Schorr
77adf9dd77 Fix bug which allowed for implicit library namespace access via the V1 registry protocol when the feature flag was off
Now we raise a 400 as expected
2018-05-01 13:28:24 +03:00
Joseph Schorr
178c8e7cb0 Fix bug in in-memory data cache
Previously, if we didn't find a key, we'd empty the entire cache, making it essentially a single-key cache. We skip clearing now, although this does mean we won't GC expired entries (not a problem for tests, though)
2018-05-01 13:28:24 +03:00
Joseph Schorr
23c19bcbc1 Implement support for registry integration tests via py.test
This change implements support for registry integration tests using the new py.test-based live server test fixture. We can now parametrize the protocols we use (in prep for V2_2), and it makes the code *much* cleaner and less hacky.

Note that moving the vast majority of the tests over from the existing impl will come as a followup PR
2018-05-01 13:28:24 +03:00
Joseph Schorr
85496b8195 Translate LiveServerTestCase into a py.test-compatible liveserver fixture
This allow us to super-easily instantiate a live, running Flask server with the test app, as well as interact with it, without any of the crazy boilerplate we previously used
2018-05-01 13:28:24 +03:00
Sam Chow
c8824aeb58
Merge pull request #3061 from quay/fix-empty-creds
Default to the first credential tab if no cookie saved
2018-04-26 10:26:23 -07:00
Sam Chow
b5db46ad06 Default to the first credential tab if no cookie
Also removes the credential dialog id, to ensure persistence across
sessions
2018-04-26 13:24:53 -04:00
Sam Chow
f89ad30320
Merge pull request #3060 from quay/max-results-help-text
Configurable options for search, disable next page & add help text when at max results
2018-04-25 08:17:35 -07:00
Sam Chow
1afedafcbb Configurable options for search, info when at max
includes the options for  maximum search results per page, and the
maximum number of pages available before help text is shown, and
the next page button is disabled
2018-04-25 11:12:09 -04:00
josephschorr
b5de98b958
Merge pull request #3058 from quay/known-threat-build-count
Add support for reduced initial build count for new possible abusing users
2018-04-24 18:12:02 +03:00
Joseph Schorr
e20295f573 Fix Kubernetes config provider for recent changes in Kub API
Kubernetes secret volumes are now mounted as read-only, so we have to write the files *only* via the Kub API

Fixes https://jira.coreos.com/browse/QUAY-911
2018-04-22 17:22:28 +03:00
Joseph Schorr
3309daa32e Add support for reduced initial build count for new possible abusing users
If configured, we now check the IP address of the user signing up and, if they are a possible threat, we further reduce their number of allowed maximum builds to the configured value.
2018-04-20 18:46:32 +03:00
josephschorr
8d5e8fc685
Merge pull request #3035 from quay/joseph.schorr/QUAY-892/multiple-auth-scope
Multiple auth scope support in V2 auth
2018-04-18 20:54:36 +03:00
Joseph Schorr
a59c951aa3 Add support for multiple scope parameters on V2 auth requests
Fixes https://jira.coreos.com/browse/QUAY-892
2018-04-18 20:16:49 +03:00
Joseph Schorr
86aa93aab5 Add a new test suite for the v2auth generate_registry_jwt endpoint 2018-04-18 20:16:49 +03:00
josephschorr
bda00e2dc0
Merge pull request #3050 from coreos-inc/joseph.schorr/QUAY-886/oauth-query-param
Add support for defining custom query parameters for OIDC endpoints
2018-04-11 14:03:24 -04:00
josephschorr
96458c6420
Merge pull request #3053 from coreos-inc/2.9.1-release
Update CHANGELOG for 2.9.1
2018-04-09 11:47:15 -04:00
Joseph Schorr
e07004141b Update CHANGELOG for 2.9.1 2018-04-09 10:26:22 -04:00
josephschorr
916441b5f4
Merge pull request #3052 from coreos-inc/joseph.schorr/QUAY-912/fix-postgres-migration
Postgres requires defaults for non-nullable cols, even integer ones
2018-04-09 10:23:46 -04:00
Joseph Schorr
4418772745 Postgres requires defaults for non-nullable cols, even integer ones
Fixes https://jira.coreos.com/browse/QUAY-912
2018-04-08 18:54:23 -04:00
Joseph Schorr
3cd314874f Add support for defining custom query parameters for OIDC endpoints
Fixes https://jira.coreos.com/browse/QUAY-886
2018-04-06 12:48:03 -04:00
josephschorr
ecf6db256d
Merge pull request #3049 from coreos-inc/joseph.schorr/QUAY-881/overflow
Fix overflow of cor-tabs by switching to flex box
2018-04-04 17:09:28 -04:00
Joseph Schorr
1fce4a1a1d Fix overflow of cor-tabs by switching to flex box
Fixes https://jira.coreos.com/browse/QUAY-881
2018-04-04 17:07:31 -04:00
Brad Ison
b4849997e7
Merge pull request #3038 from bison/peewee-fixes
Prepare to update Peewee
2018-04-04 15:17:20 -04:00
Brad Ison
e90da9f2c0
Fix API team membership test 2018-04-04 14:22:11 -04:00
Brad Ison
8e5c67e207
Use get_or_create in place of create_or_get
Peewee v2.9.0 removes the create_or_get method.
2018-04-04 14:21:16 -04:00
Brad Ison
c2ad6c5060
Check for null model objects
As of v2.8.2, peewee will not create model objects with all null
fields when an FK reference is null.  We have to check the model
instances for None.  See:

  https://github.com/coleifer/peewee/issues/1012
2018-04-04 14:19:45 -04:00
josephschorr
a0d0e42d7a
Merge pull request #3048 from coreos-inc/image-model-tests
Add tests for image model, fix a small bug and remove an unused function
2018-04-04 13:29:43 -04:00
Joseph Schorr
82da2042fd Add tests for image model, fix a small bug and remove an unused function 2018-04-04 13:13:52 -04:00